Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 6 Mar 2023 16:51:46 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>, pgsql-hackers@postgresql.org
Subject: Re: add PROCESS_MAIN to VACUUM
Message-ID: <ZAWbkiZSdFZOTS7F@paquier.xyz>
References: <20221230000028.GA435655@nathanxps13>
 <20230107050724.GA914213@nathanxps13>
 <CALDaNm1bKSNG9Jc1mrtk2ZWsVdvTQw+XOnbB3yL_Xf57oAdg5Q@mail.gmail.com>
 <20230119190807.GA4062411@nathanxps13>
 <Y/7xVESfLgw3E/F/@paquier.xyz>
 <20230301172637.GA1456203@nathanxps13>
 <ZAA5vt7jUTRpPDmL@paquier.xyz>
 <20230302065359.GA2140777@nathanxps13>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="P+YLkchV1NpFMj+K"
Content-Disposition: inline
In-Reply-To: <20230302065359.GA2140777@nathanxps13>
Archived-At: 
 <https://www.postgresql.org/message-id/ZAWbkiZSdFZOTS7F%40paquier.xyz>
Precedence: bulk


--P+YLkchV1NpFMj+K
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Mar 01, 2023 at 10:53:59PM -0800, Nathan Bossart wrote:
> I don't feel a strong need for that, especially now that we aren't
> modifying params anymore.

That was mostly OK for me, so applied after tweaking a couple of
places in the tests (extra explanations, for one), the comments and
the code.

The part that improved the tests of PROCESS_TOAST was useful on its
own, so I have done that separately as 46d490a.  Another thing that I
have found incorrect is the need for two pg_stat_reset() calls that
would reflect on the whole database, in the middle of a test running
in parallel of other things.  As far as I understand, you have added
that to provide fresh data after a single command while relying on
vactst, but it is possible to get the same amount of coverage by
relying on cumulated counts, and that gets even more solid with all
these commands run on an independent table.
--
Michael

--P+YLkchV1NpFMj+K
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmQFm5IACgkQnvQgOdby
QH0SQw/+M2CaVcpJ/ESzaKPexzVSSHLPIcN15Z5bxRXjNknO7V3xhq0nJBpOGtxZ
taqrOSV3vzg10AWPK68Irlb4IxzeTXFuG3yIpUxgt3Ajgnxaop0vDucb2VaHZvUF
WsLLYGle0Z0D2lQoxrVFjpUTih7aBBnMp0pf5tgSOPTk7/3wEa4JwQ0f5sa5X9xV
qzQJzxfgHTK+g0R8pRZ9WHKyvgKQb/X4pvQ1k1m6KcFxocI4ro/UoDJoWlpAh5cT
1j9pltuWCt0T6ALLcr0FreFI5cZRoIaoZpV+I7CB4Zmj/CtFWHUAPGzjNtY6pliP
WewrlegxScaY22f5Q4uhzcsLXvM11Hyo1+thFbO0iShFaUh3XKkKqseVc9WDXaaT
HbTDUrDLFkcSagYa1bJwKre4Wduk4E5SHswK4bjLknuj08qYr1UK6t3qhk9UbNat
z6ckexuRZZIq2YEh26UAx3g5Nh4+Dy5DhTkn3h8WkC6MMUTWk21eD7sXr7wmziM2
aaYAIltatOMriDWYEj6UkxO3sEjAw5zLeGaLxr1192vmPJC99dIX2tihCl/w+TdB
eKFsY9wSfwclbN6+NB/d1LW9wX7Yv4n8A9OGq3uJe0TlblWl8R78ky9BAqu49j1X
Ln8eilQWeytPYSemTvxt/xxVARCnVhTPCRr1DvSA7yBL6VdI4SA=
=cJZz
-----END PGP SIGNATURE-----

--P+YLkchV1NpFMj+K--