Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZOGX-0004wk-Kd for pgsql-hackers@arkaria.postgresql.org; Tue, 07 Mar 2023 03:45:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pZOGV-00032L-61 for pgsql-hackers@arkaria.postgresql.org; Tue, 07 Mar 2023 03:45:27 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZOGT-000329-LB for pgsql-hackers@lists.postgresql.org; Tue, 07 Mar 2023 03:45:26 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZOGP-0008Le-KJ for pgsql-hackers@postgresql.org; Tue, 07 Mar 2023 03:45:24 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id C9A623200911; Mon, 6 Mar 2023 22:45:16 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 06 Mar 2023 22:45:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1678160716; x=1678247116; bh=2X Yzr+TGafo/03oT6oqIAk3QnYAbSIa+Fwyl+8vQitA=; b=Cj2fCfZhOMx1C7D2R1 jz8WWJ42wyBzAriy7EMSRZ1caOcrorlp808M1TDPLDifByNqXKxo5AGF5cNJyk/Z DRn8dEyeboqL18wfqueB+u5mR+0jlGZN8M8PP2A1vZY0ztAFQWTwpVqLItDxvz5W IvHmHYk+sZIRhNVz54f4RJaTz6s/GVPc2SYe3B06BNnKCzbPD1hS+XBpVT/voOKR xV8KQeR1ZRmzBPpjpXRxugJd+Y+qL0cfxdUeFxB5+f4A0/ueSAoZ0GsEOpEAdZOe FdT3SfFlXxwGsVTLQTKvotxQq6OERjreufXdNZTk8mEpQSCsLFGrdyIQsJGEi7x2 bVSg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1678160716; x=1678247116; bh=2XYzr+TGafo/0 3oT6oqIAk3QnYAbSIa+Fwyl+8vQitA=; b=IfUc+XRdUc52EZ2vWEGaARgrCqrpS 8Ny8b5/HhUen7ByPOEfdaS7COcigNUkmlC+P1KZvjcR/oaXAHjUHAxptkN/Nw/pl Xi8f7Tud8Cg5ap283Me7TXVYRWI/VvbwFHmTWPvgR40l5N+62LUtcb09eOcy87ym fxZxNIQ8urB9Ucaav2R/l181O+elLdwxuiE0QzvC5Fsb0onA9xc/m5QA2/djEUmI VZP65oLAWqpWBLHjWBU5ScU7x4vFm7jGxUeyLmrwYRsVLtV5d3E/Btkb7JA8emDk H3y47oojlZ2sHW+A8WDhsazSYQKl+C669FBVBrC6hpQKv3G4M4l/MKHZA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddtledgiedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 6 Mar 2023 22:45:12 -0500 (EST) Date: Tue, 7 Mar 2023 12:45:08 +0900 From: Michael Paquier To: Nathan Bossart Cc: Melanie Plageman , pgsql-hackers@postgresql.org Subject: Re: add PROCESS_MAIN to VACUUM Message-ID: References: <20230306173723.GA2934573@nathanxps13> <20230306194009.5cn6sp3wjotd36nu@liskov> <20230306202734.GA3033389@nathanxps13> <20230306211337.GA3076909@nathanxps13> <20230306220958.rk4b4msmybi6hm56@liskov> <20230306224310.GA3165453@nathanxps13> <20230307005949.GA3266981@nathanxps13> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jr/e3vxxXkx2+96S" Content-Disposition: inline In-Reply-To: <20230307005949.GA3266981@nathanxps13> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --jr/e3vxxXkx2+96S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 06, 2023 at 04:59:49PM -0800, Nathan Bossart wrote: > That did cross my mind, but I was worried that trying to explain all that > here could cause confusion. >=20 > If PROCESS_MAIN is set (the default), it's time to vacuum the main > relation. Otherwise, we can skip this part. If processing the TOAST > table is required (e.g., PROCESS_TOAST is set), we'll force > PROCESS_MAIN to be set when we recurse to the TOAST table so that it > gets processed here. >=20 > How does that sound? Sounds clear to me, thanks! Melanie, what do you think? -- Michael --jr/e3vxxXkx2+96S Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmQGs0QACgkQnvQgOdby QH3HNw//eqt2odH5Eb8bDjp7M4gTla1iYBZNZ6zAUUIlrHpQJi32h/pCXq5cctSs 5Can5ojrdcV6z0t91A31xXYO/F6OnlC80yXnQYP61L7DnPuDwVLQDCp/C1G9Vk3Y c9fyTFLnHmvo0zLRhkCU7IOiNUJuXVz05rovmV7dOUChy7rAWHiSiNTbFGNnU2Nn 3YpIIDHbRyd0PohYHB0brJ7Bq0r/L5Hobgl03XPe13EshVr2IhnQ96gFSzt7DuK4 YGCCFld5bpijqO4PWzh0ZCsd9cqgY1UbxQn001DxWAcFgMBmTLg+ChfwvIsdoNUl yUereNgLd9RhiC5X44zYmStR5ymQny82lZ64X6SKmi2RVg8cYEXdGPUqBP4+00a2 D/ay3DlMgRySDS+C4jnLkhQlXhQX7OAaC0V/vv6j79YKuxls/K/QHgARdw9P1A4H hl5qOp9TEvxZg++5xLa3S7KYiN/w9QVs1cGWGW6FlhWgPhzI/1lbuclq1e2Cgop4 PSY6vQF93AkiYzyo3QusmBQjomWIr/hdFt2ZZkiQo01DN9TbVoyenSG5z/d+vhZM 3FOp8P5slU6NeOKqj41M9fTgZ8TS8dDQSknoGNYH5ySldxZo4Q91G2dsKLF/KKsK uM2NRic5nD4/TyDzKkT3AlWBAOb/XySAEBgcC/l2+kJtHRYfDlg= =NDlO -----END PGP SIGNATURE----- --jr/e3vxxXkx2+96S--