Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 8 Mar 2023 19:53:13 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	boekewurm+postgres@gmail.com, melanieplageman@gmail.com,
	pgsql-hackers@postgresql.org, pg@bowt.ie
Subject: Re: Add pg_walinspect function with block info columns
Message-ID: <ZAhpGfbFgvX9SEMX@paquier.xyz>
References: <ZAaGkCDEl8kC/GWH@paquier.xyz>
 <20230307.111745.676528378431466705.horikyota.ntt@gmail.com>
 <ZAbPUedT4uURiHTO@paquier.xyz>
 <20230307.154902.1060895277048303254.horikyota.ntt@gmail.com>
 <ZAblPeGOe4bxY0HE@paquier.xyz>
 <CALj2ACVoowu=14F9uLSPfT5p0tJRtssAN47p8Kpq55SLPT=ZxQ@mail.gmail.com>
 <ZAg5CzQM4ioRJg/7@paquier.xyz>
 <CALj2ACXR_SWazf5UVTBPa_32rwD2=M4Z1j6qt8k7QND2BEpuVA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="4F5ZFhAALAaw8FUo"
Content-Disposition: inline
In-Reply-To: <CALj2ACXR_SWazf5UVTBPa_32rwD2=M4Z1j6qt8k7QND2BEpuVA@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZAhpGfbFgvX9SEMX%40paquier.xyz>
Precedence: bulk


--4F5ZFhAALAaw8FUo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Mar 08, 2023 at 04:01:56PM +0530, Bharath Rupireddy wrote:
> I understand that performance is critical here but we need to ensure
> memory is used wisely. Therefore, I'd still vote to free at least the
> major contributors here, that is, pfree(raw_data);, pfree(raw_page);
> and pfree(flags); right after they are done using. I'm sure pfree()s
> don't hurt more than resetting memory context for every block_id.

Okay by me to have intermediate pfrees between each block scanned if
you feel strongly about it.

> I think we need to output block data length (blk->data_len) similar to
> fpilen to save users from figuring out how to get the length of a
> bytea column. This will also keep block data in sync with FPI info.

length() works fine on bytea, so it can be used on the block data.
fpilen is a very different matter as it would be the length of a page
without a hole, or just something compressed.
--
Michael

--4F5ZFhAALAaw8FUo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmQIaRkACgkQnvQgOdby
QH2Aug//W/mp66tShv3bK+FYGdbaqufU9XWC4nPs84iJQ8NRCZcVvFHCMnYCfvl0
9x1wzJWwLGEMqugljakpy6kaXnUJ4jXuN7/aDavfHnQJsFX5TKV3/Z95J5JPQYG0
nSH3JWNIOXS+dWAof4phi8CUeN9BK4gTn+C1imz5kRTwMyQ9SEx4jkU5zCmJgjX6
r8uNbA+LeLHWI+UcqCtUzd/J2oilxg6AQmYywFxuMjh+FUyB/yHaI7+5q5iAS3zp
UE46V6rELIDVaW1syp6skaIlJV8UffKfjS2TLURgvDUgUX/tx3BNMD0HZpaPtqmS
jwq+yan2yCiBXrjgjq+2e8SAcOJeKl7TVGYLux3ILccqYFyDHTRYqHVsOU+b/Rgx
BSx6CacV5u0e3shJHtxXCcocLFMZyWS/GcBvfuki0LYlGWzir9uOFVQodRmFeFKd
m0LduV3E/K4TBUuoIGiQpx4dbwf+rZfYbVqcZrMYBvHUQlr9kVmO1qDjtmAYPAZz
23Zh2hDi4lR8jTDq9gq+xr+W5lA1c8vRjiHt7PgCsGcuI/zyoBJbx1B7eOe+dpTL
GjrAv1UtKk5K4v+CTRWcCp+VXxlhmbD2HY56fHuozNKc7gxZo+NRSReXHtwIN9cm
xX8cEqVflgNiUmrvi7zzSrjQ55mkjdzWs9B++D3zo5xyKAF7Yd8=
=Prt6
-----END PGP SIGNATURE-----

--4F5ZFhAALAaw8FUo--