Feedback-ID: i0fe9450f:Fastmail
Date: Sat, 25 Mar 2023 11:56:22 +0900
From: Michael Paquier <michael@paquier.xyz>
To: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
Cc: Andres Freund <andres@anarazel.de>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Reconcile stats in find_tabstat_entry() and get rid of
 PgStat_BackendFunctionEntry
Message-ID: <ZB5i1lt3v/AUSvpq@paquier.xyz>
References: <20230214.151102.1070436528757437157.horikyota.ntt@gmail.com>
 <9262b2a9-6785-1f83-bf7f-7fcf90c2c113@gmail.com>
 <20230215.095644.822493184688844040.horikyota.ntt@gmail.com>
 <130095b4-7c6d-b6f1-69d4-94f66231f81d@gmail.com>
 <20230216212121.uvav7xgdh2ysqjy5@awork3.anarazel.de>
 <f08fee25-1dac-b68b-19af-f4b55ceb3802@gmail.com>
 <ZBK3S5Na71pjgGCX@paquier.xyz>
 <621ed53c-4d9a-8f77-ab8c-20235f2d95a1@gmail.com>
 <ZBMBh5ve3tyqH5/m@paquier.xyz>
 <f6ea424b-fabe-b702-e4e3-b71ebc827d59@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="yf12ZqtS9bTHz5zO"
Content-Disposition: inline
In-Reply-To: <f6ea424b-fabe-b702-e4e3-b71ebc827d59@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZB5i1lt3v/AUSvpq%40paquier.xyz>
Precedence: bulk


--yf12ZqtS9bTHz5zO
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 16, 2023 at 02:13:45PM +0100, Drouvot, Bertrand wrote:
> On 3/16/23 12:46 PM, Michael Paquier wrote:
>>> I don't think we should pay any particular attention to those 2 ones
>>> as anyway nothing prevent the 7 others to be called outside of the
>>> pg_stat_xact_all_tables view.
>>=20
>> I am not quite sure, TBH.  Did you look at the difference with a long
>> chain of subtrans, like savepoints?  The ODBC driver "loves" producing
>> a lot of savepoints, for example.
>=20
> No, I did not measure the impact.

I have been thinking again about this particular point, and I would be
fine with an additional boolean flag to compute the subtrans data in
the global counter when only necessary.  This would not make the
macros for the stat functions that much more complicated, while being
sure that we don't do unnecessary computations when we know that we
don't need them..
--
Michael

--yf12ZqtS9bTHz5zO
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmQeYtYACgkQnvQgOdby
QH0Lyg/+JahYqQhOYsBavOlyB7KOpSzsYVYCFeFIgyHwrUcUGCIW5LJbmJxQADer
ICoV3oj3dMbixqEeaspT3s/WvJyNgSU8iP5/3CwjGh1/Q9RRvqQPJ1mJqnCBVXM0
4iCQC/eqAM93xTK2SdVihGQ7N1lrpOmJz4ZG7DWWl+ohe1Hm2X/jmR9kA+tWZe/F
J6RA2blaIhv0YoE/S63FyymfEuemSIq4N390piK57AZE5kMAMZUZA3ceulh2kjPg
CpD5utZvbZnPrO++F1D6m/KeyI1f3Q0A12o3Gx9L8M3cS/c3sM7fFEtw2ZFXNMgW
xy/8vDaO59ISybeZY9Sk90ro5OtmpORbpaWvLymsJDR90mFuBOn3S74a8itKHN2D
a8horHgT5onIWAoltlG697FwwXKmKJC1o+zMJfOT8j/seJj9JeHv7f+YY0Y0c0jw
5iXRhcrrB2GwFOYVGVYyyxX8wE6n2Kfi8lh93obHPSdOuuQBHvDitzoN74EbBSnj
IW3uE+877VoFgxx/NWK6LfAD36q/hWnQ0SiKon9VYPDocKQpTYPdOuWmgzY+QWol
QHiTJEaOhJmb0i/GNtr2qw/T/NjOmhb/xfEVhKc/2ovpDv2wMzlsriHrbA7Rctzf
QpCi0NRtREPhUQ8jq+lYbIPJOwOwQffF6CeJHXSxi3OjuEhN5gk=
=Jdy9
-----END PGP SIGNATURE-----

--yf12ZqtS9bTHz5zO--