Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcIHm-0002Tn-Hp for pgsql-hackers@arkaria.postgresql.org; Wed, 15 Mar 2023 03:58:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pcIHl-0004ZQ-Ct for pgsql-hackers@arkaria.postgresql.org; Wed, 15 Mar 2023 03:58:45 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcIHj-0004ZG-Ob for pgsql-hackers@lists.postgresql.org; Wed, 15 Mar 2023 03:58:45 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcIHf-0004fk-L6 for pgsql-hackers@postgresql.org; Wed, 15 Mar 2023 03:58:43 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 7849F3200B62; Tue, 14 Mar 2023 23:58:35 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 14 Mar 2023 23:58:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1678852715; x=1678939115; bh=7a N/PTpNZuEpUljWHaiQj4tMby7lOBc3nKLzK1/laqs=; b=i9A19w1S21QA/jYf1O rIrH57PVMKq1oUZnkB3vv/ATAINd+O0fHBrT6eu5+tSRZ2STmk0iX3ildzo829Fv LscOGW+eKTO0mmEEgk1ngYog9DjgySTVIdPECQqHtY9+8fnbGEqw4oSpAZ/PzpF2 HYCcFBGL1dV14bd9fs4Y2c++o7s+eHfRS6rId/fmHveYkCF7xyZZ+WHP+H1cTIhH CjBmpw9FSkf/u1iIf/Mz+E7sLymfKD+T6lqc9Ht4wzYARFOT0q6KvRJcCoyM6xk9 h6C2bSIpjL6OMkYokffE9IwoJ9Eu+IwwFCFUYykaY2itBWcK7E3K0oA8ZU9Wxzhk EBaw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1678852715; x=1678939115; bh=7aN/PTpNZuEpU ljWHaiQj4tMby7lOBc3nKLzK1/laqs=; b=BvuiiBu2D/9/p3n+KRlF3T3IdQ/D5 JwoBfjwp/pr9RY5Bz2kToEgejux8syOxuNAlrTWrCsTdX4ARYBdRiO1eRXPa23NZ 5WIJ7gli6q+f95E1ESIyV99J97ncqfpASpOXU3U/fvzOFY/JqdGjfJ0NJH7+rBuY 20Nb6WLAeRFRiDqg8CbgKTX79DXSGqhnO3qh1MBW+LG56aZrO+BnhCKcyOe/Hs2z hRyqj2lW32duXBx0oRKmmim8xo1Wr+BZBSNhWOp4P5gQfUPm1q/Yq3oFAok5sqzf uCkBisHqTe+8TxX8A0yMdH9fPcHiKYxU+r7IvNuo5W8R+prSSquvXaeoA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddvjedgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddunecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepgfehhefgudefudfgfeelgeei ffegfefhkeefffdvheefuddtheetgeelteevkeetnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 14 Mar 2023 23:58:33 -0400 (EDT) Date: Wed, 15 Mar 2023 12:58:28 +0900 From: Michael Paquier To: Juan =?iso-8859-1?Q?Jos=E9_Santamar=EDa?= Flecha Cc: Daniel Watzinger , Daniel Gustafsson , pgsql-hackers@postgresql.org Subject: Re: pg_dump/pg_restore: Fix stdin/stdout handling of custom format on Win32 Message-ID: References: <0F43E234-48F2-4C99-BCBE-6C41F053C666@yesql.se> <20221216235524.8483-1-daniel.watzinger@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="OFQ6yEIEBjQHSdb0" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --OFQ6yEIEBjQHSdb0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 14, 2023 at 01:47:09PM +0100, Juan Jos=E9 Santamar=EDa Flecha w= rote: > I have just posted a patch to enforce the detection of unseekable streams > in the fseek() calls [1], please feel free to review it. Thanks. I have been able to get around 0001 to fix _pgfstat64() and applied it down to v14 where this code has been introduced. Now to the part about fseek() and ftello().. -- Michael --OFQ6yEIEBjQHSdb0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmQRQmQACgkQnvQgOdby QH3d6A//bicE1Xzkb+Ve4W1xEQfnt+dj52+eIxaXmIVgsX1axdoRNOPAOX5zeOpW F62Abm3Bzdmt+jh4Hog8ehyX8f04NF3CuIPIk2rZ7yqSM3c9ux+xHJPm0PPLomHF 4RN74REOflUA6XoGjziK+mv8HhNanGwUrkbSpvupUUQSVTa2/K7OLYKmWpF9nSin JOscwg4gVBsqd9r0E5DIdBj1AdizCYW9LV07N4ccpkj+LGJZ/ZTKQe3SBcWiibst 3UCzYByINgoQ7LyDceoDVlqwGURGG6UvP1yjjuh9AzLquddUX8nP0pDBDdqBDuIm AzLve4usiJbWIrkiiYEOnrRZ6tRSxju2PfXuL/gxst0pOVN9KOtVaqTcB4qBuHFl 3H1LuYrj5efKnOXr5gW1KD2bxX22eyzaqprSedadSsUxxa57ZAc5QpKZLeyBa29j BVkQ1hkHPIsLye1Y4WtzKIUZNf2ZmXt7oy4OYrEF/obCKaAhrqRP/Jz8gi25gy8K gQxmrbSnQxvGmqmdDQ6aO//WNysNmAawzf/Vwe+RIBNlrBB7/0+B1ilESymc+U5w FF9/DkNQlnIFJSEA2fp6Bk74XCjshVCEFMwc8ZY6m2SUeomFYA7qdK/wQZKM0SkE ko+/4wkd04ZB55Pk1MwerXlpbl2sFn9fLc1xclTgjfwHn5WTA1E= =Xu0P -----END PGP SIGNATURE----- --OFQ6yEIEBjQHSdb0--