Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 15 Mar 2023 13:57:28 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Juan =?iso-8859-1?Q?Jos=E9_Santamar=EDa?= Flecha <juanjo.santamaria@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Fix fseek() detection of unseekable files on WIN32
Message-ID: <ZBFQOCHQqKY6X69b@paquier.xyz>
References: <CAC+AXB26a4EmxM2suXxPpJaGrqAdxracd7hskLg-zxtPB50h7A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="fUSNfDmcg3JlTT4H"
Content-Disposition: inline
In-Reply-To: <CAC+AXB26a4EmxM2suXxPpJaGrqAdxracd7hskLg-zxtPB50h7A@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZBFQOCHQqKY6X69b%40paquier.xyz>
Precedence: bulk


--fUSNfDmcg3JlTT4H
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 14, 2023 at 01:26:27PM +0100, Juan Jos=E9 Santamar=EDa Flecha w=
rote:
> As highlighted in [1] fseek() might fail to error even when accessing
> unseekable streams.
>=20
> PFA a patch that checks the file type before the actual fseek(), so only
> supported calls are made.

+ * streams, so harden that funcion with our version.
s/funcion/function/.

+extern int     pgfseek64(FILE *stream, pgoff_t offset, int origin);
+extern pgoff_t pgftell64(FILE *stream);
+#define fseeko(stream, offset, origin) pgfseek64(stream, offset, origin)
+#define ftello(stream) pgftell64(stream)

What about naming the internal wrappers _pgfseeko64() and
_pgftello64(), located in a new file named win32fseek.c?  It may be
possible that we would need a similar treatment for fseek(), in the
future, though I don't see an issue why this would be needed now.

+   if (GetFileType((HANDLE) _get_osfhandle(_fileno(stream))) !=3D FILE_TYP=
E_DISK)
+   {
+       errno =3D ESPIPE;
+       return -1;
+   }
Shouldn't there be cases where we should return EINVAL for some of the
other types, like FILE_TYPE_REMOTE or FILE_TYPE_UNKNOWN?  We should
return ESPIPE only for FILE_TYPE_PIPE and FILE_TYPE_CHAR, then?
--
Michael

--fUSNfDmcg3JlTT4H
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmQRUDgACgkQnvQgOdby
QH11BhAAhHK9CrqQOp430YBWFzmZ9+S7rV3kq1RIH4B7Ihr3/bl4LAvme8ulnbmg
gAvtJIePG6E67RICc3jHc0Garjy9uEN/y7rmXGoz9Sf2d4YHnqQK00K2LRq6qJ+y
ocmBRgNKJmwRidXeDUdUml+82ozIBoo4B8fGforRNvQUC4yYo0N+V5fW4AT8Jhdf
N5DN1iG1KnFfeOHiHE+hqiuW8HDkMmy3CZuBt2Cwg/DBsvPEIyeKzhJQ70U8ljXm
z19CxUVYKfnuVEEnof4+jrlpliueryUR3gWVzm7QBwK5/1olsQ3bn7HrK3+l55hH
rNOw1N7xO5tj66c7ed76K376yOgeytPGqvFRRUsrgpy9VRbCPjlaqOpzd7s+gptL
J4Qpy0JIUoCNfCGB0GjpmSTs4ymlsi0MG+/cPkU2fVhvWM5vAlKI4KKXGZhtw8Vo
dtAIVL6qGZO+SyeArcERxUB2wD9h6E8qEpOZJsqsN7V5laL6CEN2/FeWXhnoxOFn
qQ1s7DivyLBQu/+qyMydU54w/Wrr+1OGCh9k32ruVs4us6H3vUOLfXPsAccGegPU
7bCvL/54cIDz4zBQgEFhTXruHFFQ17N1PJOErfv3gW7sb60Rnv4JiI182TH8honQ
LQN2JDcp6b+b/g+lE6LHiKhaAQBdf+/hSmR+dQAIpkgaeTCsNp4=
=LOuR
-----END PGP SIGNATURE-----

--fUSNfDmcg3JlTT4H--