public inbox for [email protected]  

help / color / mirror / Atom feed

From: Justin Pryzby <[email protected]>
To: Peter Geoghegan <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Greg Stark <[email protected]>
Cc: Gregory Stark (as CFM) <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: [email protected]
Subject: Re: Commitfest 2023-03 starting tomorrow!
Date: Sat, 18 Mar 2023 18:19:47 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAH2-WzkXvRX6t2b0bxm2aDV14Qxi7Sp+TpPZNTZ48zRA7cVmFw@mail.gmail.com>
References: <CAM-w4HNiKPLV5nq05ZRyvoWAPNhbpudcEMd8ThSv=Ajpnj+njg@mail.gmail.com>
	<[email protected]>
	<CAH2-WzkXvRX6t2b0bxm2aDV14Qxi7Sp+TpPZNTZ48zRA7cVmFw@mail.gmail.com>

On Sat, Mar 18, 2023 at 02:43:38PM -0700, Peter Geoghegan wrote:
> On Sat, Mar 18, 2023 at 1:26 PM Alvaro Herrera <[email protected]> wrote:
> > At this point, I'm going to suggest that reviewers should be open to the
> > idea of applying a submitted patch to some older Git commit in order to
> > review it.  If we have given feedback, then it's OK to put a patch as
> > "waiting on author" and eventually boot it; but if we have not given
> > feedback, and there is no reason to think that the merge conflicts some
> > how make the patch fundamentally obsolete, then we should *not* set it
> > Waiting on Author.  After all, it is quite easy to "git checkout" a
> > slightly older tree to get the patch to apply cleanly and review it
> > there.
> 
> It seems plausible that improved tooling that makes it quick and easy
> to test a given patch locally could improve things for everybody.
> 
> It's possible to do a git checkout to a slightly older tree today, of
> course. But in practice it's harder than it really should be. It would
> be very nice if there was an easy way to fetch from a git remote, and
> then check out a branch with a given patch applied on top of the "last
> known good git tip" commit. The tricky part would be systematically
> tracking which precise master branch commit is the last known "good
> commit" for a given CF entry. That seems doable to me.

It's not only doable, but already possible.

https://www.postgresql.org/message-id/CA%2BhUKGLW2PnHxabF3JZGoPfcKFYRCtx%2Bhu5a5yw%3DKWy57yW5cg%40ma...

The only issue with this is that cfbot has squished all the commits into
one, and lost the original commit messages (if any).  I submitted
patches to address that but still waiting for feedback.

https://www.postgresql.org/message-id/[email protected]

-- 
Justin

view thread (36+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Commitfest 2023-03 starting tomorrow!
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox