Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 21 Mar 2023 10:04:46 +0900
From: Michael Paquier <michael@paquier.xyz>
To: "Imseih (AWS), Sami" <simseih@amazon.com>
Cc: David Zhang <david.zhang@highgo.ca>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: [BUG] pg_stat_statements and extended query protocol
Message-ID: <ZBkCrq05xzlZKkAz@paquier.xyz>
References: <EBE6C507-9EB6-4142-9E4D-38B1673363A7@amazon.com>
 <ZABP6zdfymC0QKDX@paquier.xyz>
 <9B9BB0F2-68A3-44E0-946E-3D9051F83369@amazon.com>
 <3499c5ed-5511-0801-ccfe-297b098aa8fe@highgo.ca>
 <E35AF94E-E050-471D-8A0C-4845811D9C74@amazon.com>
 <ZA0/oM2k2UUOpkLw@paquier.xyz>
 <a9a26eb0-f8c3-0fbd-b7aa-f789da39d189@highgo.ca>
 <EC5F1919-6777-44D2-BB32-87DA503EF614@amazon.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="uNkKduFFziBYAoTn"
Content-Disposition: inline
In-Reply-To: <EC5F1919-6777-44D2-BB32-87DA503EF614@amazon.com>
Archived-At: <https://www.postgresql.org/message-id/ZBkCrq05xzlZKkAz%40paquier.xyz>
Precedence: bulk


--uNkKduFFziBYAoTn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 20, 2023 at 09:41:12PM +0000, Imseih (AWS), Sami wrote:
> I was thinking about this and it seems to me we can avoid
> adding new fields to Estate. I think a better place to track
> rows and calls is in the Instrumentation struct.
>=20
> If this is more palatable, I can prepare the patch.

This indeed feels a bit more natural seen from here, after looking at
the code paths using an Instrumentation in the executor and explain,
for example.  At least, this stresses me much less than adding 16
bytes to EState for something restricted to the extended protocol when
it comes to monitoring capabilities.
--
Michael

--uNkKduFFziBYAoTn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmQZAq4ACgkQnvQgOdby
QH1r/BAAhUw9HBy8WDIDOPT+RX7HdNq5yfY+XC8f4soczPAq5EpJ4LP1zqv7y4Lj
84U6R5ZHs0jUApYUIchcj+9uKu89p4JQl9vy5MPLsHR3o31fwBueK7Bahf1pf8j9
6UST5dPyokHNypFaHF109Ar3idRQ9RqMUez0ik6nZZaaGKsRhSdHQSQOQRZ4Dxkk
/R9zTFpjADIFmUc3Tc+bhwPTXdv5XTnzVnI4de/hsmxEnpn4+tz3C3NkzMkOjbp7
q+BvJFFDX4qIR8/xVSEQr6sZujFooOgBfoMPPjQRrROr5LAE0LfNmug4sokjaU0e
h39U3oUXn7wik3Ml50zTVm0XrR8hP6jgJue4cCZCNnZwiccKAMa57kc2IoJdxQ00
rkypQd4JK1xK3+ljl/72BgRUrVGq2ndhvYUKS2zlblVafA8jjE56CpjWNa8af7Xl
CEEUr07inoIrdwBOZKhxTD0L71iEJdVeltM56SmXK5oAdAEo1jgm7yHRUhU9BgKH
KQ+oRfaLq7GgnaDVtKcy2uREfXjqCY1clTfM87shMn/H2X0Va57dn+1uEiAM7Z6C
JycOLOqf3bq1vKJ2Wk2wjEQ8+63izm/GEM/RLiQ8hitG09slTLrlFrBxr7LrfLlW
UzqKsLSHkbDEftk/ZG2zMxD5FELeI9kI2U0v8OWhKHAOaanfxy8=
=8kdR
-----END PGP SIGNATURE-----

--uNkKduFFziBYAoTn--