Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1penHC-0007FU-IO for pgsql-hackers@arkaria.postgresql.org; Wed, 22 Mar 2023 01:28:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1penHA-0006D4-Pu for pgsql-hackers@arkaria.postgresql.org; Wed, 22 Mar 2023 01:28:28 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1penHA-0006CC-GS for pgsql-hackers@lists.postgresql.org; Wed, 22 Mar 2023 01:28:28 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1penH7-0005mE-KX for pgsql-hackers@lists.postgresql.org; Wed, 22 Mar 2023 01:28:28 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id A28C85C00AF; Tue, 21 Mar 2023 21:28:24 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 21 Mar 2023 21:28:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1679448504; x=1679534904; bh=BW 4LA/DjZ/zul+6eJgeoeM5dgQI7rm2NfiwFIRL95Bk=; b=j/snPUYZ+lCS1EsPkc d/+2a/ZEOc7x+92fXU7lHsYPCsnUyKz+Dvf+uNKGQWehhWOhomvd1Xj9FBSgOHc+ hrrxXVNaa8zhLkY6Zd+2Ul0nd/K1tvW3qN/9Szzh8/E51Cge+LI9iAuLwEIFQ/XP 2hTKUDcD5hc81SpxzeHU+FHxM6BS9lB1CkmgB171uS1LUyXWgKaIQT1vuQVhG6Q8 MloZc0LZ9Cj0umuWMOUu1GeLJAWnVL9t599D9bPCFUqKsatpO5OWdYZE/1t3amiA gahA2cDsCQvUXaHYmFpeX+6sz1p65BWfT4NY9gtTY6eT1lherJl+37SVTYAepnoN refA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1679448504; x=1679534904; bh=BW4LA/DjZ/zul +6eJgeoeM5dgQI7rm2NfiwFIRL95Bk=; b=Q/oYO3ATevGMBtSiMXf2h8UdAhe9L F70Ttnk0RKZ0CBrxFF8nAbCTrP4FIaV6NkKt4QVofMZDjYrIcKBeappwqxt82FGs PX9KLB1tk1tieVlFkwh9zjnLZE6OEGDnEFZubBBuXTUixHtafIW93zmYFAntDqsl Tv/IITU+fmta255oRVIkVRKcEilUNLmjQUCfS28FjFXRzwVzRJr3ya9drVQqho9O DwkDiCjeBkzzgSEs6nL1aXjjvWyaKJY66QIrJIRMZoDpSepighkP7Lb4T245XDpR fJz/peyZnDAIIDv/jYMbUcwdSE2elRXmENeuSzm7BrBToYhaZjvjmI0kw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeguddgfeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdlfeehmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepgeffjeevgfevuddvjedtvddt ieejheduueelvddufedtgfefjedvkeevkeeivddvnecuffhomhgrihhnpehpohhsthhgrh gvshhqlhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhl fhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 21 Mar 2023 21:28:22 -0400 (EDT) Date: Wed, 22 Mar 2023 10:28:19 +0900 From: Michael Paquier To: "Drouvot, Bertrand" Cc: Andres Freund , Alvaro Herrera , PostgreSQL Hackers Subject: Re: Remove nonmeaningful prefixes in PgStat_* fields Message-ID: References: <9142f62a-a422-145c-bde0-b5bc498a4ada@gmail.com> <20230112171252.xucefmthy5l4l2ec@alvherre.pgsql> <20230112180733.agmvpugp6ggorade@awork3.anarazel.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="IeymB0K5XOQY7BcC" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --IeymB0K5XOQY7BcC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 20, 2023 at 10:05:21AM +0100, Drouvot, Bertrand wrote: > Good point and keeping it as it is currently would not > affect the work that is/will be done in [1]. I guess that I'm OK with that to get more of pgstatfuncs.c to use macros for the function definitions there.. Alvaro, Tom, perhaps you still think that this is unadapted? Based on the file split and the references to funcentry and tabentry, I think that's OK, but that stands just as one opinion among many.. > So, please find attached V2 attached taking this comment into account.=20 > [1]: https://www.postgresql.org/message-id/flat/89606d96-cd94-af74-18f3-c= 7ab2b684ba2%40gmail.com Nice. I am pretty sure that finishing some of that is doable by the end of this CF to reduce the size of pgstatfuncs.c overall. -- Michael --IeymB0K5XOQY7BcC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmQaWbMACgkQnvQgOdby QH3iPA//doTHFtWaRHUDG1TDOTvde+cDISO3WHgcZIvpJ/zYDoI4UYObZU2fWoiz OOKeGdYc/K75bMJM4oYnV7KnsuylCbtQ0AnoCIyUib9CGmaqYKr33bl2IuxXK5AQ o98+8SPLiIOhaTLa0WdaLqk0CuHsxURl+zI5vvZ61t9G59AOi0vHFvOCXqPqK+hD +W/dhMYkow4UwSPbbv6dlA7zB6B2LLExxarJDWFksEE9ur//v7wwgBOpJcmTNdfs 4K56JrMWxGp0A7/s/JV4ECNXg2EaxIKqWWGKb0rU6wGcIBotiLS6TXE2je6RokVy CNh29dm7ugVukCKZc/6Wk9tQnRGeZEQ8ldHyK6EHrmjPEDhMAILRAKyiAuv7DQ3u 8uXbuqHwswn4dcZl3APzgO14XvvHo18KzlB4f1I18ESq4y35EHMZqwYdgVSG68IC KDVkJySYSt4lLFbT3k4dFdcfBXS0yOgTIrm0NTcq/1S1KVyqV07+8DQNEhnNBPCd os1UWOY3KdYdN/wMq6BqFi/82eNVaIZUn9mcb2Vgs8SK6uOps0xxTdfBd7gzAa2B BLVCrVtjC94T/cHSU9CZzni6nyZkz5IPlh01kQGt4s8RF7CTC3wScfEnBfLeBN8i kKOsNfQ01GlBGyuenF2MS/iTxpUdmuCt6J/gRwjy5QHJ6o2q1OE= =p5NZ -----END PGP SIGNATURE----- --IeymB0K5XOQY7BcC--