Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 23 Mar 2023 18:21:21 +0900
From: Michael Paquier <michael@paquier.xyz>
To: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
Cc: "Imseih (AWS), Sami" <simseih@amazon.com>,
	David Zhang <david.zhang@highgo.ca>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: [BUG] pg_stat_statements and extended query protocol
Message-ID: <ZBwaEbdpVYJPXjT5@paquier.xyz>
References: <3499c5ed-5511-0801-ccfe-297b098aa8fe@highgo.ca>
 <E35AF94E-E050-471D-8A0C-4845811D9C74@amazon.com>
 <ZA0/oM2k2UUOpkLw@paquier.xyz>
 <a9a26eb0-f8c3-0fbd-b7aa-f789da39d189@highgo.ca>
 <EC5F1919-6777-44D2-BB32-87DA503EF614@amazon.com>
 <ZBkCrq05xzlZKkAz@paquier.xyz>
 <3227719C-F7A3-4A94-B0A5-D27673316560@amazon.com>
 <0d583e2a-8214-4975-a4b4-7e9e0b8f8e9c@gmail.com>
 <DF311964-77CB-4027-B00A-0AD7A3DB61D5@amazon.com>
 <472cfda7-1e4f-ed47-0860-78cf685b53b0@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="rNeLz5p83aAgX8tm"
Content-Disposition: inline
In-Reply-To: <472cfda7-1e4f-ed47-0860-78cf685b53b0@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZBwaEbdpVYJPXjT5%40paquier.xyz>
Precedence: bulk


--rNeLz5p83aAgX8tm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 23, 2023 at 09:33:16AM +0100, Drouvot, Bertrand wrote:
> Thanks! LGTM and also do confirm that, with the patch, the JDBC test
> does show the correct results.

How does JDBC test that?  Does it have a dependency on
pg_stat_statements?
>=20
> That said, not having a test (for the reasons you explained
> up-thread) associated with the patch worry me a bit.

Same impression here.

> But, I'm tempted to say that adding new tests could be addressed
> separately though (as this patch looks pretty straightforward).

Even small patches can have gotchas.  I think that this should have
tests in-core rather than just depend on JDBC and hope for the best.
Even if \bind does not allow that, we could use an approach similar to
libpq_pipeline, for example, depending on pg_stat_statements for the
validation with a test module in src/test/modules/?
--
Michael

--rNeLz5p83aAgX8tm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmQcGhEACgkQnvQgOdby
QH20QA//WbrISDm/b7uwufv/2z+v70NlnYfQM3DEkId4LajyMddU+Mahs5NkteD9
33zWu0+JGp1PTMC/wQvIlMyz3odoRHxqGmurJgdesmo36zefyt3pOYTF9hTHSOHO
MtDO7RJ4O2/ZZNgaREPf9R1RqyO6cAlvynfOreHxb1zHgMKpGwijfaRUAeY5VCYz
UakWHktaZoXA6dVSgu8y7j4bR5c5IGt6sveGcbgquQ9xOFWiZtRZp3lO9kkidtvX
qFVO20h0NesLMxxq0S0tPMfWAc77rldfe/j9JbUuRTkpleTtKKFfeb5REIL6HTUi
TKBgaXAjbFN5P1JSGb4quHE3c+aQ/o3rRk2aRNPxdHAaX1a/yY4rorjg7clcBFIH
P7/DVB43GLrG4QsaoOAE7dcZhBcf9ijPVlQsAGfvjnJkQPCznUdNvBi0I52OpXRA
xbpIofYPhhDgQ9YB++KB/dJMlqVjjNjrKDtNRKQ7VFNcHIXnizUCHicfWBGUzkP0
KSlw5IafVGHke5HXwLBrhwj5n5KOHaeUNqSRXdgfT3HilfG3OpNPBwZ2cFr5mh5e
zi6msNTGzT1cl1UW3LDuomlv2VHO373nQrzQg2IF7/x5+vRGSHVXzfdA6jTVUyN9
KqBo3Q3eD5HIV/sLX2LhKtepNa7LtlUxgGb7i9ujdwRWCzZd6IY=
=H4Qh
-----END PGP SIGNATURE-----

--rNeLz5p83aAgX8tm--