Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 24 Mar 2023 09:04:31 +0900
From: Michael Paquier <michael@paquier.xyz>
To: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
Cc: "Gregory Stark (as CFM)" <stark.cfm@gmail.com>,
	Andres Freund <andres@anarazel.de>,
	Michael Paquier <michael.paquier@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Generate pg_stat_get_xact*() functions with Macros
Message-ID: <ZBzpDwOMf1ia+M9l@paquier.xyz>
References: <89606d96-cd94-af74-18f3-c7ab2b684ba2@gmail.com>
 <20230111225907.6el6c5j3hukizqxc@awork3.anarazel.de>
 <e6191040-40c4-6849-7b5d-bf3c227f1755@gmail.com>
 <20230112182434.ejffbun4plv2g37k@awork3.anarazel.de>
 <83f7982d-272a-b064-8a0f-8853354edf10@gmail.com>
 <20230113183746.zyncqr2zz3gk6yh6@awork3.anarazel.de>
 <CAM-w4HNq0SmbDa1jCtbmtCzWrx6G7qAGxsjzcOdEyceGOAdJmA@mail.gmail.com>
 <11744b0e-5f7f-aba8-7d9c-2ff0a0c6e2b2@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="OWaLYUqv3qiSPFMH"
Content-Disposition: inline
In-Reply-To: <11744b0e-5f7f-aba8-7d9c-2ff0a0c6e2b2@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZBzpDwOMf1ia%2BM9l%40paquier.xyz>
Precedence: bulk


--OWaLYUqv3qiSPFMH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 02, 2023 at 08:39:14AM +0100, Drouvot, Bertrand wrote:
> Yeah, there is some dependencies around this one.
>=20
> [1]: depends on it
> Current one depends of [2], [3] and [4]
>=20
> Waiting on Author is then the right state, thanks for having moved it to =
that state.
>=20
> [1]: https://www.postgresql.org/message-id/flat/f572abe7-a1bb-e13b-48c7-2=
ca150546822@gmail.com
> [2]: https://www.postgresql.org/message-id/flat/b9e1f543-ee93-8168-d530-d=
961708ad9d3@gmail.com
> [3]: https://www.postgresql.org/message-id/flat/11d531fe-52fc-c6ea-7e8e-6=
2f1b6ec626e@gmail.com
> [4]: https://www.postgresql.org/message-id/flat/9142f62a-a422-145c-bde0-b=
5bc498a4ada@gmail.com

[3] and [4] have been applied.  [2] is more sensitive than it looks,
and [1] for the split of index and table stats can feed on the one of
this thread.

Roma wasn't built in one day, and from what I can see you can still do
some progress with the refactoring of pgstatfuncs.c with what's
already on HEAD.  So how about handling doing that first as much as we
can based on the state of HEAD?  That looks like 50~60% (?) of the
original goal to switch pgstatfuncs.c to use more macros to generate
the definition of all these SQL functions.
--
Michael

--OWaLYUqv3qiSPFMH
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmQc6Q8ACgkQnvQgOdby
QH38GQ//e6jfBU7oXgWSHdpShSt7AA4bXe2ds9nw4QSci3boV2WmjN2cjprlltqX
jQZOwhjJibzDgypYC5C/Yvk/K0KISIo7AtP04w+NfDIMg581iHwcvggFHBQM4stw
Q0y4pTT528RvNY5BjD7YxLfCnODVtCPzAYstX+ma/hlZqSQTckJ5hL0C7P9BiXSf
cIzKTGmHvTRf42CioDbPj6TQs4pyVe1Wf5NHmnqAW5mCGR1SZ9HWDyAr0SiBjqoY
W/zZOyV9uflgOvSQn90M49ZQE3WKQYTEy2zWUbPCqjR0FP8pLj6l20fWcTLbwRwY
m/7+VBCEoIuS7HnO90ONCOcF8ar9xeCPIz7q/UXbcg4eWeRrAlCOjwind82WMMYX
mIF8zZEV2eA05f16sPhmas3DueuIpYkXwawQB3Al8mJNSTLFaJwxgUhMHKSt4ddd
JxXoRZstF57/JSq/EV0zz1Am3D6sBnQhmvrQEcyx8KUeUXeJ04ksyDInb/j+qGyG
Jdqqx7sqc/7BcqLHZEQhVhvKDBAhZ1CudEuRGTsYrViuq2n88cLJod0nnZzZQVRk
iRl/xBZBDH1Ov6dIX+4tq3Mwd8Eye78YBl9mro+na2fey9E/rHXED88kOwB93EdX
se9AVJmzWoiN/Hhe9rIfQI9AjIZ3Y2SujruqqcnqCNFxnP0Vrp0=
=mJud
-----END PGP SIGNATURE-----

--OWaLYUqv3qiSPFMH--