Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 5 Apr 2023 17:10:32 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Robert Haas <robertmhaas@gmail.com>,
	Justin Pryzby <pryzby@telsasoft.com>,
	Mikhail Gribkov <youzhick@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: GUC for temporarily disabling event triggers
Message-ID: <ZC0s+BRMqRupDInQ@paquier.xyz>
References: <9140106E-F9BF-4D85-8FC8-F2D3C094A6D9@yesql.se>
 <CALte62x7c9R0ohKcQSr5N9PFB-D6pCb_THhwWzTscR7ZB6OHvg@mail.gmail.com>
 <167482801126.1114.1095311628314619931.pgcf@coridan.postgresql.org>
 <8D26ACC2-7669-460D-833A-582EAD6CC09E@yesql.se>
 <ZCncJGbFLex2f9GP@telsasoft.com>
 <E241BCDE-A8BA-483A-B368-F758CB8E0602@yesql.se>
 <CA+Tgmoa7ODAMvJn8sncmMzxkHL=hKmqXa3TLqh-SCLmiB64qzQ@mail.gmail.com>
 <54E8A181-D611-4581-9CC4-62188D1379C4@yesql.se>
 <CA+TgmoZDjc04aPD0LM4LKZ_GstggvAzxmmhWdeX0iHrnC1V2Yg@mail.gmail.com>
 <AEFDB346-50F7-45BB-AE0C-3DCA931ACA8C@yesql.se>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="+K+4B5P1RAEUswQi"
Content-Disposition: inline
In-Reply-To: <AEFDB346-50F7-45BB-AE0C-3DCA931ACA8C@yesql.se>
Archived-At: <https://www.postgresql.org/message-id/ZC0s%2BBRMqRupDInQ%40paquier.xyz>
Precedence: bulk


--+K+4B5P1RAEUswQi
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Apr 03, 2023 at 11:35:14PM +0200, Daniel Gustafsson wrote:
> Yeah.  The patch as it stands allow for disabling specific types rather than
> all-or-nothing, which is why the name was "ignore".

FWIW, I agree with Robert's points here:
- disable_event_triggers or ignore_event_triggers = off leads to a
double-negative meaning, which is a positive.  Depending on one's
native language that can be confusing.
- Being able to write a list of event triggers working would be much
more interesting than just individual elements.
- There may be an argument for negated patterns?  Say,
a "!sql_drop,!ddl_command_start" would cause sql_drop and
ddl_command_start to be disabled with all the others enabled, and one
should not ne able to mix negated and non-negated patterns.

A few days before the end of the commit fest, perhaps you'd better
head towards having only an event_trigger = on | off or all | none and
consider expanding that later on?  From what I get at the top of the
thread, this would satisfy the main use case you seemed to worry
about to begin with.
--
Michael

--+K+4B5P1RAEUswQi
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmQtLPgACgkQnvQgOdby
QH0yxg//al8jgsPqPABtDkRF5M4YWAt+wFcn6K/MHBHooSSLSuovJLiF57ysqOGx
jjqOndHg6ue0HtApYbYowZ9UDx77+nS7qeWnEmxQgkM5bmu4OgEx9nsT2M0UxzuW
nheuCcRIRhFb0gUWhiEB6Zv0ZIZFcz7HQ/68KMzI4LyR/a/WfJK0GyySEp6xI4qV
H/E31yfVgKqJ7fTzIy3EHDblyF1at9opfAH4ZBg7gjHLjx9My8FF8Qyri2Sb7ajl
jKx5dqXBtUCs/ulDhJ7hJSTH4JJcM3kN9G5OXQcRQqOopNzg5GnC1u/q7Smz1hTU
LtRcuF6dGIvKm9X3LDjgKJBN+ifkGJ/nIvmlciNmfWQxsAXRcbi6ZqdBmqCQxW0y
hyiQyv8hTwTkeNtOdus8qLyy792V8QtDtCb7G1aSGovvCQABwsn6nuc76b09K9g5
our0r87ouXUJK0bAA/rDz88oBxAYuy2Ib817sOugC1VDioqqQzYNgXSWDC6h0U8H
E6CJHbBtJTy51OHj9ySStUjsA1kJCef7FWkrzEriZFQFokSwqdm2+wOpc0PR+JE5
Y/gWjbrlTq8OF8qyFCPbdfMed2KHpmuVDDV03PVYOBak65k+K2NHiCPYBp+8DHgd
LrStuy/yHkVJ4b8OtdPWX4K2xz6kwH7UM6Poy7LfPAelk+Aagb0=
=K3id
-----END PGP SIGNATURE-----

--+K+4B5P1RAEUswQi--