Date: Thu, 6 Apr 2023 11:10:17 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Jacob Champion <jchampion@timescale.com>, pgsql-hackers@postgresql.org,
	gkokolatos@pm.me, Michael Paquier <michael@paquier.xyz>,
	Robert Haas <robertmhaas@gmail.com>, Peter Geoghegan <pg@bowt.ie>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	Heikki Linnakangas <hlinnaka@iki.fi>,
	Thomas Munro <thomas.munro@gmail.com>,
	Dipesh Pandit <dipesh.pandit@gmail.com>,
	Andrey Borodin <x4mmm@yandex-team.ru>,
	Mark Dilger <mark.dilger@enterprisedb.com>
Subject: Re: zstd compression for pg_dump
Message-ID: <ZC7u6at4J3XXrH2z@telsasoft.com>
References: <4029fe58-f661-7d8d-cbbb-b936a05531e2@enterprisedb.com>
 <ZCd6sb7XA/W6nLaD@telsasoft.com>
 <2de3bcad-6da9-9022-bce5-fc0416351d6e@enterprisedb.com>
 <ZCgzbBVKLvwpqMzT@telsasoft.com>
 <f3947107-a95a-348c-263c-284ac7275ae0@enterprisedb.com>
 <ZCsmSoiBMVfrlOXm@telsasoft.com>
 <27eb89fc-8fdd-2988-0959-0af1d6d7a12a@enterprisedb.com>
 <ZCuTotQ38nwA/hLY@telsasoft.com>
 <51013008-6735-96a2-d744-3b0a0413fcdd@enterprisedb.com>
 <d62901d9-e945-049f-5b0e-7f645d83a1b9@enterprisedb.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d62901d9-e945-049f-5b0e-7f645d83a1b9@enterprisedb.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ZC7u6at4J3XXrH2z%40telsasoft.com>
Precedence: bulk

On Thu, Apr 06, 2023 at 05:34:30PM +0200, Tomas Vondra wrote:
> I looked at the long mode patch again, updated the commit message and
> pushed it. I was wondering if long_mode should really be bool -
> logically it is, but ZSTD_CCtx_setParameter() expects int. But I think
> that's fine.

Thanks!

> I think that's all for PG16 in this patch series.  If there's more we want to
> do, it'll have to wait for PG17 - 

Yes

> Justin, can you update and submit the patches that you think are relevant for
> the next CF?

Yeah.

It sounds like a shiny new feature, but it's not totally clear if it's safe
here or even how useful it is.  (It might be like my patch for
wal_compression=zstd:level, and Michael's for toast_compression=zstd, neither
of which saw any support).

Last year's basebackup thread had some interesting comments about safety of
threads, although pg_dump's considerations may be different.

The patch itself is trivial, so it'd be fine to wait until PG16 is released to
get some experience.  If someone else wanted to do that, it'd be fine with me.

-- 
Justin