Date: Sun, 26 Mar 2023 09:08:41 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Ilya Gladyshev <ilya.v.gladyshev@gmail.com>,
	Matthias van de Meent <boekewurm+postgres@gmail.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Tomas Vondra <tomas.vondra@enterprisedb.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Progress report of CREATE INDEX for nested partitioned tables
Message-ID: <ZCBR6QfrsW2Vl1l6@telsasoft.com>
References: <34FE3024-5025-46B7-B435-8DDD59072705@gmail.com>
 <ZBJdxTagTuOZkgov@telsasoft.com>
 <266AAEDA-786B-4DDB-B115-AE8EF0E5F283@gmail.com>
 <ZBn635Gc3vfhV06i@telsasoft.com>
 <2003807.1679603746@sss.pgh.pa.us>
 <ZB5iH14191E0LbBb@telsasoft.com>
 <2586913.1679759713@sss.pgh.pa.us>
 <ZB8i+E0dBDaSaB9K@telsasoft.com>
 <2614195.1679764277@sss.pgh.pa.us>
 <2773247.1679773412@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2773247.1679773412@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/ZCBR6QfrsW2Vl1l6%40telsasoft.com>
Precedence: bulk

On Sat, Mar 25, 2023 at 03:43:32PM -0400, Tom Lane wrote:
> I pushed 0001 with some cosmetic changes (for instance, trying to
> make the style of the doc entries for partitions_total/partitions_done
> match the rest of their table).

Thanks.

> I'm not touching 0002 or 0003, because I think they're fundamentally
> a bad idea.  Progress reporting is inherently inexact, because it's

Nobody could disagree that it's inexact.  The assertions are for minimal
sanity tests and consistency.  Like if "total" is set multiple times (as
in this patch), or if a progress value goes backwards.  Anyway the
assertions exposed two other issues that would need to be fixed before
the assertions themselves could be proposed.

-- 
Justin