Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pgvXK-0001nx-GU for pgsql-hackers@arkaria.postgresql.org; Mon, 27 Mar 2023 22:41:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pgvXJ-0003Ru-8g for pgsql-hackers@arkaria.postgresql.org; Mon, 27 Mar 2023 22:41:57 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pgvXI-0003Rl-VK for pgsql-hackers@lists.postgresql.org; Mon, 27 Mar 2023 22:41:56 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pgvXH-000531-32 for pgsql-hackers@lists.postgresql.org; Mon, 27 Mar 2023 22:41:56 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 1C65E5C0154; Mon, 27 Mar 2023 18:41:54 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 27 Mar 2023 18:41:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1679956914; x=1680043314; bh=fX bmVE/jiwgJCCKlnvqdK/R0d7a3wY7Zbl0Ewty3lZw=; b=YSvjnPjsKcUMWppT6k EuJeTQP8Z1ladCwGxZjNrZq2mcMKmpn9dRQkvvmGcezyyO4xHdXz4vkcX4Og/Azl I3sooGxr7iVCwDztNGIWz9PkhtLMHPoFRZGx9Oli3XP6QLL9gQbRcoPpkWAMWHlV hejGhcXi4ueJugCEpQjcrKbc+J2QsMyFxmfMX2sNpHWHYEZ9mNgUAQsagXa253Jt +Z1wXceD2NJHU69J/2rZ2XZ8Y5Gg05RaEnmM/UNHPvuHA/eBOD/bFKzl1fOWnl3O 0kFBNLRkuz+B0pYNTUZhGkwNxmTzXbmkNK0us0B4qWFM/c19IyUhCChrO9hVLvN0 A59A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1679956914; x=1680043314; bh=fXbmVE/jiwgJC CKlnvqdK/R0d7a3wY7Zbl0Ewty3lZw=; b=M9DFukM4cfP+4I8fKhGI0QBgtIKmK +baWJYAz4Hsky/fIKV6ijeDeaUbTiqPcw4D162L3tIUVcFf1HM0Mh+ieMdXibKHH EomPy9C4VQI/B8WHIBCflglG3JwLQQxeSW1g2u/aaFMiiRaxVQPQ8SyDok4G5pMQ 35yqT2B03ZqP2wSi/J4NpZ4JXCEYtQ4q32Bcl75YOQpoK4c0sHZ43XPfn9CBnKI/ EXp68ro1tEDes2A83prXw2PLPgnwDj/4b8JJSrOmkhygogLTInIuDWvS1zcnhLgI MuzNgoeBl79ruEjgdrMeUzu/Ltt0msRkLzqhiNnOm3jOPRhVArG2ob51g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdehfedgudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 27 Mar 2023 18:41:51 -0400 (EDT) Date: Tue, 28 Mar 2023 07:41:48 +0900 From: Michael Paquier To: "Drouvot, Bertrand" Cc: "Gregory Stark (as CFM)" , Andres Freund , Michael Paquier , PostgreSQL Hackers Subject: Re: Generate pg_stat_get_xact*() functions with Macros Message-ID: References: <631e3084-c5d9-8463-7540-fcff4674caa5@gmail.com> <442ba19a-6e8a-3fe3-d404-e9101dfbfcbb@gmail.com> <6e2efb4f-6fd0-807e-f6bf-94207db8183a@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kiycDiqf/1HYUPT4" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --kiycDiqf/1HYUPT4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Mar 27, 2023 at 07:08:51PM +0900, Michael Paquier wrote: > The patch has one mistake: PG_STAT_GET_XACT_FUNCENTRY_FLOAT8_MS does > not need a slash on its last line or it would include the next, empty > line. This could lead to mistakes (no need to send a new patch just > for that). Adjusted that, and the rest was fine after a second look, so applied. It looks like we are done for now with this thread, so I have marked it as committed in the CF app. -- Michael --kiycDiqf/1HYUPT4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmQiG6wACgkQnvQgOdby QH0k8hAAgEFBFfN+V/qaqSW+TnFaQHG8hgdagsapCPlGd8OonkYVvULL3t/kXdte r9lZruk2mjw/aL/CY1KEr4POBlEIABA3Fl5H24SDN3GtNIEN/fuBFmCO4L1alR0M duwfb80Afjj3DIPIA2OZAVj8HslYsNnOHx+dB46WEPdRiu/T+O1pOwHk6WRiIG1B A2qWmjy+Jce6j6C08GFzuF7PCFoitksJ0WkT82uNls809CgwbS+KK2R6TG5/eL96 MO7bgL/+DU1tDu7ksI5kKr+pt1u1mUeBzT4846bNfADEUWbBF0iXGOr2x8AixmJA G3mvLUcs6HMJqW/t9byewy5Fzwz36Q7RMkgLmTqBj2IUj/azcVIwLV5W1TLOOJCv pEm5QreqAor2EDqHxy2uGVxPee248pohCiGhVsKAgpgOBGjzFCGG7EQ1f5Ha01ve 21J2yJ7wC2N3HY1UvWfAj7tq/xB7bwvGKc37op+Pnsu1wAoX5HRyJ/i4DpLkEjGN +jEzX2Fy5FHnSme4VgyH9GJyUqGPFNAgtkRR/Qi+kfXU4MC2DdotVDxVMoe+RwF9 lzT0gLsiHmvu/bKFumVjuv922hJfkk4S8oDkuWR/c+gAc4o6/HKkkCKOOBg+9Gk0 3btUviAyKLAhIriu5tjB6EW2UnLQDKzsbMBI8E+UOcRRMh+4Os8= =CjhZ -----END PGP SIGNATURE----- --kiycDiqf/1HYUPT4--