Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1phJOE-0007FL-6E for pgsql-hackers@arkaria.postgresql.org; Wed, 29 Mar 2023 00:10:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1phJOC-0002DJ-2w for pgsql-hackers@arkaria.postgresql.org; Wed, 29 Mar 2023 00:10:08 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1phJOA-0002D4-Ms for pgsql-hackers@lists.postgresql.org; Wed, 29 Mar 2023 00:10:07 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1phJO7-0008NN-ND for pgsql-hackers@lists.postgresql.org; Wed, 29 Mar 2023 00:10:05 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 7E68E3200915; Tue, 28 Mar 2023 20:10:00 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 28 Mar 2023 20:10:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1680048600; x=1680135000; bh=ON PvkFlGlerq9QItbQ/U+GFM/zcMaKEzGGXG6V6YCgM=; b=U+L3pAgnwuIvwAbpw3 Cad52+ZwhSRJlhdpG0HZPLQi2ziEkvzBsPhjdHWyQcIct6jBmj9Aa2E5VW6GUchV KMew5N/rZ93KBTBKw8RIGSiYr1DguojIdlqObp3Ra+GHZS4OjvuB25hoVWPOB/NQ 5WkJsw13uakYPJlxhYt5QHs9Kjpr1usDZXDBk4EV5JNf/SwFaw4HP843S4da+ka/ Q8h5LbOPssDSETzyVFXcMPpZbUYGj80ZfjPT7c+5UMxm+kDkY1DVpsPpoDFK9N0M bwAdGSOFMXG4vQPxU8mJRZ3yTfHFOVAW/5csADFroWaHrocFrsaYHjeIq0zo7ILt 7RZA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1680048600; x=1680135000; bh=ONPvkFlGlerq9 QItbQ/U+GFM/zcMaKEzGGXG6V6YCgM=; b=FgojM/HGgjhh9cKh9tgUIi8xNWmni JmPCaPFO3Rvi0W7xa1SwF88Ubjy8TlQlOQJRn7GnXHcbGo+jlpwZXmHQAGJrO+KB WSJpb0B92cd8PK7gFXB9u7V1JmrHnt8v3TDSvqX6/VVFGjV4XPiaIlWxHl7t6ADK lMwY0+hFP95aSH3n7oLHhmyHkWPMqBUAwg7x1A2e4mG6AQ+WlfcQ4NUQ7ChctUQ+ CRHcyf6YJ4hkaWoOgknCoCQEb1RabcdLFHH24XL5aybWZFTDMWDKsPZj4kTDbOnB Oiz/svoMnnlbgTxolGw92BaDDTqEBKVETMT+YfP8uEs2Mr2dRTPCTo/0g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdehhedgfeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucgfrhhlucfvnfffucdljedtmdenucfjughrpeffhf fvvefukfhfgggtuggjsehgtdorredttddvnecuhfhrohhmpefoihgthhgrvghlucfrrghq uhhivghruceomhhitghhrggvlhesphgrqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvg hrnhepffduleehgefhkeefgfeftdfhkedutddvhfdukeeggeehieekffelhfelkeehteef necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhitg hhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 28 Mar 2023 20:09:56 -0400 (EDT) Date: Wed, 29 Mar 2023 09:09:50 +0900 From: Michael Paquier To: Kyotaro Horiguchi Cc: bertranddrouvot.pg@gmail.com, melanieplageman@gmail.com, andres@anarazel.de, pgsql-hackers@lists.postgresql.org Subject: Re: Reconcile stats in find_tabstat_entry() and get rid of PgStat_BackendFunctionEntry Message-ID: References: <32cd9a82-9221-f081-87d4-1f4fa6359a4d@gmail.com> <20230328.174326.1226788895063455868.horikyota.ntt@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mAOXNzbI1242uBH5" Content-Disposition: inline In-Reply-To: <20230328.174326.1226788895063455868.horikyota.ntt@gmail.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --mAOXNzbI1242uBH5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 28, 2023 at 05:43:26PM +0900, Kyotaro Horiguchi wrote: > No. Fine by me, except that "block read requests" seems to suggest > kernel read() calls, maybe because it's not clear whether "block" > refers to our buffer blocks or file blocks to me.. If it is generally > clear, I'm fine with the proposal. Okay. Would somebody like to draft a patch? -- Michael --mAOXNzbI1242uBH5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmQjgc4ACgkQnvQgOdby QH3AWA/9EpzC60D7yRyIqON+UBW9Y7AvxPmus8ZOmqf1OL+gK+FKmmbOR+7vZSQX NQoh7q3wtGV7MYUbdDibaNuIz7ncsM0AOX+l9/yjOGkXIbn+FbyQPuYGrB3ZM32B lLlf8Sx8YZ3zPwYgRxRKQ80wMC7pU5u3BsjO14ggV2SK3leA0wOsZ56d5vazpfBP 81glYoQpJNjv3wYp9fYR+fGWML5EqUrHFZ3tQZa9Wg2VTFFBu3RlFUr2W//JK/sY tix9Dl+XwDGhLk2InLbmnjQvrXOaMu+dxuO+FfALZUUXsUmxfWpfWwirdbw8IfTz 0FkoqzoizyiClfrGS9rn8e9VSZ8X8MS3SWwmT1J11DepQ+4C+KzQl4yZsn0QHoUQ ApmWgiFm1z/xLkfeZRLS7038XsZkQJ06R/eaaxlLi2BPzbeucJQW9M/YaQIY0caj X0TUd3ZTQGhePde/uwIhmF4jobPiJuTlgW71epiJUe85v895ZuLLahi6rbaRId4f K0yntNGYL698MNAccehRcosjq5kIklie+l5quDA1DTVeqT3WJy8O56iKdpSNJnqw QM2DzDJ0SHFa7k1LmcOyFNtJQYLrn9u81oBfoB4p52l3iVdIgidbERcva710QbS4 ZCXu0qtcYJ62hgp5AP2KkMl/1R3XsVhMHrDvwzHOIBr2eBdHSi8= =cfZq -----END PGP SIGNATURE----- --mAOXNzbI1242uBH5--