Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 29 Mar 2023 09:18:50 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Soumyadeep Chakraborty <soumyadeep2007@gmail.com>,
	Zhihong Yu <zyu@yugabyte.com>, pgsql-hackers@postgresql.org,
	Ashwin Agrawal <ashwinstar@gmail.com>, vanjared@vmware.com
Subject: Re: ALTER TABLE SET ACCESS METHOD on partitioned tables
Message-ID: <ZCOD6pchDdoFIg/l@paquier.xyz>
References: <ZCIxFkgOGv64nYE7@paquier.xyz>
 <ZCJuW3GOfE/0eBjh@telsasoft.com>
 <ZCKBjKVCgKxaU3+U@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="PF7gkfTwvtfT3oBA"
Content-Disposition: inline
In-Reply-To: <ZCKBjKVCgKxaU3+U@paquier.xyz>
Archived-At: <https://www.postgresql.org/message-id/ZCOD6pchDdoFIg/l%40paquier.xyz>
Precedence: bulk


--PF7gkfTwvtfT3oBA
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 28, 2023 at 02:56:28PM +0900, Michael Paquier wrote:
> Hmm.  This is a good point.  It is true that the patch feels
> incomplete on this side.  I don't see why we could not be flexible,
> and allow a value of 0 in a partitioned table's relam to mean that we
> would pick up the database default in this case when a partition is
> is created on it.  This would have the advantage to be consistent with
> older versions where we fallback on the default.  We cannot be
> completely consistent with the reltablespace of the leaf partitions
> unfortunately, as relam should always be set if a relation has
> storage.  And allowing a value of 0 means that there are likely other
> tricky cases with dumps?
>=20
> Another thing: would it make sense to allow an empty string in
> default_table_access_method so as we'd always fallback to a database
> default?

FYI, I am not sure that I will be able to look more at this patch by
the end of the commit fest, and there are quite more points to
consider.  Perhaps at this stage we'd better mark it as returned with
feedback?  I understand that I've arrived late at this party :/
--
Michael

--PF7gkfTwvtfT3oBA
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmQjg+kACgkQnvQgOdby
QH3+6w/8CSaVdtHSxXnRStyJBnd5/BMEV7x6f+DaoWLbcO+uPqlOBHixmq+8vayy
b9N0qbhSxsGmWaySYhf/HbG/FULMiKuYw9lrpJAzy2mH5zrI7h/O5hQr9aHrCaay
rC9uqmY75ouH/1WUTm9UtNgzBGStmrJD0pL5RMVOW++GMu53gUjsdemanmIuyTH6
fcwjSCPUTKNnTo/WrA3fF8z6KmDecNkTm9VtZyoYrFuEk5yFMuqAhmD1O7uzQHjT
NMiDeTVKJoRz69u6p1ftRKpZBkJKQ0cPXJlXwBzEM+WHioylEP1xMSMhRjGGq9K+
m87X1Mv5rog8V2JL8T0v0N9ZjsJNDyEspoN3UJNxk8Ev0ncvvp8OS+/Kh/e/qfEn
MvotpAZ23k5E4wS3l9EX0uUI2OpwC8RH4sciiLDz0Ca2hnns+lWCK3O7ATkrf3/A
MaMkEP5FoVDJ1AQasp6ySpQAJ0CdGUaUYVHpM60NxSv8zFYzE7cG7nTRsUTf6gJb
iSUy4Wi3JgejnicPHSPUpfprySFDTkxib+j77ugIAIcl6zfdCl29n/8JupOO2hjU
80Z0L6pWcDlDv2hCIIPiF7MDvvjWFNpYjfjkN7tVyGoIQPrKyzyRIAl40xb2Zzbi
8jnaAYf+NpIYN0k1VgTPPYbLqBEVIIhc1XlOP8mKmj82kR/glv4=
=t4iY
-----END PGP SIGNATURE-----

--PF7gkfTwvtfT3oBA--