Date: Wed, 29 Mar 2023 08:35:28 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Kirk Wolak <wolakk@gmail.com>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>,
	Jacob Champion <jchampion@timescale.com>,
	pgsql-hackers@postgresql.org, gkokolatos@pm.me,
	Michael Paquier <michael@paquier.xyz>,
	Robert Haas <robertmhaas@gmail.com>, Peter Geoghegan <pg@bowt.ie>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	Heikki Linnakangas <hlinnaka@iki.fi>,
	Thomas Munro <thomas.munro@gmail.com>,
	Dipesh Pandit <dipesh.pandit@gmail.com>,
	Andrey Borodin <x4mmm@yandex-team.ru>,
	Mark Dilger <mark.dilger@enterprisedb.com>
Subject: Re: zstd compression for pg_dump
Message-ID: <ZCQ+oBeZir1x/9eS@telsasoft.com>
References: <20230303185546.GE12850@telsasoft.com>
 <CAAWbhmj-pEhpzfMA+ARnq+L3uS1A1AsmNjz9m_Cx=73n4GRZjQ@mail.gmail.com>
 <20230304165747.GH12850@telsasoft.com>
 <CAAWbhmgm8yzKLnwK8-Wj-nhYo3R0AvLF6FSX-Pgo=062hGz4JA@mail.gmail.com>
 <3d04afca-7d9d-c90f-5fef-5cf4fdb2173f@timescale.com>
 <ZBKgBz+4blcKru6x@telsasoft.com>
 <0115b682-58f0-ea43-9ecd-c37a4495812e@enterprisedb.com>
 <ZCHSSv3DgxUa0f3L@telsasoft.com>
 <0022dd9e-a439-d72f-d09b-ec512c23949b@enterprisedb.com>
 <CACLU5mSt7CVTPLEPEjyk0nPxxFxQddO3c=JBrAMN_uUGTN6PfA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CACLU5mSt7CVTPLEPEjyk0nPxxFxQddO3c=JBrAMN_uUGTN6PfA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ZCQ%2BoBeZir1x/9eS%40telsasoft.com>
Precedence: bulk

On Tue, Mar 28, 2023 at 02:03:49PM -0400, Kirk Wolak wrote:
> On Tue, Mar 28, 2023 at 12:23 PM Tomas Vondra <tomas.vondra@enterprisedb.com> wrote:
> > On 3/27/23 19:28, Justin Pryzby wrote:
> > > On Fri, Mar 17, 2023 at 03:43:31AM +0100, Tomas Vondra wrote:
> > >> On 3/16/23 05:50, Justin Pryzby wrote:
> > >>> On Fri, Mar 10, 2023 at 12:48:13PM -0800, Jacob Champion wrote:
> > >>>> On Wed, Mar 8, 2023 at 10:59 AM Jacob Champion <jchampion@timescale.com> wrote:
> > >>>>> I did some smoke testing against zstd's GitHub release on Windows. To
> > ...
> > OK. I don't have access to a Windows machine so I can't test that. Is it
> > possible to disable the zstd threading, until we figure this out?
>
> Thomas since I appear to be one of the few windows users (I use both), can I help?
> I can test pg_dump... for you, easy to do.  I do about 5-10 pg_dumps a day
> on windows while developing.

It'd be great if you'd exercise this and other changes to
pg_dump/restore.  Tomas just pushed a bugfix, so be sure to "git pull"
before testing, or else you might rediscover the bug.

If you have a zstd library with thread support, you could test with
-Z zstd:workers=3.  But I think threads aren't enabled in the common
libzstd packages.  Jacob figured out how to compile libzstd easily using
"meson wraps" - but I don't know the details.

-- 
Justin