Date: Mon, 3 Apr 2023 14:17:30 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Jacob Champion <jchampion@timescale.com>, pgsql-hackers@postgresql.org,
	gkokolatos@pm.me, Michael Paquier <michael@paquier.xyz>,
	Robert Haas <robertmhaas@gmail.com>, Peter Geoghegan <pg@bowt.ie>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	Heikki Linnakangas <hlinnaka@iki.fi>,
	Thomas Munro <thomas.munro@gmail.com>,
	Dipesh Pandit <dipesh.pandit@gmail.com>,
	Andrey Borodin <x4mmm@yandex-team.ru>,
	Mark Dilger <mark.dilger@enterprisedb.com>
Subject: Re: zstd compression for pg_dump
Message-ID: <ZCsmSoiBMVfrlOXm@telsasoft.com>
References: <ZBKgBz+4blcKru6x@telsasoft.com>
 <0115b682-58f0-ea43-9ecd-c37a4495812e@enterprisedb.com>
 <ZCHSSv3DgxUa0f3L@telsasoft.com>
 <0022dd9e-a439-d72f-d09b-ec512c23949b@enterprisedb.com>
 <ZCdpzywVGl0BLan2@telsasoft.com>
 <4029fe58-f661-7d8d-cbbb-b936a05531e2@enterprisedb.com>
 <ZCd6sb7XA/W6nLaD@telsasoft.com>
 <2de3bcad-6da9-9022-bce5-fc0416351d6e@enterprisedb.com>
 <ZCgzbBVKLvwpqMzT@telsasoft.com>
 <f3947107-a95a-348c-263c-284ac7275ae0@enterprisedb.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f3947107-a95a-348c-263c-284ac7275ae0@enterprisedb.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ZCsmSoiBMVfrlOXm%40telsasoft.com>
Precedence: bulk

On Sat, Apr 01, 2023 at 10:26:01PM +0200, Tomas Vondra wrote:
> > Feel free to mess around with threads (but I'd much rather see the patch
> > progress for zstd:long).
> 
> OK, understood. The long mode patch is pretty simple. IIUC it does not
> change the format, i.e. in the worst case we could leave it for PG17
> too. Correct?

Right, libzstd only has one "format", which is the same as what's used
by the commandline tool.  zstd:long doesn't change the format of the
output: the library just uses a larger memory buffer to allow better
compression.  There's no format change for zstd:workers, either.

-- 
Justin