Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pjpii-00071J-Kq for pgsql-hackers@arkaria.postgresql.org; Tue, 04 Apr 2023 23:05:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pjpih-0006rs-IQ for pgsql-hackers@arkaria.postgresql.org; Tue, 04 Apr 2023 23:05:43 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pjpif-0006rj-Rk for pgsql-hackers@lists.postgresql.org; Tue, 04 Apr 2023 23:05:43 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pjpid-0005CC-4T for pgsql-hackers@lists.postgresql.org; Tue, 04 Apr 2023 23:05:40 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id E4F6932008C3; Tue, 4 Apr 2023 19:05:36 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 04 Apr 2023 19:05:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1680649536; x=1680735936; bh=Gr 0CKAVgzE93EmsOHbyk7FE/DVQPRpbIlH9d1whRt3Y=; b=n/BUdQhRzuSAlcNV26 3F0YSAR9vSEQ7LjH8vYdioPjdIT2BPnnYW3G5zJyfMIzfmZKsDeDkcK6GWVYmG6H MLKvKrkYbeZyjqzJmc3x7UoI6kGV47BWqYQJapYiNJd0wp/80yZJtW/xE7e2qzbV NQnUA7WWgfik1dukm6oP+PtmlSxswv6PquaUiLGLtUjImSgsPWQqbQbq3YhxTEo3 s7dqLQ0UzMVQqNynu75+B+ITC65FJ0rRjzCB/K6yWZFR+XAtZDbGBiWlpHc/xWlD sDF09Lhr8LLwiznGXoka2Hd3ik5YU1TFuCFdzSvB7EsrxA/y+O/+QrJhk4ppkUWU hDgA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1680649536; x=1680735936; bh=Gr0CKAVgzE93E msOHbyk7FE/DVQPRpbIlH9d1whRt3Y=; b=TB0BBD+4MEwoOGLtUA88RwxVDV0N1 BdWmh6ZSHd29urkb/S3o07rSAeOMkyczkXeoP7TW+cYr4g3WOGCLzCKeBkpHcRqR 6No/BgE74w8pqi3hQFu0QYyrtuwdz0prtirAgyqixXurKovM2fWhyQsU1xqvN8vr lLd+NRqxH32VRY5UJEZ8iOjS8+3PJ1Y9pXiueFoYiM/xjDvKwySBqyxqPbfHLg2f 7Mn9CxJdvrDpmCgNqQZL3EbBi+HZJMLIT2AxDD6+cnZrI/z+olYNVCyJ5ATfuB71 evt/2T6tBivLTq3A3xKdCwB2kdtYqXHlDUwVsIKs+gH2d8A8rRSA+lVkA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdejtddgudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 4 Apr 2023 19:05:33 -0400 (EDT) Date: Wed, 5 Apr 2023 08:05:27 +0900 From: Michael Paquier To: "Drouvot, Bertrand" Cc: Kyotaro Horiguchi , melanieplageman@gmail.com, andres@anarazel.de, pgsql-hackers@lists.postgresql.org Subject: Re: Reconcile stats in find_tabstat_entry() and get rid of PgStat_BackendFunctionEntry Message-ID: References: <32cd9a82-9221-f081-87d4-1f4fa6359a4d@gmail.com> <20230328.174326.1226788895063455868.horikyota.ntt@gmail.com> <1bf875d6-43ed-83bd-62df-5355207b329e@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="KNvIM+98YXqTBXBJ" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --KNvIM+98YXqTBXBJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Apr 04, 2023 at 09:04:34PM +0900, Michael Paquier wrote: > This addition looks OK for me. Thanks for the patch! Okay, finally done. One part that was still not complete to me in light of the information ddfc2d9 has removed is that the number of physical reads could be lower than the reported number depending on what the kernel cache holds. So I've added this sentence, while on it. -- Michael --KNvIM+98YXqTBXBJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmQsrTcACgkQnvQgOdby QH3tDBAAlUuls0TWr8ny9dXiyLkFfpBqsF2PXvtJS4u3uDemL24dBKOWtQ2MoASX GLqKQcM6+O7xXSwhu1but6pAxqzgqTcgv4ZlfweIXtKnz4V9Q4b6PUrqNQdvqYJR 2+4KcIdpxERoL9yUsumeSGHAULWNTJgqMNjFe2YupdFVPbvADPRLKjpKMWvzRz2c Cr0tuON0Ae+GVkBzKYo6lnDYOZROnOelE8LP3XqYUVaMY4XNLuT9Frx/8AO4MBzy q51JkoCVcpSiNElA/VQvVKOA7z+prkhSV8RKlEAiEL4krKoEH0FKEWxwAP5ihVeN wxsEFQ0P/gSFdKI8L3Oq3XDQLLN9AujnSNft0LRmqguM3MjC3d/t0o8tYhvVJk7U hqAY+5S3KcPtOaLvAkUDK0TyIniLhtYZ/DKB04wLK3wb/32lFkmd1Cyrst7fIuG3 Gqjg4eNthSHTiVPcaT+Vs+z7KYl6UuPObnion6EfRR8a70hbIZ2RX7aFYygcNkOq pmI2q2NvP5SMJpP9weJex+paFWDV1L13gkdv23832qGYJAOBo/EvnpQoLi9HCVAz hZUdTQJGmfbpBYSN3JZLua+6o6kW/ttti47mSGHaV9KoJs9e4bF1yXVrFeoLm7n0 j1hskrFzAC9NJmRQQ888xaVEeLFykj3hF0gbfC92SpldLVek2g4= =DPAt -----END PGP SIGNATURE----- --KNvIM+98YXqTBXBJ--