Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1poOQ2-0002dH-Tx for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Apr 2023 12:57:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1poOQ1-00039N-9W for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Apr 2023 12:57:17 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1poOQ0-00036y-Jl for pgsql-hackers@lists.postgresql.org; Mon, 17 Apr 2023 12:57:16 +0000 Received: from tamriel.snowman.net ([70.109.60.50]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1poOPx-000JjL-FN for pgsql-hackers@lists.postgresql.org; Mon, 17 Apr 2023 12:57:15 +0000 Received: by tamriel.snowman.net (Postfix, from userid 1000) id 73BC35F7B6; Mon, 17 Apr 2023 08:57:07 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=snowman.net; s=dkim; t=1681736227; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5yIP6rknuyv7f3Yi6S2idxLfGx6pjc6jhbe4cliCAvI=; b=Ayu+HCZHSi9yYBHpIhbMZGjPp2yYZXIEkZHULquKJ2ws+uQRkV6QuSSIfmTXOzToDnVIMH FYpXi6EN9/BRJsonyRQK/nulUClDP+R/JAN7q2INQBCmn2bLHpXC+grvvnZqrNBaHeSMeY kVM/8/Js6LKqFrzSKU4HezQ8mHSIzoo= Date: Mon, 17 Apr 2023 08:57:07 -0400 From: Stephen Frost To: Tom Lane Cc: "Jonathan S. Katz" , Thomas Munro , pgsql-hackers@lists.postgresql.org, Amit Kapila , Alvaro Herrera Subject: Re: longfin missing gssapi_ext.h Message-ID: References: <763952.1681272015@sss.pgh.pa.us> <1123190.1681314906@sss.pgh.pa.us> <1ed077e4-a831-b0b6-7298-0238cf6b0c08@postgresql.org> <2313469.1681695223@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/unk0efry2glBzIO" Content-Disposition: inline In-Reply-To: <2313469.1681695223@sss.pgh.pa.us> User-Agent: Mutt/2.1.4 (2021-12-11) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --/unk0efry2glBzIO Content-Type: multipart/mixed; boundary="ULJc4MJ3if+r2zCm" Content-Disposition: inline --ULJc4MJ3if+r2zCm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Greetings, * Tom Lane (tgl@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > Pushed, thanks again to everyone. > > I'll monitor the buildfarm and assuming there isn't anything unexpected > > then I'll mark the open item as resolved now. >=20 > The Debian 7 (Wheezy) members of the buildfarm (lapwing, skate, snapper) > are all getting past the gssapi_ext.h check you added and then failing > like this: >=20 > ccache gcc -std=3Dgnu99 -Wall -Wmissing-prototypes -Wpointer-arith -Wdecl= aration-after-statement -Werror=3Dvla -Wendif-labels -Wmissing-format-attri= bute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=3Dst= andard -g -O2 -Werror -I../../../src/include -DENFORCE_REGRESSION_TEST_NAM= E_RESTRICTIONS -D_GNU_SOURCE -I/usr/include/libxml2 -I/usr/include/et -c = -o be-gssapi-common.o be-gssapi-common.c > be-gssapi-common.c: In function 'pg_store_delegated_credential': > be-gssapi-common.c:110:2: error: unknown type name 'gss_key_value_element= _desc' > be-gssapi-common.c:111:2: error: unknown type name 'gss_key_value_set_des= c' > be-gssapi-common.c:113:4: error: request for member 'key' in something no= t a structure or union > be-gssapi-common.c:114:4: error: request for member 'value' in something = not a structure or union > be-gssapi-common.c:115:7: error: request for member 'count' in something = not a structure or union > be-gssapi-common.c:116:7: error: request for member 'elements' in somethi= ng not a structure or union > be-gssapi-common.c:119:2: error: implicit declaration of function 'gss_st= ore_cred_into' [-Werror=3Dimplicit-function-declaration] >=20 > Debian 7 has been EOL five years or so, so I don't mind saying "get a > newer OS or disable gssapi". However, is it worth adding another > configure check to fail a little faster with whatever Kerberos > version this is? Checking that gss_store_cred_into() exists > seems like the most obvious one of these things to test for. Sure, I can certainly do that and agreed that it makes sense to check for gss_store_cred_into(). How about the attached which just switches from testing for gss_init_sec_context to testing for gss_store_cred_into? Thanks! Stephen --ULJc4MJ3if+r2zCm Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="krb5_update_func_check.patch" Content-Transfer-Encoding: quoted-printable diff --git a/configure.ac b/configure.ac index c53a9c788e..1362f57a27 100644 --- a/configure.ac +++ b/configure.ac @@ -1340,8 +1340,8 @@ fi =20 if test "$with_gssapi" =3D yes ; then if test "$PORTNAME" !=3D "win32"; then - AC_SEARCH_LIBS(gss_init_sec_context, [gssapi_krb5 gss 'gssapi -lkrb5 -= lcrypto'], [], - [AC_MSG_ERROR([could not find function 'gss_init_sec_co= ntext' required for GSSAPI])]) + AC_SEARCH_LIBS(gss_store_cred_into, [gssapi_krb5 gss 'gssapi -lkrb5 -l= crypto'], [], + [AC_MSG_ERROR([could not find function 'gss_store_cred_= into' required for GSSAPI])]) else LIBS=3D"$LIBS -lgssapi32" fi diff --git a/meson.build b/meson.build index 3405cc07ee..f1db5455b0 100644 --- a/meson.build +++ b/meson.build @@ -634,14 +634,14 @@ if not gssapiopt.disabled() endif =20 if not have_gssapi - elif cc.has_function('gss_init_sec_context', dependencies: gssapi, + elif cc.has_function('gss_store_cred_into', dependencies: gssapi, args: test_c_args, include_directories: postgres_inc) cdata.set('ENABLE_GSS', 1) =20 krb_srvtab =3D 'FILE:/@0@/krb5.keytab)'.format(get_option('sysconfdir'= )) cdata.set_quoted('PG_KRB_SRVTAB', krb_srvtab) elif gssapiopt.enabled() - error('''could not find function 'gss_init_sec_context' required for G= SSAPI''') + error('''could not find function 'gss_store_cred_into' required for GS= SAPI''') else have_gssapi =3D false endif --ULJc4MJ3if+r2zCm-- --/unk0efry2glBzIO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEwf6gbxKhD863zrx/7WyKOINHZFUFAmQ9QiAACgkQ7WyKOINH ZFXFMA//USxZZ+jznnuYEwAUNKoGAqezpbRpbR0H8Mw2E2YJEslYkYxRz8mz4LvX 9akac3BBtw2tuPB9LGLec7Q3qWueYf9RvUk9BUaMCeIpLI8PrgqzD2ky9e9mtysK 6Ot4/LMveo3rCRvp+3QvQ41kCirjpuq43IufKCxmLlrfZ1FtBLDSTIfFJKo+R4qL cAmyCtjXos6+ASOKvoZbAEpIq1EOGkNP5CG4fHq0MX/vS1xQqFN34E0GSVEw1bnE jXli+yyQ156aWKYjW7Horpzgl9YQHlIkhK/UWtbY/yab/q4eBJO7+ezfa2zpIsOG 6MZx7bwYjXgsWF7z+a23cSW3UQOZTHYvC417NyTwmVpSmXqC+8zmCj2RkzvKk+sv 423jKKW7a2zvMoNqmdJ1MnIrf5EcC7aznMEGgNUlfd4eMv360rPGFXQO9E0mp47y /59ozPw5vFy473oQFEo20TerehHq/30g/k99Hmy+zmEEQJJMcZfhvYpb/HygrDaA SKHkQOTJkEexIRw2pYNFwox64/Dz4MYZB92pHoTeRHv9Jz0cyPrLTgKRDXCZmrSG KBVjU0zebcPaZpek/42sPV6NPIvOqkj1mH0mLGx0ww3O9uUyBHp6xhKE/sb+cY1U K9DPOQXOldZs6UHxn8cNqI354rOmOVCUoic4l1tEh63YfF9NCvE= =GJOv -----END PGP SIGNATURE----- --/unk0efry2glBzIO--