Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1poQSK-0001E7-BH for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Apr 2023 15:07:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1poQSJ-0003Qo-6n for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Apr 2023 15:07:47 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1poQSI-0003Qe-IQ for pgsql-hackers@lists.postgresql.org; Mon, 17 Apr 2023 15:07:46 +0000 Received: from tamriel.snowman.net ([2001:470:e38f::11]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1poQSF-003RvU-NV for pgsql-hackers@lists.postgresql.org; Mon, 17 Apr 2023 15:07:45 +0000 Received: by tamriel.snowman.net (Postfix, from userid 1000) id 8CF8A5F7B6; Mon, 17 Apr 2023 11:07:37 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=snowman.net; s=dkim; t=1681744057; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i6HTuMfMvJCPzR7Gpo8dbMbGmX3p7SoPuRcAdCVwvig=; b=WvdZc15weJuiJfQVhdl6V8+mKT/YEpA9RcE3Ctk3pSfeBC7JuAwA16Xwj+Vgblg/bcA+Ek T343iVlgIIqVcxdwnNztWWqRS02fmgkdRBxYPvVeCXYuYCn6tONNy+zP9SGqhfe/1cV2kg 7/m/TZv1vRdxDZxJLAgEoDvXF+IeqE0= Date: Mon, 17 Apr 2023 11:07:37 -0400 From: Stephen Frost To: Tom Lane Cc: "Jonathan S. Katz" , Thomas Munro , pgsql-hackers@lists.postgresql.org, Amit Kapila , Alvaro Herrera Subject: Re: longfin missing gssapi_ext.h Message-ID: References: <1ed077e4-a831-b0b6-7298-0238cf6b0c08@postgresql.org> <2313469.1681695223@sss.pgh.pa.us> <2415254.1681738677@sss.pgh.pa.us> <2418000.1681740070@sss.pgh.pa.us> <2422362.1681741814@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="NHU/0xXnNAdI5ZGh" Content-Disposition: inline In-Reply-To: <2422362.1681741814@sss.pgh.pa.us> User-Agent: Mutt/2.1.4 (2021-12-11) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --NHU/0xXnNAdI5ZGh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Greetings, * Tom Lane (tgl@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > I'm guessing it's not really an issue but it does make changing > > configure a bit annoying on my Ubuntu 22.04, when I run autoconf2.69, I > > end up with this additional hunk as changed from what our configure > > currently has. >=20 > Not surprising. Thanks to autoconf's long release cycles, individual > distros often are carrying local patches that affect its output. > To ensure consistent results across committers, our policy is that you > should use built-from-upstream-source autoconf not a vendor's version. > (In principle that could bite us sometime, but it hasn't yet.) =2E.. making me more excited about the idea of getting over to meson. > Also, you should generally run autoheader after autoconf. > Checking things here, I notice that pg_config.h.in hasn't been > updated for the last few gssapi-related commits: >=20 > $ git diff > diff --git a/src/include/pg_config.h.in b/src/include/pg_config.h.in > index 3665e79..6d572c3 100644 > *** a/src/include/pg_config.h.in > --- b/src/include/pg_config.h.in > *************** > *** 196,201 **** > --- 196,207 ---- > /* Define to 1 if you have the `getpeerucred' function. */ > #undef HAVE_GETPEERUCRED > =20 > + /* Define to 1 if you have the header file. */ > + #undef HAVE_GSSAPI_EXT_H > +=20 > + /* Define to 1 if you have the header file. */ > + #undef HAVE_GSSAPI_GSSAPI_EXT_H > +=20 > /* Define to 1 if you have the header file. */ > #undef HAVE_GSSAPI_GSSAPI_H > =20 > Shall I push that, or do you want to? Hrmpf. Sorry about that. Please feel free and thanks for pointing it out. Thanks again, Stephen --NHU/0xXnNAdI5ZGh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEwf6gbxKhD863zrx/7WyKOINHZFUFAmQ9YLYACgkQ7WyKOINH ZFXcqhAApWxW3sMKWJdZmYxAZ6jd99KDmrGMxgNTvlEDfuZXxeWnlvv7Qu61/blm HBR5RX/dsD4/MQ4sU2gW70+t7/QbFd3NIEepISQHfeZi09O50iDBid8wvcd5liFX 1AszrU6Nj027GCVaHGcndvrRt6Ej/iS5i9p4gRYAvMd+t9VbfHueEyB8n5R+2UOM bryotALDdzsMbbDMjG6tbbazw2xvm8elk7DskUqoZzhi6/McBNp0lIDV7lk5/6/c edrObw43tQvoFJUifxtQ56voY7mGo4V1YaHB3eRSSktZSttW18DSHwArWtzuQAi5 pYvWj+XckEFCRTNEadOV8xvE1+G7Y4FhfP00xqvdkNev3oathH8v1WMzJA8YY0BR owbRF+hkbdAS/QlJZOvYHcWozTFrNYjgCmDX72ssfqgJW9oHP9P9nr0Ons6run3T 8NJxrYg3YsyNjPvlUxnXOG2Xj25fMdRZxgqSIbcvGfVJejn59g5b9XXAzIW8ITRH /0vsMmwg0i5QxswX5ArzEa4yX1tE1BcynHQa3PYWx0Qrc/4bLZCv4Kk/4RShUWxc 5iH/1XFbcg0tFfFUcFzXmp8on1W5LqgSCdWeQKNvdx+tamXX12R62uyhXCYcOHst naxtlA9Sl8seZBrsEIbaqxn3yg6fmmk0FPwWUbzUcnHktGftqB4= =09eY -----END PGP SIGNATURE----- --NHU/0xXnNAdI5ZGh--