Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pobBu-0003zT-Sv for pgsql-hackers@arkaria.postgresql.org; Tue, 18 Apr 2023 02:35:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pobBs-0002KQ-Io for pgsql-hackers@arkaria.postgresql.org; Tue, 18 Apr 2023 02:35:32 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pobBr-0002KF-5G for pgsql-hackers@lists.postgresql.org; Tue, 18 Apr 2023 02:35:32 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pobBl-000QQN-FN for pgsql-hackers@lists.postgresql.org; Tue, 18 Apr 2023 02:35:29 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id A88383200948; Mon, 17 Apr 2023 22:35:22 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 17 Apr 2023 22:35:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1681785322; x=1681871722; bh=DW ZTcu5Ol2XCBvI3OvbJdsPNV1GL4Zk0pLfnX3pEGw0=; b=0wHXy49ZWwLMWZ0FhB bhk8nMGcS1KriphOXZd0sfVAG9PAnVPnvcL4nojIoZ1BhLEWAJsvUiyFWNko9Ji7 L9JslHoQciBuwYDat2N4v5U9ujrN9yRliso59TXtE0gIHI5bnND4T9SgLXGf0NAm 87oJAGDOm7cF+9drq+GNXQGulQ+ogFk+zn+91et1aFquwiUM+QMIeHO8t6WfiI6J Dy1vQ/RjzcZMzjI1EXEIa/GRxS6NfZVYZ+awjLGjVAkols/hp9jM5bQpP6S4q9c4 jHltPzwSCCqkrjhLjV++yihO4hk79wHceRUvR4wjwku70rxfIPV9bXitqQJZFkkb GS9g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1681785322; x=1681871722; bh=DWZTcu5Ol2XCB vI3OvbJdsPNV1GL4Zk0pLfnX3pEGw0=; b=blo8PQZvTE+RqrbpJFjdonnNmeSDA Scvhp00R9os4xg7oNqUdC4JmAteVOqOIsiWjR2LF5D4NoXdGumq38Dcu73D75Ia2 Kqry8sY0RcSylJnL66vwTi3se5KYNXYIyJgAt3xjlj+mCRs5kSsp824MgJfWWMAt 4rT71AZUnLaUYHZk/fAmU93XFzNj1jPdkSSBcI6XXV12WH2XjdIuqy9xoP8vrk2G LMoIB0JOUtcJNQ2yRo/W5mAoHHc2pi0B0VP0qBtR8Sq0wQ21rXJ0nRwkgnfRixgz ZagOzF8JTJh02ifU5+PJRmUvYDajKyw78+Nd1M/pOSsz52qFukxOGeqFQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeljedgieduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucgfrhhlucfvnfffucdlfeehmdenucfjughrpeffhf fvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfrrghq uhhivghruceomhhitghhrggvlhesphgrqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvg hrnhepgeffjeevgfevuddvjedtvddtieejheduueelvddufedtgfefjedvkeevkeeivddv necuffhomhgrihhnpehpohhsthhgrhgvshhqlhdrohhrghenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghr rdighiii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 17 Apr 2023 22:35:20 -0400 (EDT) Date: Tue, 18 Apr 2023 11:35:16 +0900 From: Michael Paquier To: Kyotaro Horiguchi Cc: pgsql-hackers@lists.postgresql.org Subject: Re: eclg -C ORACLE breaks data Message-ID: References: <20230410.173500.440060475837236886.horikyota.ntt@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0KVey6WqLRT4Ri7J" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0KVey6WqLRT4Ri7J Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 17, 2023 at 05:00:59PM +0900, Michael Paquier wrote: > This thinko has been introduced by 3b7ab43, so this needs to go down > to v11. I'll see to that. So done. mylodon is feeling unhappy about that, because this has a C99 declaration: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=mylodon&dt=2023-04-18%2002%3A22%3A04 char_array.pgc:73:8: error: variable declaration in for loop is a C99-specific feature [-Werror,-Wc99-extensions] for (int i = 0 ; i < sqlda->sqld ; i++) I'll go fix that in a minute, across all the branches for consistency. -- Michael --0KVey6WqLRT4Ri7J Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmQ+AeQACgkQnvQgOdby QH30whAAmjKcD2fMj/yUSj5VReDMxvgYmilyju+lYI92PlWD+vIQR6wzBHTyRGwL XQeFwnmtOSZOl+UV2Vw6ir5GilV/LyIPwn19xY8UjmcAB5ytjft+2sv+B6th9IdB luVEoj57CGflVULzgcJtVTPMWT4JmNl7y/myzw3w4ui/10IaFITIe6cWZoaZ2vKm VUs60ipezVqyT9rUC9J6EorCeoriVeosJVSp4MQFo5AJw/GEArBU5UGh4bXz0b95 E4gg9PsiC6pLU4YfSCgwdNhvKG5JvP/ywrAvL6bdq4rn/frmOF5+tP7n/+2ZRRLT sCZwaHC69Crc8QG0ww9nINC180MCrWBvsxAC8sa2M1RGSKu5HCfx0SmDCVOu8aFr EKDCw+rCR6hzKVrwGSux0RoAufZPnChzNq+CSs+0IhsqTZv/McyK8P61Rg13Rv/4 5nKjkYRclJI47dSu0alRq57gNMK3UhrtqPrWLcqPzNgsfSe81gd32FhGWk+76ZWP 46jL8/9YEw/UvJ32R+w7WSeIMNGzJVQ+Q/p+OTE/sQgA0So3NCD6DgsqjPg7eVWw Ii+W0Pjz0WX2O30ge86/RovJOGr2z9gYpY8EH3b/OCrbZisN/s6oVGiveE8Ni9Lq wsPAKciSpg8szNdkc8UDo9mma0sM4mFqAJ+OnrX97OLFGdUn1Ww= =OhSi -----END PGP SIGNATURE----- --0KVey6WqLRT4Ri7J--