Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkyTS-0003HV-JU for pgsql-hackers@arkaria.postgresql.org; Sat, 08 Apr 2023 02:38:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pkyTR-0003Xq-44 for pgsql-hackers@arkaria.postgresql.org; Sat, 08 Apr 2023 02:38:41 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkyTQ-0003XK-Q4 for pgsql-hackers@lists.postgresql.org; Sat, 08 Apr 2023 02:38:40 +0000 Received: from tamriel.snowman.net ([70.109.60.50]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkyTO-0003mq-Kg for pgsql-hackers@lists.postgresql.org; Sat, 08 Apr 2023 02:38:39 +0000 Received: by tamriel.snowman.net (Postfix, from userid 1000) id D87785F7B6; Fri, 7 Apr 2023 22:38:33 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=snowman.net; s=dkim; t=1680921513; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rb0KPROPjRq5giPyzdbuljBmZQYfd1+eQWuw5+QSxRo=; b=Xj3aLeQin2A3Y1UfBngddy2nA9/J5/0SLAAkBH7cmah7OFHfeqvlBBFTEE6dB12a3J1HQg x6sBKGmo5f6d29Ar49CIr9S6XmNCK6CxuEeMJegh//Q2w5kyM+3EvC3pVLiUoS02W9nfKi D946i28TfmeyCk+bKJk4wsYgxX2raek= Date: Fri, 7 Apr 2023 22:38:33 -0400 From: Stephen Frost To: Tom Lane Cc: pgsql-hackers@lists.postgresql.org Subject: Re: longfin missing gssapi_ext.h Message-ID: References: <3282942.1680920692@sss.pgh.pa.us> <3284314.1680921096@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="MVqDNqxHcPZgDY5W" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.1.4 (2021-12-11) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --MVqDNqxHcPZgDY5W Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Greetings, * Stephen Frost (sfrost@snowman.net) wrote: > * Tom Lane (tgl@sss.pgh.pa.us) wrote: > > Stephen Frost writes: > > > * Tom Lane (tgl@sss.pgh.pa.us) wrote: > > >> It's whatever Apple is shipping, or was shipping last year or so. > >=20 > > > Sadly they've not been maintaining the Kerberos libraries at all on > > > their systems. > >=20 > > Indeed :-(. I wouldn't be surprised if there are security issues in > > their version. Perhaps what we really ought to do is refuse to build > > with their version --- but if so, we need some clearer error message > > about it. >=20 > The attached should (I believe?) at least add the needed check for > gssapi_ext.h which will cause builds to fail and complain about the > header being missing from their installation. >=20 > I'm certainly open to ideas about how to provide a better error message, > particularly on OSX systems which have an ancient version, to make it > clear that people need to install an updated version. I don't have an > OSX system at hand though. >=20 > Should I push this to at least address the header check ... ? Looks like buildfarm animal hake, at least, has a version recent enough to have gssapi_ext.h ... but still older than 1.11 and therefore doesn't have the type gss_key_value_element_desc defined, so maybe the check for gss_store_cred_into would be better? Certainly interesting how many old kerberos library installations there are, even in our buildfarm.. Thanks! Stephen --MVqDNqxHcPZgDY5W Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEwf6gbxKhD863zrx/7WyKOINHZFUFAmQw06kACgkQ7WyKOINH ZFXa/xAAiBgIAJfsO3ZUAotvyHrFbq7Ds1K/iSo+W5f4ByChjfITtub+sH13PTYo mNhXrZdoDKkyeHcJNC6nHB/bAL4FPDnevFVBMcDNMxcQVC0XQOy0VOz/se+oA9+O QkI51f3v5yXoT7RYb2ewlu6G6OshS2CxQIeNQh0c4KRTF7pFZwZJ+joTzzS+UZHz rJT10ZmDrakwNp+i6f38QkXBZEOEYcjL7uVBbv0mpDJ50Ppr+p5OMOFLlO4BHMwO pxrzeC6s1i2RBTApyOFhbkyWxH7rH20ToWOYP/3X0JMUCWZsazdwKXRwgkjMR26+ Yf7W2cgMIw/KIopEr/ihF0dQfN/Orapki6vHgk8qvRBxS+rftnQBDbt82nNfYQ7o tFcDt5HOhw2VeJpb06hp8HkTTaBq2X6UBUGL8u3qucmnLisHgknSbq+wJYtERh2K cvRayCetkJR8/6F/KHyACUsi8UvKRFLt1RFcqHfKUPqzexbCAoOTBOtMnrCSPnFz QkECIWYl5I1solSTJFYnbs3XklKNfJlkbkHIiFSfRDbb4mWT2R8byW/pGCa7TytU gCXwh5F3dYgeo3li378LL4u10GAVU1+haSS8Z60ynVd35ZGYVHBoZFBSkdEjPwKy ZZT+ni2rtieNkruHg8Bdkv1HfNb9dvLD255Mo+7vF1zWLluWEu0= =289s -----END PGP SIGNATURE----- --MVqDNqxHcPZgDY5W--