Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pl6yy-00069v-UW for pgsql-hackers@arkaria.postgresql.org; Sat, 08 Apr 2023 11:43:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pl6yx-0008SZ-Gz for pgsql-hackers@arkaria.postgresql.org; Sat, 08 Apr 2023 11:43:47 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pl6yw-0008SQ-SO for pgsql-hackers@lists.postgresql.org; Sat, 08 Apr 2023 11:43:47 +0000 Received: from tamriel.snowman.net ([2001:470:e38f::11]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pl6yu-00007c-Kg for pgsql-hackers@lists.postgresql.org; Sat, 08 Apr 2023 11:43:45 +0000 Received: by tamriel.snowman.net (Postfix, from userid 1000) id 12E9C5F7B6; Sat, 8 Apr 2023 07:43:38 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=snowman.net; s=dkim; t=1680954219; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1lnsWb+7lcWACxuBitmReplmL8rhH6Q5lSyOmefUxHw=; b=iIEgOLgp+2bDn0skybbVJxY+YOUvFO8EqmC/xli2LC6sduEMdHoQDsowfNfKuTwdokaq17 lThGOFYcIwxF8/jLTlDj0VBH00zZTVyex7QalviZm7+JEECc0ZAFPjnJFCHiKCfx/43ihV alK0lud8Qg22jCSKY958u4z2qh8U66Q= Date: Sat, 8 Apr 2023 07:43:38 -0400 From: Stephen Frost To: Tom Lane Cc: pgsql-hackers@lists.postgresql.org Subject: Re: longfin missing gssapi_ext.h Message-ID: References: <3282942.1680920692@sss.pgh.pa.us> <3284314.1680921096@sss.pgh.pa.us> <3286097.1680922218@sss.pgh.pa.us> <3311389.1680927614@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZsKpzxtmBfIDNFEP" Content-Disposition: inline In-Reply-To: <3311389.1680927614@sss.pgh.pa.us> User-Agent: Mutt/2.1.4 (2021-12-11) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --ZsKpzxtmBfIDNFEP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Greetings, * Tom Lane (tgl@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > I'm open to considering support for older versions, however ... >=20 > NetBSD 9.3, which is their *latest production release*, doesn't have > gssapi_ext.h [1]. For that matter, it doesn't look like their > not-yet-released 10.0BETA does either (my NetBSD 10 animals would > be failing if they had --with-gssapi). I do not think it's going > to be acceptable to require this feature. I'm certainly curious to understand what Kerberos library they're using and how they're maintaining it. At least some of the documentation I've found seems to indicate that it might be Heimdal, which does have gss_store_cred_into in gssapi.h. > I'm now going to reiterate my opinion that this patch should not > have been pushed in at this point of the dev cycle. A month ago, > there was time to deal with these sorts of issues. I suspected there would be an issue with OSX but hadn't expected an issue with NetBSD. I had tested this across a few Linux platforms and cfbot showed it wasn't causing issues on Windows or the platforms that are run there. Would be really great to have a way to test these things out on these other platforms other than just committing them and seeing what happens on the buildfarm. In any case, I've reverted it and we can pick this up for the next cycle. I'll play around with Heimdal locally as it appears to be available on Ubuntu (I had actually thought Heimdal to be mostly gone at this point since it only ever existed really due to silly export restrictions...) and see if there's actually anything other than making gssapi_ext.h itself be optional to be pulled in that's needed to make it work. Thanks, Stephen --ZsKpzxtmBfIDNFEP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEwf6gbxKhD863zrx/7WyKOINHZFUFAmQxU2cACgkQ7WyKOINH ZFVF4RAAmKC9Ri6Nd/l14E0oQeUMgVcam6dfmyrOXOgwgWLpX8vbol5FAbz0hshf 8G0rMIyWiu5tgTKUJP3guSz4u4HhG35Mwdwqo8xxvSj+7cf7nwdlvHDfPbupruGe sd5O8A0K0a42WH6JGOqIUpSvlDL8Db/oSGLlGFirlOo1NWGK9UggAomPxIbPrnXF CGzxVUdiv/nsi5vtKyS8n1L+BGidU+uPezPAs8+W/e8XmQ2IwF0KU+gjn1x1OIxu f8yhiKsoAzTD0q7LceiDNvLkm0RiWqd3hZR++HAySWjPSXFQ6swzcOpfw61Xiy/9 AU1w3aqTX7EcwFGbR4rzsXJ9w78sBlAhVAmpceHhaSAkFUgLcEvv7xDk/YTY6DvU AkyXOmy6ndXIZkNYtXBsSr5oJEqvLYXTfNQGrpqsA1rwAR/X34bOVZQsAh/U73mD NlRXBRPEvFDNCpv5jdfgKnzgDuHAOEGiTVXjna9mggokKE76gMBX8k680BajzlDY luGXt2RVwTOWhbmLD4OUTcAzmjKZAieq6jISONxJhFH12LJ9S9EXHN8vcE99QcML HqgOFO9tccM1tNveNVa80ygkuzJedsuUPGrZFmr24TgCUwx+Y7lFdtxCX3St6DnQ FX/YkU6p5iX5/2+V1AG8tPMy/utxjKzOfWYVBE3vUGNyXXn49CQ= =cE5B -----END PGP SIGNATURE----- --ZsKpzxtmBfIDNFEP--