Date: Tue, 11 Apr 2023 09:53:00 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Thom Brown <thom@linux.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Various typo fixes
Message-ID: <ZDV0TG+YlnBpmpRD@telsasoft.com>
References: 
 <CAA-aLv7xCZ0nBJa-NWe0rxBB28TjFjS2JtjiZMoQ+0wsugG+hQ@mail.gmail.com>
 <ZDVxDZPMjN0LKPtd@telsasoft.com>
 <CAA-aLv6D9mAui-Lh1yZaL_kACiKhuK6j0PKm_Setndb9JW+TRQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAA-aLv6D9mAui-Lh1yZaL_kACiKhuK6j0PKm_Setndb9JW+TRQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ZDV0TG%2BYlnBpmpRD%40telsasoft.com>
Precedence: bulk

On Tue, Apr 11, 2023 at 03:43:12PM +0100, Thom Brown wrote:
> On Tue, 11 Apr 2023 at 15:39, Justin Pryzby <pryzby@telsasoft.com> wrote:
> >
> > On Tue, Apr 11, 2023 at 03:36:02PM +0100, Thom Brown wrote:
> > > I've attached a patch with a few typo and grammatical fixes.
> >
> > I think you actually sent the "git-diff" manpage :(
> 
> Oh dear, well that's a first.  Thanks for pointing out.

Thanks.  I think these are all new in v16, right ?

I noticed some of these too - I'll send a patch pretty soon.

|+++ b/doc/src/sgml/logicaldecoding.sgml
|@@ -326,11 +326,11 @@ postgres=# select * from pg_logical_slot_get_changes('regression_slot', NULL, NU
|      connection is alive (for example a node restart would break it). Then, the
|      primary may delete system catalog rows that could be needed by the logical
|      decoding on the standby (as it does not know about the catalog_xmin on the
|-     standby). Existing logical slots on standby also get invalidated if wal_level
|-     on primary is reduced to less than 'logical'. This is done as soon as the
|-     standby detects such a change in the WAL stream. It means, that for walsenders
|-     that are lagging (if any), some WAL records up to the wal_level parameter change
|-     on the primary won't be decoded.
|+     standby). Existing logical slots on standby also get invalidated if
|+     <varname>wal_level</varname> on the primary is reduced to less than 'logical'.
|+     This is done as soon as the standby detects such a change in the WAL stream.
|+     It means that, for walsenders which are lagging (if any), some WAL records up
|+     to the wal_level parameter change on the primary won't be decoded.
|     </para>

I think "logical" should be a <literal> here.