Date: Tue, 11 Apr 2023 22:44:43 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Daniel Gustafsson <daniel@yesql.se>, Thom Brown <thom@linux.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Various typo fixes
Message-ID: <ZDYpK5cWZdz7fiD1@telsasoft.com>
References: 
 <CAA-aLv7xCZ0nBJa-NWe0rxBB28TjFjS2JtjiZMoQ+0wsugG+hQ@mail.gmail.com>
 <ZDVxDZPMjN0LKPtd@telsasoft.com>
 <CAA-aLv6D9mAui-Lh1yZaL_kACiKhuK6j0PKm_Setndb9JW+TRQ@mail.gmail.com>
 <ZDV0TG+YlnBpmpRD@telsasoft.com>
 <DB4ECFAE-5AA6-4447-9716-5D76A7791EF7@yesql.se>
 <ZDYlWcycBimwEtuU@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZDYlWcycBimwEtuU@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/ZDYpK5cWZdz7fiD1%40telsasoft.com>
Precedence: bulk

On Wed, Apr 12, 2023 at 12:28:25PM +0900, Michael Paquier wrote:
> On Tue, Apr 11, 2023 at 11:12:58PM +0200, Daniel Gustafsson wrote:
> > > On 11 Apr 2023, at 16:53, Justin Pryzby <pryzby@telsasoft.com> wrote:
> > 
> > > I think "logical" should be a <literal> here.
> > 
> > Agree, it should in order to be consistent.
> 
> Indeed.
> 
> +     to the wal_level parameter change on the primary won't be decoded.
> 
> This wal_level should also have a markup.
> 
>         Number of uses of logical slots in this database that have been
> -       canceled due to old snapshots or a too low <xref linkend="guc-wal-level"/>
> +       canceled due to old snapshots or too low a <xref linkend="guc-wal-level"/>
> 
> This sounds a bit strange to me.  A too low wal_level would be a cause
> for a cancel, hence shouldn't this be "canceled due to old snapshots
> or due to a too low guc-wal-level?

That's the same as the original language which Thom and I are requesting
to change, (but you added another "due to").

"a too low" is poor english.  It's good enough for a code comment, but
this is a user-facing doc.

It could be "an inadequate wal-level" or "a prohibitively low
wal-level", but Thom's language is better.  "too low a wal-level" means
the same thing as "too low of a wal-level" (which would also be fine).

-- 
Justin