Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pmbv4-0007hy-Li for pgsql-hackers@arkaria.postgresql.org; Wed, 12 Apr 2023 14:57:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pmbv3-0008U4-Gf for pgsql-hackers@arkaria.postgresql.org; Wed, 12 Apr 2023 14:57:57 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pmbv3-0008Ti-2i for pgsql-hackers@lists.postgresql.org; Wed, 12 Apr 2023 14:57:57 +0000 Received: from mail-il1-x12b.google.com ([2607:f8b0:4864:20::12b]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1pmbv0-002SX4-EQ for pgsql-hackers@postgresql.org; Wed, 12 Apr 2023 14:57:56 +0000 Received: by mail-il1-x12b.google.com with SMTP id r19so5902976ilh.8 for ; Wed, 12 Apr 2023 07:57:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20210112.gappssmtp.com; s=20210112; t=1681311472; x=1683903472; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Cq5UPGZgHpTirxMUITnF4IkbZJs+VtN3ujwKgIQnp2U=; b=7OkGhhx4tJ05iE/3ColxiAhHetn0MtbvT1blEGEPFm6tGtKhACrrzLLH1qvIvSnurh gFKrnxafRpg4zACAR45+QJhFVhVHZ5ByDks4QnvvVP7oT0amNziPnKqsdH5MUA+rk7x/ pSaSzIdAPhV3kifFS3buqg90EgTityypf/kt8dszMCYcPNpa7Sd7Rlnq6Y4YMx0zAjwT Zst8zXHXu2ShM4za4IKXiYo2eVFg8mKCkpcUA0AYgHTpsTzeDMNzjBOvSnpu/rSyHx0y 2XrHHGeQZe9N5gyo2nam6w70XPh4LaGvphzvq0avMzvNy5/mOaK1KfsGnA489Z6c1nsT C7QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681311472; x=1683903472; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Cq5UPGZgHpTirxMUITnF4IkbZJs+VtN3ujwKgIQnp2U=; b=7WnDvnb2PBT3IFXOqEhw+52Q27ovYVLULpzL1QcyTrXdyU5z3clHbOl1YFtb8NC0wO lTepa4ulHt7TO8G35zDJryDOeH1I5qHlUq2f2tdh4HNLUxmH347y994FthMoG+B+n//N 0/EbTbrE3wfL6DEsUv23vYbZFyWRcpAiYQTKPLwOq7P1sBTgPH/JYLcmi34JIMsaDOzA rtinmP1YPwdnaJSUF456L8mqclK7aRwQBz3vfGDzcU+taMWiWFjO3KISHCDbFaB2gGDP XMBt+sLTidY1PPjZl4cO3opUrMu5yFfUbthPxaeI07Ohu5Ek2DGmtaSk7551rEoxmCfK WYEQ== X-Gm-Message-State: AAQBX9eZQUwghVfLozXKCycEPTyhV3tDOe2rvyP5L5xV45OPBL+v/aLJ ZOVvSHfYUpbyij4AtTRrNl7YtQ== X-Google-Smtp-Source: AKy350YmosNlUvrqO7+ZGd++oiedx4L2eGSbEC9obMCQCrA/x4iLST94jU8N3gUnusLWR8oXV9uQEw== X-Received: by 2002:a92:d9c7:0:b0:326:2b56:3cf5 with SMTP id n7-20020a92d9c7000000b003262b563cf5mr9631084ilq.22.1681311472515; Wed, 12 Apr 2023 07:57:52 -0700 (PDT) Received: from pryzbyj.telsasoft (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id f9-20020a056e020c6900b00315327197d4sm2757469ilj.23.2023.04.12.07.57.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Apr 2023 07:57:52 -0700 (PDT) Received: by pryzbyj.telsasoft (Postfix, from userid 1000) id 36910800E9A; Wed, 12 Apr 2023 09:57:51 -0500 (CDT) Date: Wed, 12 Apr 2023 09:57:51 -0500 From: Justin Pryzby To: Robert Haas Cc: Thomas Munro , pgsql-hackers@postgresql.org, Peter Eisentraut Subject: Re: refactoring basebackup.c Message-ID: References: <20220312015253.zokhkwdn5xbbd4vf@alap3.anarazel.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Fri, Mar 24, 2023 at 10:46:37AM -0400, Robert Haas wrote: > On Thu, Mar 23, 2023 at 4:11 PM Robert Haas wrote: > > On Wed, Mar 22, 2023 at 10:09 PM Thomas Munro wrote: > > > > BaseBackupSync is not documented > > > > BaseBackupWrite is not documented > > > > > > [Resending with trimmed CC: list, because the mailing list told me to > > > due to a blocked account, sorry if you already got the above.] > > > > Bummer. I'll write a patch to fix that tomorrow, unless somebody beats me to it. > > Here's a patch for that, and a patch to add the missing error check > Peter noticed. I think these maybe got forgotten ?