Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 13 Apr 2023 07:23:48 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>, gkokolatos@pm.me,
	shiy.fnst@fujitsu.com, pgsql-hackers@lists.postgresql.org,
	Rachel Heaton <rachelmheaton@gmail.com>
Subject: Re: Add LZ4 compression in pg_dump
Message-ID: <ZDcvdPVVi22mXPfR@paquier.xyz>
References: 
 <qRJGr1JjK3B_pbOxyGqI0iGJWEcRxnq9c7_mIqTY1CIIvYMY0hamPIrvjuS-6gyjr_ItOG8SLRacF1oj7d8R4QKHfZp85YTHI9B-U6LSLAQ=@pm.me>
 <qSzzmYsXqUf1gDvFspOEbqoE8U_F8IsphDG8c25VZ5KTXimQVYfLvnCcuU7_X2raa2SzZinDF0NpDIKSOALRUYP8pu_NL5QJwIDdR_RT-4U=@pm.me>
 <8ffd14fe-0278-7f8d-78d4-472816d06268@enterprisedb.com>
 <ZDX+J72FYmJhH+fC@telsasoft.com>
 <ZDYEPDbFAua+4hlr@paquier.xyz>
 <ZDYHP4SvY2eejTj/@telsasoft.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="UFXkd3FBcCQ8Oqsm"
Content-Disposition: inline
In-Reply-To: <ZDYHP4SvY2eejTj/@telsasoft.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ZDcvdPVVi22mXPfR%40paquier.xyz>
Precedence: bulk


--UFXkd3FBcCQ8Oqsm
Content-Type: multipart/mixed; boundary="/LXAByhyS41ROdHY"
Content-Disposition: inline


--/LXAByhyS41ROdHY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 11, 2023 at 08:19:59PM -0500, Justin Pryzby wrote:
> On Wed, Apr 12, 2023 at 10:07:08AM +0900, Michael Paquier wrote:
>> Yes, this comment gives no value as it stands.  I would be tempted to
>> follow the suggestion to group the whole code block in a single ifdef,
>> including the check, and remove this comment.  Like the attached
>> perhaps?
>=20
> +1

Let me try this one again, as the previous patch would cause a warning
under --without:-zlib as user_compression_defined would be unused.  We
could do something like the attached instead.  It means doing twice
parse_compress_specification() for the non-zlib path, still we are
already doing so for the zlib path.

If there are other ideas, feel free.
--
Michael

--/LXAByhyS41ROdHY
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="pgdump-comment-2.patch"
Content-Transfer-Encoding: quoted-printable

diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
index 967ced4eed..596f64ed2c 100644
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -751,17 +751,21 @@ main(int argc, char **argv)
=20
 	/*
 	 * Custom and directory formats are compressed by default with gzip when
-	 * available, not the others.
+	 * available if no compression specification has been specified, not the
+	 * others.
 	 */
-	if ((archiveFormat =3D=3D archCustom || archiveFormat =3D=3D archDirector=
y) &&
-		!user_compression_defined)
+	if (!user_compression_defined)
 	{
+		if (archiveFormat =3D=3D archCustom || archiveFormat =3D=3D archDirector=
y)
+		{
 #ifdef HAVE_LIBZ
-		parse_compress_specification(PG_COMPRESSION_GZIP, NULL,
-									 &compression_spec);
+			parse_compress_specification(PG_COMPRESSION_GZIP, NULL,
+										 &compression_spec);
 #else
-		/* Nothing to do in the default case */
+			parse_compress_specification(PG_COMPRESSION_NONE, NULL,
+										 &compression_spec);
 #endif
+		}
 	}
=20
 	/*

--/LXAByhyS41ROdHY--

--UFXkd3FBcCQ8Oqsm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmQ3L3QACgkQnvQgOdby
QH09Hg/+Ptyv265JCZlnwJLY/pUKlzPPwBTzYo4b8uvgUuDz/HQ9SHsD/Xc2c1yF
BPpMFYD63fWP316pv9YeL95f+kqjKaQWg88wTnnrGCAogJMc5Q1HZlVFIa9i0R+z
cxsoxZDKyAg8bq3pUahejFuc4JdTaZspO5zVePyJGeA6aQ2RFrY7t2AXulduATrf
f7gtSPeZT8eLbrYluWsR/A1d5BqBshC5LfyJthonNOr4LMS1bKvTrznKpzxDHXz7
B/7w7oxcUw+KybiDybKev7MZnY7AGnshAPakHYHlhSreWQuZIfszTvyAmrdHd1xH
gdKoPDkju5yHJFv9Mhw3cg80IC0B8Xpar7vKUWXHygMUPtuujgyZ01k6MAB62H8x
T78VuB6tdXi0yMVjzuLF9tvz5prIOh+LQ/ypXN/ENmEPF11/aALS/G7EUo9r3r4J
NRyYZFyqwLGkOGCb42MTNiTrPsyVjH7TUpc+aItL0hoZLB4IjM9tJIdcTOkBLmdg
qhneaNRMQNLw1xsW8VRRC5fG6Rz6WFSJznVIlSS2sxRJgzDQlhsRCdjW1/rtTi/f
cR2c9Y4kbAd7DUBmcwJWlIe6iURZYKvZLrgV1ZOn8wcYpQC9ph6Hm2ZYxl0NqmGj
1tfb5B9+E2E4f20y2r3HXnWllv+vElOc2MHdFbCVFzqc6vMmk5g=
=OhrO
-----END PGP SIGNATURE-----

--UFXkd3FBcCQ8Oqsm--