Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 13 Apr 2023 09:37:06 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>, gkokolatos@pm.me,
	shiy.fnst@fujitsu.com, pgsql-hackers@lists.postgresql.org,
	Rachel Heaton <rachelmheaton@gmail.com>
Subject: Re: Add LZ4 compression in pg_dump
Message-ID: <ZDdOstf12KHSarmS@paquier.xyz>
References: 
 <qRJGr1JjK3B_pbOxyGqI0iGJWEcRxnq9c7_mIqTY1CIIvYMY0hamPIrvjuS-6gyjr_ItOG8SLRacF1oj7d8R4QKHfZp85YTHI9B-U6LSLAQ=@pm.me>
 <qSzzmYsXqUf1gDvFspOEbqoE8U_F8IsphDG8c25VZ5KTXimQVYfLvnCcuU7_X2raa2SzZinDF0NpDIKSOALRUYP8pu_NL5QJwIDdR_RT-4U=@pm.me>
 <8ffd14fe-0278-7f8d-78d4-472816d06268@enterprisedb.com>
 <ZDX+J72FYmJhH+fC@telsasoft.com>
 <ZDYEPDbFAua+4hlr@paquier.xyz>
 <ZDYHP4SvY2eejTj/@telsasoft.com>
 <ZDcvdPVVi22mXPfR@paquier.xyz>
 <ZDc2OBeMYbhmDEYl@telsasoft.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="8jI02M6KlfNAjKQz"
Content-Disposition: inline
In-Reply-To: <ZDc2OBeMYbhmDEYl@telsasoft.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ZDdOstf12KHSarmS%40paquier.xyz>
Precedence: bulk


--8jI02M6KlfNAjKQz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 12, 2023 at 05:52:40PM -0500, Justin Pryzby wrote:
> I don't think you need to call parse_compress_specification(NONE).
> As you wrote it, if zlib is unavailable, there's no parse(NONE) call,
> even for directory and custom formats.  And there's no parse(NONE) call
> for plan format when zlib is available.

Yeah, that's not necessary, but I was wondering if it made the code a
bit cleaner, or else the non-zlib path would rely on the default
compression method string.

> The old way had preprocessor #if around both the "if" and "else" - is
> that what you meant?
>=20
> If you don't insist on calling parse(NONE), the only change is to remove
> the empty #else, which was my original patch.

Removing the empty else has as problem to create an empty if block,
which could be itself a cause of warnings?

> If I were to rewrite the comment, it'd say:
>=20
> +        * When gzip is available, custom and directory formats are compr=
essed by
> +        * default

Okay.
--
Michael

--8jI02M6KlfNAjKQz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmQ3TrIACgkQnvQgOdby
QH1k4BAAiZun8Ys1z6wS2hsdOv7F5IeaUwFS6DwdkL6pP5Qa/oRqzOTfQp/q9na5
DpHgALBoNGvtLhDmN92dnQtFh82UXgZ9rGjq3oQ+tP8hpDFCzR6au18gR2TCYWsf
D1bAbv6SJB6nSp6pFmM1JdBCmRhlKnmxic7sPkf8i5Kp5u+6cEhYGa6T1I3FmjDb
/rW0OaASPXgDZnwW5kRRnTNQg2ymwI9K39EybqxIe0ffrFseRnhkx91YwbdcLgmM
qd95KRzp+NicvJWPITGxI+ghqGKx0i3NE2/No0CCTAV7o7rh9LTeJxRNOCumMofM
SlH4XddV/5xd1i2en64lSPZlrkZR/NVAVP6w630RfZNVqyP9XGSFfeuQd9f9GVQD
eCw82ackuYdvTK30DpZCe4RfcsY7ljnISdmVmP9YBIZxXVsjvK6Lcup9cn9vV5UN
yJxtFillnpOfQXQDpRk0T1V072wf9FkBpL2MtvQnKHmC1W6NTJ0W8gU81WKc7Pdq
SWXZdV0I40GrdqrofR+6jRaJQ7PFT8PqJzMMBaoJG5jqxy//oFL03KHypQVxN+Fx
CATLAihV6VRkJmcAfNTO+PyWPeAXvodDKEHf49ZKOhgaPu1Vn16VbOn/3dELjlKr
wamohISrADLehn6AK+dnQTvmgKp7B/mOnEDZRkWWg9/2W/u0Ifk=
=vd/J
-----END PGP SIGNATURE-----

--8jI02M6KlfNAjKQz--