Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pq8r0-0007qg-Rf for pgsql-hackers@arkaria.postgresql.org; Sat, 22 Apr 2023 08:44:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pq8qz-0003WN-Ix for pgsql-hackers@arkaria.postgresql.org; Sat, 22 Apr 2023 08:44:21 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pq8qz-0003WE-8x for pgsql-hackers@lists.postgresql.org; Sat, 22 Apr 2023 08:44:21 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pq8qx-004Opq-Iq for pgsql-hackers@postgresql.org; Sat, 22 Apr 2023 08:44:20 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 413165C0094; Sat, 22 Apr 2023 04:44:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 22 Apr 2023 04:44:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1682153058; x=1682239458; bh=Bz w/KsdissOo39orjTgzfQu5gbVt4ktDb77jczmTmqc=; b=SxdpEAIUw4BFm1tuQ4 cSSd5+J+yt93eIOnez2mgVwk6WxPkSoZj3jmYNm8dHw2sSY/VQgFY6syl9xCwtLV 68ohjpzudQLkC0OS1rPIeTWs7wtdbfFlijshjBba0xRqNf1LYRvO3To7EHS84924 hq3w6xPDuBlmkuWFSWi72x4pOWByZTT62fC5d09yt8DR/aeapOJNj5cIYwZK+Iih KYtWxIW+xMsN6o+j/SVm2r0xqMg68++eHjBkFtiWhWjVS/ssGYCGk0aFIJkhoXJ0 nZqnXWf6/kpWBFs1N8gEOr3hOghspCheJasjXt3BCYfvK78ZXPa7RggptHFFLafx ebRg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1682153058; x=1682239458; bh=Bzw/KsdissOo3 9orjTgzfQu5gbVt4ktDb77jczmTmqc=; b=U4GRc9cZNhlEz+pUB7Hv17nrTe5Wu tHb/61jQZWAxeM6t/ctSsem3EKdhLaN0EqVtTSmZ8m+Y/l1wq0X3SNBQrgjwsNFe CL5av6ftSotGPdMAOUlVmiJm781esAJdd7IPLb1fMCjZhhrfZ0HIQcK6aHSBIR/I D9ivfptRKpcRe+xRtjkk8O1LN0gRluX6pW+bczlE3qgBga1XVDUl55KDqbsmbqFd UhQJXz2PvvvKpFsY/uLbE2mQqhp1X7imqdi7A2R5hQZObd+xizRmgAEPXBjTC+3Y HLtaNmMsah82b9upd3AeMnqAqmAtGUA1WivKmJxMv77DleimyWdoay7ZA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedtiedgtdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucgfrhhlucfvnfffucdljedtmdenucfjughrpeffhf fvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpefoihgthhgrvghlucfrrghq uhhivghruceomhhitghhrggvlhesphgrqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvg hrnhepveetjefgjeevgedukeehieeuieeuieevueeiudegheevuefggfduueelgeelieet necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhitg hhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 22 Apr 2023 04:44:16 -0400 (EDT) Date: Sat, 22 Apr 2023 17:44:13 +0900 From: Michael Paquier To: Legs Mansion <1027644833@qq.com> Cc: pgsql-hackers Subject: Re: A Question about InvokeObjectPostAlterHook Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="OD7AXzcf6bqHtMTZ" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --OD7AXzcf6bqHtMTZ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 21, 2023 at 04:16:10PM +0800, Legs Mansion wrote: > actually, some location can be tricky to add. > it looks like CREATE, but it=E2=80=99s actually ALTER, should call > InvokeObjectPostAlterHook instead > of InvokeObjectPostCreateHook? eg.,CREATE OR REPLACE, CREATE > TYPE(perfecting shell type)=20 Sure, it could be possible to plaster more of these depending on the control one may want with OATs. Coming back to the main you point of the thread you were making, what are the use cases with ALTER TABLE you were interested in for sepgsql on top of what the patch I sent upthread is doing? Note that it is perfectly fine to do the changes incrementally, though I'd rather add some proper coverage for each one of them using the module I've patched (sepgsql's tests are annoying to setup and run). -- Michael --OD7AXzcf6bqHtMTZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmRDnl0ACgkQnvQgOdby QH2WVg//as4Z6cl/MN4o3Nm1lchXCw56Z4M/wb5GfYi7fD3PXJ6IvRC3AzcnqvDG 95QedtX0QP9Bw5vO+1G5ClJhdVf3v3ge5PvafggKRg7txPakDx90u93zSx9CJ/qR STFgeoEnbBtMbvixaA6+nH6sVnzwc2/5DYyZBZIryn2c9HkHyzXqYxayQm1ZI1UL RXkhXkoM48owPO8mSnc2RgSzDzre1d7GEulsnsyfNg8coXqZ+9Unc/pGg22BRp9/ Q4coZQOCxfunyzUazOwEDxSOzVnaXb3/6hAB7yPHKDAyaOVVO5yHgGzIgyPYoTLa ylRywX1Z/FN+DbTI77tm/MONWeLvIhh1Zc90tlbxY2u8T+xciGHz5vtzTpBM0Esa NyCWiPJs4tIqRPtnwGM/RNOkrK0eLCDEuC2gH+QsE//1JQBgw3UlPAXetJlvjKX9 dMrLrx0rgsZRWfdqypxhBot8eYIUh/ZS9XokyBTm1l93pm5aAnl8H579UtXJmhQH dQQbiU7X3hh+KPFxk8BxyiOD2LiRt1qkrK9gZ+ib0dUimekwpO6gOlo5BN+REzb+ fZA0dWb6T5jaPsGD20oLPimCNeRRlzToP1TmVN0MN56WhevTxVykpcieoRz1vq0X jqGNUKjYwT3NfVvKRTJEBHZXjJdVWNgKvjHKL2i0Rfx9Zwd2Ex4= =c7tE -----END PGP SIGNATURE----- --OD7AXzcf6bqHtMTZ--