Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pr7WG-0004De-Q1 for pgsql-hackers@arkaria.postgresql.org; Tue, 25 Apr 2023 01:31:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pr7WF-0002N2-MG for pgsql-hackers@arkaria.postgresql.org; Tue, 25 Apr 2023 01:30:59 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pr7WE-0002MM-6J for pgsql-hackers@lists.postgresql.org; Tue, 25 Apr 2023 01:30:59 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pr7WA-004tk3-IW for pgsql-hackers@postgresql.org; Tue, 25 Apr 2023 01:30:57 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id E9FDA5C0106; Mon, 24 Apr 2023 21:30:50 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 24 Apr 2023 21:30:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1682386250; x=1682472650; bh=N4 FrEc7TUDfdCGyjHVbptIbF9PLjBriZmyELtXzHwks=; b=zP5/zCWoLvAQM+iMG5 FqXH5lXRY+jn2FsmAY9EM1eMYB2ZmxgCQY+BgMUW6P02BtMG8RBXeGMFU2sMXVqa W/GRWe5zXElNfi3L4Rb4p76KSRt7YBTz4vGeGOxx8WoXu7oQVARmyFzefzUjt1AZ r7jcTYv6KNTvCnkybnmZsa5zmliRRokdysHjJRNj40dCfXP180PF1Nl7zEOVb5L1 GMPytrDPH7ENmY99WutSxhl2+P6o+gtuMQnmVUt85o2D9ZKRw0bTEeR1Ru2AvFFf GLkSAQrEqjCyMl0Zvg3gAuntKAXANANiWB6dema0LD+JF0glHxCItrCn9SAoGc5q 4SaA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1682386250; x=1682472650; bh=N4FrEc7TUDfdC GyjHVbptIbF9PLjBriZmyELtXzHwks=; b=cUe0mN7AMvj8tnRk9sAeBEFlWzhBR ORwEumewRD9GjHmokUqEez6qje0mBWZqtLveGi+2fURivwBHoxg3kiQLIo6JSX4g wgGbBVPonmGSHndDHJknqOL1jWoSvRI0nbaaB1WcjzonO+A7D8FrMOw3wuqEkqZx q7t1Y61vurCidmAhBBBtvzFJ/ZefzF1dCWhtLxq8CThQb9cGH2L0y2/WfLXBi5JN I14jDzRRCFEtP5TTbyrFjwjwX/PSqfrQ3tXdP85+J/Xft3nn3prmrpXV0KBS5t1R vnSxKWoJlFauafGjr2LM6AKrKDsN255iDX2F+FljSUnhJzuabbE+lFk6g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeduuddggeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 24 Apr 2023 21:30:48 -0400 (EDT) Date: Tue, 25 Apr 2023 10:30:42 +0900 From: Michael Paquier To: Alexander Pyhalov Cc: pgsql-hackers@postgresql.org Subject: Re: buffer refcount leak in foreign batch insert code Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="NAsfsgCDPuTAi9GU" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --NAsfsgCDPuTAi9GU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 24, 2023 at 09:57:10AM +0900, Michael Paquier wrote: > The attached is what I am finishing with, with a minimal regression > test added to postgres_fdw. Two partitions are enough. Well, I have gone through that again this morning, and applied the fix down to 14. The buildfarm is digesting it fine. -- Michael --NAsfsgCDPuTAi9GU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmRHLUIACgkQnvQgOdby QH3scxAAkZgHbygvjAnu682hWGY0Zk/18omcg58SuZi2PqamDlAL+3Bv7+Ke87od X0i73nkktQ1WhWUbHMM6RtvVqUYHRVs55ZO0R82ZqdhAX7uzKd0vU+q3EQqFF0Lw IEjcYkQmObSj1nQasx9VUkGJ17sXbkasWiJhTNK40kiQlakXNBNuV/DFwPDMlWP3 UPa1W9pYCB7hBC5vMCtfuEymSnN7sXtPLKh7e1u0jEUL9+nqPZKxKrhjON3+DWKv Od2hCndm62fVrtndOF0wTtQou4WbT1hp4X/SvXMpFLquqdzQrBv06IVHui3N8mvF 7uATAXzbMFtcR2UXeWycP89WtE0rCkGlVe7DDmUT+ivs0rLdiXqNi1aqEYJnF3Oq IvKU1d0nzoQyCDRc2JxluqQyDNHrLvv1Hzd23/hWbhEjeyeDUUYpWOj6wt85wufX OKxofV9SoqOJBrJj29prvvxL8/jBBj3aclC89JyEaVJyxPwgs9uu0Xr5ohJM4IhY RyL0o4T2ttDfMKrsyg/MUIizgNxdSOJ2Ite6yG5bpshaxXDxWrmlae+zSY+F+ReB qGaQBVZ+FACbKCgRuxj4emCQlyOBE9cGZOU5FylMEJpSzVHdzHxF71CgOPr6ohMc iMfL0qxEe9ma9m2MMrwGoBP22Ie+80l5FwrQE7osb0jRQkN5OUM= =e3Hd -----END PGP SIGNATURE----- --NAsfsgCDPuTAi9GU--