Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1prv1A-0004QJ-9q for pgsql-hackers@arkaria.postgresql.org; Thu, 27 Apr 2023 06:22:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1prv19-0001sk-53 for pgsql-hackers@arkaria.postgresql.org; Thu, 27 Apr 2023 06:22:11 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1prv18-0001rw-RU for pgsql-hackers@lists.postgresql.org; Thu, 27 Apr 2023 06:22:10 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1prv16-005KCg-Bo for pgsql-hackers@postgresql.org; Thu, 27 Apr 2023 06:22:10 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 564D65C011D; Thu, 27 Apr 2023 02:22:07 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 27 Apr 2023 02:22:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1682576527; x=1682662927; bh=Po CQ+gqxSgXRsJfU3/lAc0N/bRdMdvv6sSnXJWtl19I=; b=xti2cOzO/Dk8ZUCAIy 4Uaih+TcWDo4QGXzzyGiBdMw6sYW+LoQMS2CP1Xv9x2KC7lh5reboI4QKrbYTkjn NYi5DUoKfkKZLdCO+cZtaeVzTRZi3oLZD50psXJh+N6Ls1abck0sijjfbTMhrz8l w+7SC8J6koqFHjqEyjq6rMR27wkYntPv9DLj7YK58KyJz8p11+Wy5pDP8XLhV5he XLHli5XPMZkybLA7pvp4gYOZqw49uUsp94oYN71VT/z/5Q6+1SZUK3sFZA8gMdwI ILRjSUWGoMlm+76zbGqfPsesHJGrypQiCDAIjlHk+NuSbRkj7Umens0uvZqP9R5W vnMw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1682576527; x=1682662927; bh=PoCQ+gqxSgXRs JfU3/lAc0N/bRdMdvv6sSnXJWtl19I=; b=QKTwG4E5X6MLKrUHFMdGnj1My3DpE e8gwrWwOFgZIKGK4lh2lW+eXhzzo7hwIgsbQmY2+HcvdeUC3W3gGHsy4w5NHYX1U Q7+p6QpICcWxHw+9CwMGzQJTNWrHr0eLQJT5qnpqn54Ba/ZQ6yI4yBwxZ450t1rn WO18GZTgiLjwdfiDit8lODkUPzCblz/20dGnBVcMjQmE/aLyy05Fv2fYaftk9SmG o+n4GceAv72i5H/4s2s0ounEN6EejhEm8Shzw7T1bmKyOd/s6vVP0Gug83Khy1vl fCYqdbn5Ai/mrF8EiWxKxBq3qs85wCSihkAvCCQF7QYcnYLFnM/3efx0Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeduhedguddtjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecufghrlhcuvffnffculdejtddmnecujfgurhepff fhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcurfgr qhhuihgvrhcuoehmihgthhgrvghlsehprghquhhivghrrdighiiiqeenucggtffrrghtth gvrhhnpeetleeifedufffhhfdtteelgeeggeffhfekueevteeigfduudevudetgfegiedv jeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmih gthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 27 Apr 2023 02:22:05 -0400 (EDT) Date: Thu, 27 Apr 2023 15:22:02 +0900 From: Michael Paquier To: Bharath Rupireddy Cc: Kyotaro Horiguchi , andres@anarazel.de, pgsql-hackers@postgresql.org Subject: Re: pg_recvlogical prints bogus error when interrupted Message-ID: References: <20221019213953.htdtzikf4f45ywil@awork3.anarazel.de> <20221021.112158.570945868472438027.horikyota.ntt@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="K9Yt44kxd4lQlNCz" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --K9Yt44kxd4lQlNCz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 27, 2023 at 11:24:52AM +0530, Bharath Rupireddy wrote: > IMO, +1 for HEAD/PG16 and +0.5 for backpatching as it may not be so > critical to backpatch all the way down. What may happen without this > patch is that the output file isn't fsync-ed upon SIGINT/SIGTERM. > Well, is it a critical issue on production servers? It is also true that it's been this way for years with basically nobody complaining outside this thread. So there is also an argument about leaving v16 out of the picture, and do that only in 17~ to avoid playing with the branch stability more than necessary? I see 7 open items as of today, and there are TAP tests linked to pg_recvlogical. That should be OK, because none of these tests rely on specific signals, but the buildfarm has some weird setups, as well.. -- Michael --K9Yt44kxd4lQlNCz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmRKFIoACgkQnvQgOdby QH0tuA//Q7wlPbvVyvVKaL+Ot6EKabolH3hGKzL+E4b//93hIHU4LmGdBhP3kFWk XpT2gFU6j/5WyIr9FcPKZe9Lf9Ag1A2RwGmRkqvvHHOLc4tp7ZNBkwGOsg3pHUhO PscDZaRCl7OQajEK3NOwnWGJWf3nOhaNA+7ZSXPJXzy5aupw9cTJi+6XzNIut6j6 v+IrGcfG7eb2Zh2fnLRcHZ5eCCMdAAbODHMYl4DzcqSCpFTup5D+ZVJZXUB+Lpbp JAqZseqV70KWrYMsyGNMADB/t0jy7goaveb98dCq9TOd5qIGpkWQvKu6utpJVVt/ Gwha/iQNynN1Q24nBT7WJ9I6xIO9nP7DefC5iATguUOFFTqUL7dv55a0erIE0P5w u1OJl8sAkYw3+pns/x8FVcs+juzFsCuTVj6AbzFHgSzGI7bOiz95W0YTRY8BR1q+ cSFaFsTVaurp2IEf0NE4QPigahl9o8ayIu6j1A5fTfcdIyC31VUbFE46YLd5aX8L gdSzlDmbWNZDrT67kGVbk//WEqq9c9KXTyjjBeywZa7hIYW7bRofIqbAwXgT9GJa 7N/pApzMRM647B8t6qXUQntlzEK+uV8jIM4p1K3K0Ygo7chGypdTZT5T3CqTPbNA Rq0rOVACfMzNBqU9fxwfzIHtQZlo+FMjeGD6flRd8uUT8zZQe4A= =Zvbq -----END PGP SIGNATURE----- --K9Yt44kxd4lQlNCz--