Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ptfai-0006UG-Ny for pgsql-hackers@arkaria.postgresql.org; Tue, 02 May 2023 02:18:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ptfah-0004jr-I5 for pgsql-hackers@arkaria.postgresql.org; Tue, 02 May 2023 02:18:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ptfah-0004ji-8R for pgsql-hackers@lists.postgresql.org; Tue, 02 May 2023 02:18:07 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ptfad-0002rc-WA for pgsql-hackers@postgresql.org; Tue, 02 May 2023 02:18:06 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id B360D320092F; Mon, 1 May 2023 22:18:00 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 01 May 2023 22:18:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1682993880; x=1683080280; bh=PL FkAABHvhGf6okFiui6Im2ShFLl9z/xj2jc5xpdfMg=; b=G4kX7M/HZU2EkEDtR5 Y5p+ikIHk0rEYPVC4LRl9Fh3QCy1gkPtWUNP7FcOsjrte+aT5/TEtqKvjkySWy3f lcHYfqfut/Ha7Baall1jX0Q+klrkL+iVuOOrhAG0YXWi9xyi1CjKdZm1o9A7jGkD vp8u5MEA9xDNVRCSfWTfSOq2R8Y/BG7YiKCyZP+P4DsYuCVQJ9ZrUG+OQKytZ22I Ms3+vCISXrNT9KisVq7dHsVLnfNzzEJzoUGF7ZAhegZOl4yD2cKhqqsbE/jpFIcg inc00jA1vDbmWhjWuq6/N9Yhjor2UGM3R10SsWH3XSOYR71VPIYXzMvc6gmXWmk3 E/Pg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1682993880; x=1683080280; bh=PLFkAABHvhGf6 okFiui6Im2ShFLl9z/xj2jc5xpdfMg=; b=HWUhTy7E6qt1dbDmaYyAW6Weocf0o jxo54ok6PEBk2+keLlffOaka3s0rPa3svEqR676TS9g+EYfy33ou9yF/zINwEC/c r4BiPEkMqRWEiB7qm1nLFCfK7WhM7ao1IGu0Pyi+ew7EJKCpnVp2DjNQdu/Pi9lB XeWeE/LdKzFGjm3VcvkKbLn2/W/sSmGUWrjtcncuXUJhSyYAYsMOyS72h4x2d3ed z7GCG9zXd2voGT8MWihk4LPON9/+ZVa2yxIjqjq1HmEG8m3px/tyS+qv+0TCEACc SMsbDT5Tn+Qn0hznAEViQNcXSvTE4qpo43oYdoKF/NBC3Y/TY7pZLU7Mw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedvhedgheejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 1 May 2023 22:17:53 -0400 (EDT) Date: Tue, 2 May 2023 11:17:50 +0900 From: Michael Paquier To: Nathan Bossart Cc: Justin Pryzby , Kyotaro Horiguchi , sfrost@snowman.net, alvherre@alvh.no-ip.org, andres@anarazel.de, jchampion@timescale.com, john.naylor@enterprisedb.com, masao.fujii@oss.nttdata.com, noriyoshi.shinoda@hpe.com, pgsql-hackers@postgresql.org, rjuju123@gmail.com, sawada.mshk@gmail.com, tgl@sss.pgh.pa.us, thomas.munro@gmail.com Subject: Re: Improve logging when using Huge Pages Message-ID: References: <20230420211617.GA1435672@nathanxps13> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qnY65OJI8RcHfEP7" Content-Disposition: inline In-Reply-To: <20230420211617.GA1435672@nathanxps13> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --qnY65OJI8RcHfEP7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 20, 2023 at 02:16:17PM -0700, Nathan Bossart wrote: > AFAICT this would involve adding a bool to BackendParameters and using it > in save_backend_variables() and restore_backend_variables(), which is an > additional 3 lines of code. That doesn't sound too bad to me, but perhaps > I am missing something. Appending more information to BackendParameters would be OK, still this would require the extra SQL function to access it, which is something that pg_settings is able to equally offer access to if using a GUC. -- Michael --qnY65OJI8RcHfEP7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmRQcs4ACgkQnvQgOdby QH3gQw/9GSskA7VClvcezAxASeksbDMEo/w8lJCochvEuMurmGI8nkwsdUGQ8qw+ s296L0Ff/uTR2c+WQsZYt9v2qCYitc2UzMJDZKR8qydrnRY1R6HUoqudLODA9sv2 4/wvjSr8KhKG8MP1oZ4COHOd/6k8GwJNCzZVx7R9CxM3PKzKoYuPIo24lxmVLoxm fpnXuWsiPhN2MGikYuNNpvWN1w0RfRocMpsGsHSuOEaV9BLm2jcJSB0zgQrLQIh+ DvIDk6EF5ioG0ykC+0HPiGbDJHmnIHUF5gJqLw2R4v5AAyFjVdm8swViiGvWgY0c Rk26UtQ3tvWtcvDY2PLFVF/pHu0GnSqiqk5Uhpng98Y/kW7L5OEzRnella9fptn3 WUxgAwxbarUExvaqq9xeuFFH5WJvB0OgeaAmu7MWDSpqwu2loobYOMEHkO/Gu9/M G2TZqPOaGSC55s4IHml3dkuRQYG4j9uRa57d79sdoqBN1HO1dOxsWybzKTcIPLJ6 k/cXC2JJG88pwrgQaBIJa8dRJw5om2b0tTitWiQdjYEutP7HBNVOZIpskd9PxACw 70O+g5jiRMQIaYfi+eoT94i1/t3MR9JXbi13en3sNPM5jw/r5pN9G39lEgf1Zg0R f4DofOXmsMjkkE6n8+GXeZgIeqMJA+RVxP6J7aS9v8LvtOYQb4o= =S+MK -----END PGP SIGNATURE----- --qnY65OJI8RcHfEP7--