Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 2 May 2023 12:26:31 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Alexander Lakhin <exclusion@gmail.com>
Cc: David Rowley <dgrowleyml@gmail.com>,
	Justin Pryzby <pryzby@telsasoft.com>, pgsql-hackers@postgresql.org
Subject: Re: Fix typos and inconsistencies for v16
Message-ID: <ZFCC58SPNcK/426H@paquier.xyz>
References: <d5f68d19-c0fc-91a9-118d-7c6a5a3f5fad@gmail.com>
 <ZD3D1QxoccnN8A1V@telsasoft.com>
 <699beab4-a6ca-92c9-f152-f559caf6dc25@gmail.com>
 <CAApHDvqUdoxzLaVU16Ktx83qiroYrmxNTpwvd5GAcLH+ZH51Pg@mail.gmail.com>
 <e8c38840-596a-83d6-bd8d-cebc51111572@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="KtDeRFD5iA3p2huk"
Content-Disposition: inline
In-Reply-To: <e8c38840-596a-83d6-bd8d-cebc51111572@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ZFCC58SPNcK/426H%40paquier.xyz>
Precedence: bulk


--KtDeRFD5iA3p2huk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Apr 21, 2023 at 12:00:00PM +0300, Alexander Lakhin wrote:
> Please look at the following two bunches for v14+ and v13+ (split to ease
> back-patching if needed). Having processed them, I've reached the state that
> could be considered "clean" ([2], [3]); at least I don't see how to detect
> yet more errors of this class in dozens, so it's my last run for now (though I
> have several entities left, which I couldn't find replacements for).

This was hanging around, and I had some time, so I have looked at the
whole.  One of the only two user-visible change was in the docs for
pg_amcheck, so I have applied that first as of 6fd8ae6 and backpatched
it down to 14.

Now, for the remaining 59..

> 1. agg_init_trans_check -> agg_trans
> 2. agg_strict_trans_check -> agg_trans

    /*
     * pergroup = &aggstate->all_pergroups
-    * [op->d.agg_strict_trans_check.setoff]
-    * [op->d.agg_init_trans_check.transno];
+    * [op->d.agg_trans.setoff]
+    * [op->d.agg_trans.transno];
     */
Honestly, while incorrect, I have no idea what this comment means ;)

> 4. CommitTSBuffer -> CommitTsBuffer // the inconsistency exists since 5da14938f; maybe this change should be backpatched

Yes, we'd better backpatch that.  I agree that it seems more sensible
here to switch the compiled value rather than what the docs have been
using for years.  Perhaps somebody has a different opinion?

The others were OK and in line with the discussion of upthread, so
applied.
--
Michael

--KtDeRFD5iA3p2huk
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmRQgucACgkQnvQgOdby
QH0B5g//UHluMAeS9H9Go01AtFz+2/qT1xnjBGb91kDw4msTpZunLNbMhCnGwK0t
phgvJCzml2SV3BVoHOHqUegHFNDxYz8PmzBw11+FOzl2xeZ7qWAinWMfBMO8jgpN
fsAHTNpWerFqGU6mtQjtRMLqwAmJDSa7QiPow3VEU5kcmmLK+ymxxJPiRktZrpbB
MCPySEl+ab6mt589zquI465jJYZVO7e7gD/VVhYNfEcr3AhqzEpmcg5mAh7bsRKi
dVHCb/OFnylL5hO7MJ+g5gpLqVfiF1ew1xkZTRTFsK1J0aR1cKKNQ8HqOZCcjkZF
7uqdtuvII4LIW9YXpKVmEMQSRuFaHIzFxXmr0yKdJYOtE9H+4WTSZl+awHZwEF2m
G8UTWdtv3DEpD9/9A7I66PqoN6kEsE5Kw3ckEKcod+bePr1ADwRrnatlVt1ASVcf
URQgyokO79vAsWNRB+PSCTC+yw8CiX/QDHqoVzrYknWKyJz4Sul6urcgcMWdMtv6
sW3Vi+dihY7k6B53M4jFcQETaUNiVAZ9MXjSTYKuYRwug5S076OoGgvxazJASfwi
vBtXC6QGV0VsQhh/H3ZHMpw1qQGIoCYnQDtd4iPIsMN/5GivZAUh+Q3/JDH6HzUn
v8wbWGzsceqgU2ZkYMK29xjdq5H+1UT//aXNjQNz9KqHtWOxqAo=
=cR4G
-----END PGP SIGNATURE-----

--KtDeRFD5iA3p2huk--