Feedback-ID: i0fe9450f:Fastmail
Date: Sat, 6 May 2023 11:23:17 +0900
From: Michael Paquier <michael@paquier.xyz>
To: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Autogenerate some wait events code and documentation
Message-ID: <ZFW6FTMIH00502RU@paquier.xyz>
References: <2e649ed7-6c66-5d6a-16d4-5d5367d40e69@gmail.com>
 <ZEX0QT6vROUONVRH@paquier.xyz>
 <ff27ae4a-edaa-7766-0b43-c3a7b14fca84@gmail.com>
 <ZEdh2+46GuhCqW6b@paquier.xyz>
 <e8a1e3c2-26e5-8a7a-f821-eee92ab0c8e2@gmail.com>
 <64fc361e-f4ed-45eb-0cfb-c8110872530d@gmail.com>
 <ZEoSlv9HxURD8Uxw@paquier.xyz>
 <e59598e3-3630-e90d-8985-1833f8d5aede@gmail.com>
 <ZE8A8IIJ5GXfIKv8@paquier.xyz>
 <124bdcea-bdc8-e3d2-2357-0c6a857bc557@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="qSp6HBflPb2Ssb9+"
Content-Disposition: inline
In-Reply-To: <124bdcea-bdc8-e3d2-2357-0c6a857bc557@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZFW6FTMIH00502RU%40paquier.xyz>
Precedence: bulk


--qSp6HBflPb2Ssb9+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, May 04, 2023 at 08:39:49AM +0200, Drouvot, Bertrand wrote:
> On 5/1/23 1:59 AM, Michael Paquier wrote:
> I'm not sure I like it. First, it does break the "Note" ordering as compa=
re
> to the current documentation. That's not a big deal though.
>=20
> Secondly, what If we need to add some note(s) in the future for
> another wait class? Having all the notes after all the tables are
> generated would sound weird to me.

Appending these notes at the end of all the tables does not strike me
as a big dea, TBH.  But, well, my sole opinion is not the final choice
either.  For now, I am mostly tempted to keep the generation script as
minimalistic as possible.

> We could discuss another approach for the "Note" part if there is a
> need to add one for an existing/new wait class though.

Documenting what's expected from the wait event classes is critical in
the .txt file as that's what developers are going to look at when
adding a new wait event.  Adding them in the header is less appealing
to me considering that is it now generated, and the docs provide a lot
of explanation as well.

>> This has as extra consequence to require a change in
>> wait_event.h so as PG_WAIT_BUFFER_PIN is renamed to PG_WAIT_BUFFERPIN,
>> equally fine by me.  Logically, this rename should be done in a patch
>> of its own, for clarity.
>=20
> Yes, I can look at it.
> [...]
> Agree, I'll look at this.

Thanks!

> I'll look at v7 when the v17 branch opens and propose the separate patch
> mentioned above at that time too.

Thanks, again.
--
Michael

--qSp6HBflPb2Ssb9+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmRVuhUACgkQnvQgOdby
QH3gwA//W9OjsnQ1HvGdW6dxXZnXnm9Cr4YqN4mkbtDeUG65rywkMPbwswcCtfg3
U9T0exNPV72I21MAOKLVWqYjPS64zmBE+KhixKL6vYHN5n9j+JawwYCJWHP39wn0
qk0LIz2YbJe3gSATBkv6gZSJFutN6A2QXMPsFWACQP3voWDKhaukzWWraPU3Uw6x
gtFxuEpURH6EwqyHYYMYO3/JUsafTlDu5jIJCyqumpT7epH+JdVyTsSLKR/N9VPn
D86x5yCS3FXBm2v0bo/Yd3uEwS79VKpNDLll6nSGFagmsq1rgba56fkuTrit8ISR
sqK4ji9sb166UKYJHBBCiO034qSryVyM3NOK7xGWVOOVtmk2n2HQy0B9Ra+gj+rM
r2oKwjcVWwz2D9S1fEaRP/KhUdTeC/SnOvxWIevMhgkRMejHUYNjG6HFXYZ9hPeV
kzV5dbzYj84IDH+8RDuoRMCR2VuUFH1JaALz4bxAsjPtPqtux3Bz42UIV2k7AhJC
ICP0jxUvcjRKNA8y3rbPlyqHtDGQ1iG0zva5jagLMAfMLXNUPaR0OhZp1G3bpJIH
3qSucP88r/cUW16GtnG+D3owLTLYeABa83UszrbY3bPW4NmOJ/3UlSpZDlJ3+PYE
9SkUPerDeWR7hoMtbi8zoXQOt1oobc4xgkhP2LIvW7OwnBM4mfc=
=gfEl
-----END PGP SIGNATURE-----

--qSp6HBflPb2Ssb9+--