Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pv81B-0002pV-Ht for pgsql-hackers@arkaria.postgresql.org; Sat, 06 May 2023 02:51:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pv81A-0004K8-Ef for pgsql-hackers@arkaria.postgresql.org; Sat, 06 May 2023 02:51:28 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pv81A-0004Jy-5I for pgsql-hackers@lists.postgresql.org; Sat, 06 May 2023 02:51:28 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pv817-000meD-Hf for pgsql-hackers@lists.postgresql.org; Sat, 06 May 2023 02:51:26 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id E65C65C00DE; Fri, 5 May 2023 22:51:24 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 05 May 2023 22:51:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1683341484; x=1683427884; bh=2X 4baI5E8ggIgeZrL6UWF6nFdXoe8nXRSlPxgZhzqbc=; b=oGWWtLlKVU2d1zxj5d 4N7pYM/SjGE0atLWXBqm3eHrl5Covj9FMcP7RdhsFN+jYsd+LpGkavECcJeS1OBH 4D4e0RBh7GbppmxXEaew9oKHSL95g/ifyJwDSMkOg4KrQQd2Tz7G3dMD0iObpAwY exaIEnttmzfSmrLDJp5GbNJe44GlLAzzUdNiveMIwxSlWiGVCNjqNpmaQmZpACh+ YtRSX+8AO2/gOBgroU7WCnBKbFfpfFlkYDjIWVP54fSd9F0Ho+dCoV55Lzilwl3R 1KSBTCpfo4ieUhBGUbAUITCHbnpio93i8DD2MwM1Q8ia0uDnFH686NZwIKC8J8S6 HBWQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1683341484; x=1683427884; bh=2X4baI5E8ggIg eZrL6UWF6nFdXoe8nXRSlPxgZhzqbc=; b=B3hoHBEtQid8sKMUzwYl6pWtwF1Bc sdYB0+hsISeD5luPI8EhmbLs+EUe5242uVNtYK3vXotgmQwZLf04PQCe6Acu+9Xn IbRXO/V/tVde22bqQm08IMTF0nC2NlUm1W74A7I7iVQNkEH6/qv3iBaNwauj4wmU vCfH3oBw0SKheS7JLC+RfOQVJ0iv5xjnv6aJnEpCH4Y5w+6CDzs13uv+Qfqtglhf Umm9t+WqrlufuMIyCoGc6SOeaghUGUV0qX6TVZGH3kPO7n67OsqdFiBMcagdQ+nA eBAqZQ9/+y2vtvTv1xo9noBwEvV0oCYFfnY9B3n9RW8TdjHx7T98vh1Xg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeeffedgieehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdlfeehmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 5 May 2023 22:51:21 -0400 (EDT) Date: Sat, 6 May 2023 11:51:19 +0900 From: Michael Paquier To: gkokolatos@pm.me Cc: Andrew Dunstan , Alexander Lakhin , Tomas Vondra , Justin Pryzby , shiy.fnst@fujitsu.com, pgsql-hackers@lists.postgresql.org, Rachel Heaton Subject: Re: Add LZ4 compression in pg_dump Message-ID: References: <7zu6GYFi72jByVk2SEe_nd8r1DHhwA35vSntAE9sAfiMX9Lfk6bwimkwmu7GDgYaEvL27SE4qF1uK4_LHWQM4H-SXOwkMAI-GV8PKGmED_E=@pm.me> <32ba9612-1982-4b2d-135a-5d1222987082@enterprisedb.com> <3beb0dd7-c927-3eca-689f-716e255d5b27@enterprisedb.com> <94ae9bca-5ebb-1e68-bb7b-4f32e89fefbe@gmail.com> <71868915-0345-1b7b-f3d6-ec66547c662a@dunslane.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="MuoCya/q3ecDP02e" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --MuoCya/q3ecDP02e Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 05, 2023 at 02:13:28PM +0000, gkokolatos@pm.me wrote: > Good point. I thought about it before submitting the patch. I > concluded that given the complexity and operations involved in > LZ4Stream_read_internal() and the rest of t he pg_dump/pg_restore > code, the memset() call will be negligible. However from the > readability point of view, the function is a bit cleaner with the > memset().=20 >=20 > I will not object to any suggestion though, as this is a very > trivial point. Please find attached a v2 of the patch following the > suggested approach. Please note that an open item has been added for this stuff. -- Michael --MuoCya/q3ecDP02e Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmRVwKcACgkQnvQgOdby QH3VFQ//YVLirJl6xNuQhJqVlV6pMuz+vOCGaPqo+TPaDUrNu9C6q8PoSm0RDIyN x149kQFZI+e7DwLdsAtt5Ju/4QQCw38GeeqVChsLLfQefd/tfhsyHBa1QEPB0NTK aN34JvcJ4TWY5j3xgKTBVjWzo6LHIzgnlT7tKS57ixBNQzW4OdiWuHQE0ZecBR7l PW7RGCYUXeKNfdPK8Hjr0EItQ2Yhb3VZG1YC2p2K4X/G8PP7Nt5a7JNk8ct2MtR1 8lpQG++55YVX24Zje06gnp/zqrMPzg98sgsltqcN07fxSjcIMrMjrCXRoq6pqBYE V37w9xKT9rQgPrtAEJJAa5xCFRJPzXeL9pqDmqjilVCSxLvGWuGKNGP2Gz9EeX+M WHynub2XvwGswgOksyOXrVjgIJFefQ4TQ3DOjIY/TimpWZNX/Lcqjj/yK6qFcM7M WVu+5kiXMAmRVfCINkYskZ0m8FoId0c/VT/YQjavJvPOh4eKh2YuTBMA/yIdvvNH WULfbY8X5O7DOm93HWEBi9iG28+rUQVEeHlFW3zsP2kCClRbUlvcAs6vkL0udobo CJteZOQeIdyFnfVOaLu0ZTpUdVQkKNqMNGmkFdK2on1A0nQNuc5yjqKNJMOsRn10 b9KlQiO8UMlDWwAYOxA4EuLwxi5c3Yj/kxisqRcS4gWxzbl+QUc= =zXNS -----END PGP SIGNATURE----- --MuoCya/q3ecDP02e--