Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 24 May 2023 09:17:16 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>,
	Aleksander Alekseev <aleksander@timescale.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Nikita Malakhov <hukutoc@gmail.com>
Subject: Re: RFI: Extending the TOAST Pointer
Message-ID: <ZG1XjI5meIvQNS/+@paquier.xyz>
References: <CAN-LCVMq2X=fhx7KLxfeDyb3P+BXuCkHC0g=9GF+JD4izfVa0Q@mail.gmail.com>
 <CAJ7c6TNAYyeMYKVkiwOZChy7UpE_CkjpYOk73gcWTXMkLkEyzw@mail.gmail.com>
 <CAEze2WibtT+EdGscamqDm3+7qauWi_S6nVUhbK_qg1rkqN_48w@mail.gmail.com>
 <CA+TgmoaVcjUkmtWdc_9QjBzvSShjDBYk-5XFNaOvYLgGROjJMA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="t242MtS2ZdCz9uLF"
Content-Disposition: inline
In-Reply-To: <CA+TgmoaVcjUkmtWdc_9QjBzvSShjDBYk-5XFNaOvYLgGROjJMA@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZG1XjI5meIvQNS/%2B%40paquier.xyz>
Precedence: bulk


--t242MtS2ZdCz9uLF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, May 23, 2023 at 12:33:50PM -0400, Robert Haas wrote:
> For projects like this, the details matter a lot. If the goal is to
> add a new compression type that behaves like the existing compression
> types, more or less, then I think we should allocate the last
> ToastCompressionId bit to mean "some other compression ID" and add a
> 1-byte header that says which one is in use. But if the new feature
> being added is enough different from the other compression methods,
> then it might be better to do it in some other way e.g. a new VARTAG.

Agreed.  While the compression argument and the possibility to add
more options to toast pointers are very appealing, FWIW, I'd like to
think that the primary target is the 4-byte OID assignment limit of
where backends loop infinitely until a OID can be found, which can be
a real pain for users with a large number of blobs or just enough
toast data to trigger it.

Saying that even if I sent the patch for zstd on toast..
--
Michael

--t242MtS2ZdCz9uLF
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmRtV4wACgkQnvQgOdby
QH3kDw/9FHs0vb22h0/Ntze4EwqpTOEL7X7KGKe6ROFjezp3WTp0JTpiBxji6Qch
rPb0s2vSjGNHXVJkYnFBtvmY362tGfJ4qgrV8kb0n9W3TSGMWKjJMNPfR35pCBzK
7CgunddWVxdCktPHhllJIVo2jEWHfPSaaDkBHkWvpRmwnV6T8QDXULZ/7QV0NGe5
SmyCKzYwblFPIDBGZM/OKCIt5wSt01KJcP4QCyBLNITA4Awvg/VszgY4Y3bZToaG
4FY59HJ9vM5Cn3dy+D/dpr09yrnZC0MAlQCRg5xhBUX7ZXAYZh3n1lKVdGADEV1z
9xHNUJLdNrfnDTXkY6EX5gVZ1QoNil3WsdO/O8huNRBzcp9t6WV0slId7apS7FC/
2dpP8qzppxjDaSa6zCeBdqjlmPdUGNwdWOIgTr+0jK/F3BUEjzUF6rkFG/+FgXd5
67T2i5JD2Kq+gbOHRWBI8brbFYyuAIZyPusMjXVR8OBf5joPRmJjtdyyC2hrZ4ng
CHx5ex/wdtoNNFQMIp/JnLdn9eUIjnN5ayrKfWUVEZwNzQIrbxvrbXZqfHGoO940
DruFvFDMhwE2B1PYEYuEWursEx3rjF1apA9/6iBGkI9WucKyg4bualm6A8McO+hB
pXKNfNm20/yH0JCDjVkAFjoG5bbvi/UZHBGl4yVFtDWGh8QTWlk=
=f59g
-----END PGP SIGNATURE-----

--t242MtS2ZdCz9uLF--