Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 16 May 2023 09:38:54 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Introduce WAIT_EVENT_EXTENSION and WAIT_EVENT_BUFFER_PIN
Message-ID: <ZGLQnikZoxsqj2dl@paquier.xyz>
References: <c6f35117-4b20-4c78-1df5-d3056010dcf5@gmail.com>
 <20230515182956.5lavflljhpgpokxc@awork3.anarazel.de>
 <ZGKynuIpQp1G8Bec@paquier.xyz>
 <20230516001716.iy7no2q77vwdt5w2@awork3.anarazel.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="MTnZsD+RmPH/BjfR"
Content-Disposition: inline
In-Reply-To: <20230516001716.iy7no2q77vwdt5w2@awork3.anarazel.de>
Archived-At: 
 <https://www.postgresql.org/message-id/ZGLQnikZoxsqj2dl%40paquier.xyz>
Precedence: bulk


--MTnZsD+RmPH/BjfR
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, May 15, 2023 at 05:17:16PM -0700, Andres Freund wrote:
> IMO the submission should include why automating requires these changes (yours
> doesn't really either). I can probably figure it out if I stare a bit at the
> code and read the other thread - but I shouldn't need to.

Hm?  My previous message includes two reasons..  Anyway, I assume that
my previous message is also missing the explanation from the other
thread that this is to translate a .txt file shaped similarly to
errcodes.txt for the wait events (sections as wait event classes,
listing the elements) into automatically-generated SGML and C code :)

The extensions and buffer pin parts need a few internal tweaks to make
the other changes much easier to do, which is what the patch of this
thread is doing.
--
Michael

--MTnZsD+RmPH/BjfR
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmRi0J4ACgkQnvQgOdby
QH0paQ//dfS92R05Vr+qJFXUkr/xwhZzP284bEwk5pWqJDUYBMZfQnljuxWBMPZB
DmWJiYal62F21Z2XFegIyIpNQQcMIYbHZ2itKEDNeuSdTw9yE+Ov3IYUEOsctSZ0
5NYtM03/o5oAQxPLkMcdQAGumXCq6K8WCzHp2DaLKsD2AhwZ+BK9aix4CiRDnfp6
bAajijjKfAxuaHaT1yp0z+V90q2MaTJzjejKCG/CJW3SBia8eRJ+y/SmHPDoVI7W
bn8vJYugDQWw2KYZeN/SVku8lNSbuShJSumKhA+jYAmBpWaYyqOmRhfdis/LDkK0
Od74M0ggv1eFBTU1aPyul7OKpAIJ2AUjnay8xhdcDHsiDQKTh7E7UNI8t7djtsCR
uxUQG5qoKQP4WS0wi7au14Yt+g8D3r+F+1hicmrHocM5c+fv9p1HwVYBaYFXUycb
ASjuaQ368vOBj2IRn+K/nXly9vniqJPTZLUiD3nr7uHowsrgAgDY5CzuNIeIaXjK
xoZy6MaotSFaACVLKge1xroh6wE5He3Bpg/DO3fVrSsWPX4S0UrH8BoTecaoYgdd
tF0tKpD4QJ8sfUDxgpBtcC77g8IozPJypejR6MhcwWwVyPZOjrdqUBJjMwPfiE50
hIm2RpoEKTTntBbfCNsituhl297tr7hBkFAVW/Wy3EvzHgJhQZY=
=K5vf
-----END PGP SIGNATURE-----

--MTnZsD+RmPH/BjfR--