Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pzpAf-000247-D3 for pgsql-hackers@arkaria.postgresql.org; Fri, 19 May 2023 01:44:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pzpAe-0006J6-A8 for pgsql-hackers@arkaria.postgresql.org; Fri, 19 May 2023 01:44:40 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pzpAd-0006IL-Sw for pgsql-hackers@lists.postgresql.org; Fri, 19 May 2023 01:44:40 +0000 Received: from momjian.us ([72.94.173.45]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pzpAa-000aVA-NQ for pgsql-hackers@postgresql.org; Fri, 19 May 2023 01:44:38 +0000 Received: from bruce by momjian.us with local (Exim 4.94.2) (envelope-from ) id 1pzpAY-0098hN-Ky; Thu, 18 May 2023 21:44:34 -0400 Date: Thu, 18 May 2023 21:44:34 -0400 From: Bruce Momjian To: Peter Geoghegan Cc: PostgreSQL-development Subject: Re: PG 16 draft release notes ready Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="F0h/0lEcJ+rGgWdT" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --F0h/0lEcJ+rGgWdT Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Thu, May 18, 2023 at 04:12:26PM -0700, Peter Geoghegan wrote: > On Thu, May 18, 2023 at 3:52 PM Bruce Momjian wrote: > > So, I looked at this and the problem is that this is best as a single > > release note entry because we are removing and adding, and if I moved it > > to compatibility, I am concerned the new feature will be missed. Since > > WAL inspection is a utility operation, inn general, I think having it in > > the pg_walinspect section makes the most sense. > > I don't understand what you mean by that. The changes to > *_till_end_of_wal() (the way that those duplicative functions were > removed, and more permissive end_lsn behavior was added) is unrelated > to all of the other changes. Plus it's just not very important. I see what you mean now. I have moved the function removal to the incompatibilities section and kept the existing entry but remove the text about the removed functions. > > Okay, I went with: > > > > Improve descriptions of pg_walinspect WAL record descriptions > > (Melanie Plageman, Peter Geoghegan) > > > > > Note also that the item "Add pg_waldump option --save-fullpage to dump > > > full page images (David Christensen)" is tangentially related to > > > pg_get_wal_block_info(), since you can also get FPIs using > > > pg_get_wal_block_info() (in fact, that was originally its main > > > purpose). I'm not saying that you necessarily need to connect them > > > together in any way, but you might consider it. > > > > Well, there is so much _new_ in that tool that listing everything new > > seems confusing. > > There is pretty much one truly new piece of functionality added to > pg_walinspect (the function called pg_get_wal_block_info was added) -- > since the enhancement to rmgr description output applies equally to > pg_waldump, no matter where you place it in the release notes. So not > sure what you mean. I see what you mean now. I have removed the mention of pg_get_wal_block_info() and moved the three items back into the extension section since there are only three pg_walinspect items now. > > All changes committed. > > Even after these changes, the release notes still refer to a function > called "pg_get_wal_block". There is no such function, though -- not in > Postgres 16, and not in any other major version. Oh > > As I said, there is a new function called "pg_get_wal_block_info". It > should simply be presented as a whole new function that offers novel > new functionality compared to what was available in Postgres 15 -- > without any further elaboration. (It happens to be true that > pg_get_wal_block_info only reached its final form following multiple > rounds of work in multiple commits, but that is of no consequence to > users -- even the earliest form of the function appeared in a commit > in the Postgres 16 cycle.) Done. Please see the URL for the updated text, diff attached. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you. --F0h/0lEcJ+rGgWdT Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="master.diff" diff --git a/doc/src/sgml/release-16.sgml b/doc/src/sgml/release-16.sgml index 47f6cae907..5c17237966 100644 --- a/doc/src/sgml/release-16.sgml +++ b/doc/src/sgml/release-16.sgml @@ -91,6 +91,17 @@ Processing such indexes is still possible using REINDEX SYSTEM. + + + + +Remove pg_walinspect functions pg_get_wal_records_info_till_end_of_wal() and pg_get_wal_stats_till_end_of_wal(). + + + + + + +Add pg_walinspect function pg_get_wal_block_info() to report WAL block information (Michael Paquier, Melanie Plageman, Bharath Rupireddy) + + + + + + + +Change how pg_walinspect functions pg_get_wal_records_info(), pg_get_wal_stats(), and pg_get_wal_block_info() interpret ending LSNs (Bharath Rupireddy) + + + +Previously ending LSNs which represent nonexistent WAL locations would generate an error, while they will now be interpreted as the end of the WAL. + + + + + + + +Improve descriptions of pg_walinspect WAL record descriptions (Melanie Plageman, Peter Geoghegan) + + + - - - -Add pg_walinspect function pg_get_wal_block() to report WAL block information (Michael Paquier, Melanie Plageman, Bharath Rupireddy) - - - - - - - -Add output fields to pg_walinspect's function pg_get_wal_block_info() (Bharath Rupireddy, Peter Geoghegan) - - - - - - - -Change how pg_walinspect functions pg_get_wal_records_info(), pg_get_wal_stats(), and pg_get_wal_block_info() interpret ending LSNs (Bharath Rupireddy) - - - -Previously ending LSNs which represent nonexistent WAL locations would generate an error, while they will now be interpreted as the end of the WAL. Functions pg_get_wal_records_info_till_end_of_wal() and -pg_get_wal_stats_till_end_of_wal() have been removed. - - - - - - - -Improve descriptions of pg_walinspect WAL record descriptions (Melanie Plageman, Peter Geoghegan) - --F0h/0lEcJ+rGgWdT--