Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q1SMl-0006Wn-3m for pgsql-hackers@arkaria.postgresql.org; Tue, 23 May 2023 13:47:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1q1SMi-00076y-RE for pgsql-hackers@arkaria.postgresql.org; Tue, 23 May 2023 13:47:52 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q1SMi-00076m-IG; Tue, 23 May 2023 13:47:52 +0000 Received: from feynman.df7cb.de ([195.49.152.168]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q1SMd-001f7X-OP; Tue, 23 May 2023 13:47:51 +0000 Received: from msg.df7cb.de (ipv6-d019d314ec32c1cb.west.clients.hamburg.freifunk.net [IPv6:2a03:2267:2:0:d019:d314:ec32:c1cb]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) by feynman.df7cb.de (Postfix) with ESMTPSA id 4QQbH71gPZz3F37; Tue, 23 May 2023 15:47:47 +0200 (CEST) Date: Tue, 23 May 2023 15:47:46 +0200 From: Christoph Berg To: Andres Freund Cc: pgsql-hackers@lists.postgresql.org, PostgreSQL Packagers Subject: Re: pgsql: Move snowball_create.sql creation into perl file Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Re: Andres Freund > Move snowball_create.sql creation into perl file > > This is in preparation for building postgres with meson / ninja. > > We already have duplicated code for this between the make and msvc > builds. Adding a third copy seems like a bad plan, thus move the generation > into a perl script. > > As we don't want to rely on perl being available for builds from tarballs, > generate the file during distprep. > > Author: Peter Eisentraut > Author: Andres Freund > Discussion: https://postgr.es/m/5e216522-ba3c-f0e6-7f97-5276d0270029@enterprisedb.com Hi, this seems to have broken out-of-tree builds from tarballs: make -C backend/snowball install make[3]: Entering directory '/srv/projects/postgresql/debian/16/build/src/backend/snowball' /bin/mkdir -p '/srv/projects/postgresql/debian/16/build/tmp_install/usr/lib/postgresql/16/lib' /bin/mkdir -p '/srv/projects/postgresql/debian/16/build/tmp_install/usr/share/postgresql/16' '/srv/projects/postgresql/debian/16/build/tmp_install/usr/share/postgresql/16/tsearch_data' /usr/bin/install -c -m 755 dict_snowball.so '/srv/projects/postgresql/debian/16/build/tmp_install/usr/lib/postgresql/16/lib/dict_snowball.so' /usr/bin/install -c -m 644 snowball_create.sql '/srv/projects/postgresql/debian/16/build/tmp_install/usr/share/postgresql/16' /usr/bin/install: cannot stat 'snowball_create.sql': No such file or directory make[3]: *** [Makefile:110: install] Error 1 The file is present in src/backend/snowball/ but not in build/src/backend/snowball/: -rw-r--r-- 1 myon myon 44176 22. Mai 21:20 src/backend/snowball/snowball_create.sql Christoph