Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q6NyB-0002Sn-GW for pgsql-hackers@arkaria.postgresql.org; Tue, 06 Jun 2023 04:06:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1q6Ny8-0002FA-Lr for pgsql-hackers@arkaria.postgresql.org; Tue, 06 Jun 2023 04:06:52 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q6Ny7-0002F1-BY for pgsql-hackers@lists.postgresql.org; Tue, 06 Jun 2023 04:06:52 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q6Ny3-000VQ6-BQ for pgsql-hackers@lists.postgresql.org; Tue, 06 Jun 2023 04:06:50 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id BAFC83200AB8; Tue, 6 Jun 2023 00:06:42 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 06 Jun 2023 00:06:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1686024402; x=1686110802; bh=aj +zTkGXZYkeFJFvKNF9ZllJo5k4ZIbWcXvaUQgVJDw=; b=M9vOo+A6eRO6U1dQb2 wR5F+s1D1qtIYv/Ziv42rumwZhMMH9/XTtrEEwm0bSMMvyl4OTxK5rBnsj2NnZP1 7zkqLisOy5UbOo5IZqu6g/aDNxnncaT2bNddp5UqL5Lzm1KOJ+towLYreafoyOtm C/NtvEaq+NR6r016daawqM4HrE4RmuJSsnQ4aqTRgW3SDQI9/VsX385IrR1bqK4M KUxBiyJAKqM4haKXaYkBbRhLF6UA/Wyh9VAqvRExHOnqKkHSnjHbq03H0tigB0v7 Sjn/RiWnnfW/WLG1kYLuzCUSc8SrCWsi0OhatNEnefTcJLwxmry8CIAZLVQ5G395 r2sw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1686024402; x=1686110802; bh=aj+zTkGXZYkeF JFvKNF9ZllJo5k4ZIbWcXvaUQgVJDw=; b=CUDYVNuf/NmlMtPNFjMmQ3Ot01Xfd t47+hBI69MuOUOfr2TIctvNq+6CNjrrMt1T7fyEY8wNRWO2xEZUbXKl3CljkzXZO YJUCv9m8jk0QAYIMnLg4yEffbURtUHV6ngT1r4sxkftlD9SAwZaPlSEFAx5iwGsp Fe0dTTk8AszZJNJwLRMBgJbFlYKs4xIQs3F1sPT99kjmpJqenVOFuDnrgc4SDufw FKm1dXe1fhAiWd0Ib2/jlftVtmNiQC0wtSpKCxPSZbV6sHaVbUFz7IU9oxWS8dhe Uq3XbtbY97sVdsoKX/hmSUQHI3fXQGUKjUfdoCWIJBmtyc9S/G+TXRngQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedttddgjeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 6 Jun 2023 00:06:39 -0400 (EDT) Date: Tue, 6 Jun 2023 13:06:33 +0900 From: Michael Paquier To: Amit Kapila Cc: vignesh C , Andrew Dunstan , Dagfinn Ilmari =?iso-8859-1?Q?Manns=E5ker?= , PostgreSQL Hackers Subject: Re: Implement generalized sub routine find_in_log for tap test Message-ID: References: <87cz2otiw3.fsf@wibble.ilmari.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7bB7O/DZHsd2vjBh" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --7bB7O/DZHsd2vjBh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 06, 2023 at 08:05:49AM +0530, Amit Kapila wrote: > Personally, I don't see any problem to do this refactoring for v16. > However, sometimes, we do decide to backpatch refactoring in tests to > avoid backpatch effort. I am not completely sure if that is the case > here. 033_replay_tsp_drops.pl has one find_in_log() down to 11, and 019_replslot_limit.pl has four calls down to 14. Making things consistent everywhere is a rather appealing argument to ease future backpatching. So I am OK to spend a few extra cycles in adjusting these routines all the way down where needed. I'll do that tomorrow once I get back in front of my laptop. Note that connect_ok() and connect_fails() are new to 14, so this part has no need to go further down than that. -- Michael --7bB7O/DZHsd2vjBh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmR+sMkACgkQnvQgOdby QH0YLg/+LGP65x07zfgwDnoi4R2obcHz0aRJ3+ZipaRhaJjzJpZhr1pPSIZPuKr4 MEZwq4BD1B/q4wEw9Xq6Wj8alf0A3UOq+YhSiwsPcYff22tnqAex+7lyuPucLBuR gLAywkSqxuQkiYy4tkGYyFUOJcwFhxWG9CAZXulisjewv6sCiEk5h8Eyy1PRXrn/ T50ZSRlQQu+eZJc4pLt+CuQhXv5w2ct8WJH2HUX5ASYHUHekVUx2prRQ2/+Bboa3 g4ftyM0VPHulH4BWHF4R/jZpSyOUALPvjlkynLhJT8at4TBHzdcGkIlCvDtLdbI3 2v+QSKIOSgjMqU5u2V4fk4doizn/beMb8vHrDcS/r72uJlaXPC1ANSXtozMyKfBS A6ka+KMY1PhDF8tYY9dK1R33Nkd2ieke8j9X1MC84eMS1LZBZnDnNeS5Ii5vzFXK yjHSA3/7B6q5Zm9/tYqiBWSPazlhcvuGqH0xl8oUdSMsc3bhiDLp0vQKeJRyy8ck urFrjA0drnTniqYwhfCYEjqpsIQ1rt1PofPuyZMEWYCFqaGAa7kZ6s56N/LGuRTs 4Wmb6P54KQ05IU+ybQrMNe7OV1yoBOE0fmZTE0pSG/w7ysWFP31EDh75BMkECLqj ADnlVdJaRDocvRHnflL1qtUNwDjXvfOD6l36k43SMHnbdeVo4Ro= =ZKZO -----END PGP SIGNATURE----- --7bB7O/DZHsd2vjBh--