Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q6U8A-0000rH-Ug for pgsql-hackers@arkaria.postgresql.org; Tue, 06 Jun 2023 10:41:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1q6U88-0002lr-Qs for pgsql-hackers@arkaria.postgresql.org; Tue, 06 Jun 2023 10:41:36 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q6U87-0002Qj-CT for pgsql-hackers@lists.postgresql.org; Tue, 06 Jun 2023 10:41:36 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q6U83-000Vvv-W6 for pgsql-hackers@lists.postgresql.org; Tue, 06 Jun 2023 10:41:33 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 60EC93200972; Tue, 6 Jun 2023 06:41:28 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 06 Jun 2023 06:41:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1686048087; x=1686134487; bh=b1 A4F0K4rORG39+OlWNg6rBoAk2kibC2zsvOhZAS+dQ=; b=I22qkDL0V6QbjwrUfO QLc5463ab2bCXqRW/RaHk2J/S5TKVjm/K3aRWZV1t/wDYUZxjVdnQy2a4QfR9/nl MzrXHVlOQTWCVe0E4Q0+XuHztpvMy09d6EXRNaiCvQYsWhfOA5u12eadpc2ACitv 5VBnJhNQ0X39TWLpo/vzfegujFlzxc5rkb70eW6Epckbd4pp+cpIKuqB1NBQjYSq Ja2mOHNIxN4cEtIf+0DQHpj/zylbuRhMU5CnXh0DMgflnErZTWfc7QXDUDGgVEo6 rfycXkfHZGlxk4ChECzcYRrXnzo0hmPUbkC9eqyPL2Duf5NuKHPwe4u8dnI+VX1A sHtw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1686048087; x=1686134487; bh=b1A4F0K4rORG3 9+OlWNg6rBoAk2kibC2zsvOhZAS+dQ=; b=ThOQclqy3hyVitcIYRDuBadmR6jMH bUZzjA05zl9XNys76OboN/ijgMhF4KHuCJNUALVcQp2j2BwfnCvJtWbPOT+WlgHL /e6GJdMbl7NCSodfq8urVptmeZpIMZ+OgzpjKKE+cNm4Oe36CuBEYF6WykHRzvJQ bIYxWUFc2mf3roby4gIKvZx8nMmpHiBIafe3y57nuYHEi+O1zrNNzw7qaXGxwVzU GGFDlLe7EqVlTRgg1zlKk4zhpIdOKoQPxTi28gA7At0lSc/fCXzsfW6MGIppnAeQ 2hMVEYvOFSn1j0giVIKZjo9EPXOqkIviddMGrI8L6gmRbv+vRmUEiWHUQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedtuddgfeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 6 Jun 2023 06:41:25 -0400 (EDT) Date: Tue, 6 Jun 2023 19:41:18 +0900 From: Michael Paquier To: Bharath Rupireddy Cc: vignesh C , Andrew Dunstan , Dagfinn Ilmari =?iso-8859-1?Q?Manns=E5ker?= , PostgreSQL Hackers Subject: Re: Implement generalized sub routine find_in_log for tap test Message-ID: References: <87cz2otiw3.fsf@wibble.ilmari.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Thzy5neD/rI2sWV1" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --Thzy5neD/rI2sWV1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 06, 2023 at 10:00:00AM +0530, Bharath Rupireddy wrote: > +1 for deduplicating find_in_log. How about deduplicating advance_wal > too so that 019_replslot_limit.pl, 033_replay_tsp_drops.pl, > 035_standby_logical_decoding.pl and 001_stream_rep.pl can benefit > immediately? As in a small wrapper for pg_switch_wal() that generates N segments at will? I don't see why we could not do that if it proves useful in the long run. -- Michael --Thzy5neD/rI2sWV1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmR/DU4ACgkQnvQgOdby QH1Ntw/+Lf74goacc665pA3ftqc+UXBP9Yz7r/SRXmWU5tbm4o/NYSln2lLFQ4QE mPdfAR8pCPLVTIZk69xkKx9fKckR28+oOVKumIUSFVMFieNqjtX++KDtuftfrQg1 mX6xCM+ox3YsvSp4jgoZ3w0XEep+TixKAJmvw6YvgkMCkuC0U/Kk9ylLGJQnGa04 ra9hwH+c3MlVnbLJWmmwhJScCTSS4I0EH+0dvIR7Sy1W4bEJgLdZn4uWMZHdW6x2 KvqVEbEllpsCQiCuAdEFyRqvMfX05R/UhlUVxiCu+QLaSqcgV1OSm2FSo9TRkawH 88ziJ5Pdb0dqiuIVxgGMCJ0A+BWCpsETnEauq/2l98xp96qmYAsYLS2SoKFAfdGV vki3igko3P8yriGyDKGMWozwmo7IZC5F3GDYFjmtZNd/JTclKMbN5hHAN/vSavnH 3GfxYisIsDFqAUpKLaQaIsh6KCAPa1qfxxYituUlzSrDkDpzFRziwfEeVNQ1D4gQ /psBYG2rhnem+LdFzP774dnyQIbVLDtDODmIj1ifGlsEQp8uAGTB7l6RGNYkGo9z 2s/+c5ufBtGDrgmI9qDeKSvUihyy/2JE2erz5p+IPj+nAR5KaLDRzgx+Y4g6rbgN Rcju1uvAJ6FW2g0CBuD0G9N1s/3trq2nY93EDJK3Fsksd7/UOPU= =lTOh -----END PGP SIGNATURE----- --Thzy5neD/rI2sWV1--