Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q7SLP-0004IT-1l for pgsql-hackers@arkaria.postgresql.org; Fri, 09 Jun 2023 02:59:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1q7SLN-0000hg-TX for pgsql-hackers@arkaria.postgresql.org; Fri, 09 Jun 2023 02:59:17 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q7SLM-0000bX-9v for pgsql-hackers@lists.postgresql.org; Fri, 09 Jun 2023 02:59:17 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q7SLI-0010Hx-Tv for pgsql-hackers@lists.postgresql.org; Fri, 09 Jun 2023 02:59:15 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id F04A23200901; Thu, 8 Jun 2023 22:59:10 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 08 Jun 2023 22:59:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1686279550; x=1686365950; bh=x6 N6cYDauroXqgVRWLQsbA7eyS2ck8ogCMayqUJiXi4=; b=Tu5qJ8E3ZeXz+UrxNm 7FCPEYZ5lq4pCj/WEicF8SBs9DpYqtdhLA/pbgymAYBaca8KEwPAsxEjxiK2M86y zAgXHqZtnvd5mxcGbYDYrZ16z+Gy5EN4sdsTJ/VsnUy3T2HINe9Vag0nVz1UzZFS WeZGzTYUw7FTJUw1OyYlQiLWJR363INZWB7to8AwvZvqdfEgudRL2Bqm6aAsblpe UWPz4Ot0CtnLaj5VWPLDYlrJwZvkXWOtu0U/O+X7rPnMqdvUltgNMcYU+eKeBKpK dytg9wYCzwKsynLYq19P+4QupPv9hrQXVx3TAgYkiHjgnaJxKjkYXPFf+lCuQZ/p UWLg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1686279550; x=1686365950; bh=x6N6cYDauroXq gVRWLQsbA7eyS2ck8ogCMayqUJiXi4=; b=oKAoZWlmmReyAoJzeGTLRmCvynvSd 97jlntJBHJsB/H4vKp4oB5oCzA1jCeo/UlhHVi6eQJlZ4t6J7jQt9Gkz6NYc/SbJ mn0iw/Zm5QqXr3+poDy/YGaaa2hZ+8xTOctR9alSjZYxrDMQDJA9SyaFk8W1Aon+ 9OjwbSzp/tWRWKVf9cA20XbW2N6+SLTleL6qbpA5q4WOCkhXp4hCG2sC0zLiT3Ce zxK+HonebT4gnJ0x3JLf4S/DVgsC1sVTfxZS1B2J+ZHisiAQ03tILtsy0WTkFGUJ FunWCj/+Kh0aI5ClZxSDdNChsKy1lzfI2MlVH/p6WaUqbG7iY6p9YBoMA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedtjedgieehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdlfeehmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepjeejtdelleeggeelffduhfej tdeuvdekkeethffhuedvvdeuudeugeefudevtdeinecuffhomhgrihhnpehgihhthhhusg drtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhm pehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 8 Jun 2023 22:59:08 -0400 (EDT) Date: Fri, 9 Jun 2023 11:59:03 +0900 From: Michael Paquier To: Bharath Rupireddy Cc: vignesh C , Andrew Dunstan , Dagfinn Ilmari =?iso-8859-1?Q?Manns=E5ker?= , PostgreSQL Hackers Subject: Re: Implement generalized sub routine find_in_log for tap test Message-ID: References: <87cz2otiw3.fsf@wibble.ilmari.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="USvctkB8UPIM7J0b" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --USvctkB8UPIM7J0b Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 06, 2023 at 05:53:40PM +0530, Bharath Rupireddy wrote: > Yes. A simpler way of doing it would be to move advance_wal() in > 019_replslot_limit.pl to Cluster.pm, something like the attached. CI > members don't complain with it > https://github.com/BRupireddy/postgres/tree/add_a_function_in_Cluster.pm_to_generate_WAL. > Perhaps, we can name it better instead of advance_wal, say > generate_wal or some other? Why not discussing that on a separate thread? What you are proposing is independent of what Vignesh has proposed. Note that the patch format is octet-stream, causing extra CRs to exist in the patch. Something happened on your side when you sent your patch, I guess? -- Michael --USvctkB8UPIM7J0b Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmSClXcACgkQnvQgOdby QH2DGRAAi7cpIMKdoA72ngejNm0CYcRrScB5MeXpLXn8lTElA2rhc2rVClQYe564 JeSLr7i25u1Uhr7yP7pPozN3TfBYZtEPEcQTFFSLLHxatDsbhCH/ez7R4dMVj02g FDg5eFDOyB4xyG+o2wjq8RGG/3agO7iJMvLI+LTE5VrKDgrGC/83joTJxoZQ2TYV U43i9fw7zxamTnssgY7rpTFqZS2sgroaRhWg7cRtRa2TCxyvs0P6e+cT9kzmTsYz foUmXNcnG6t8iZwkvWBtoIHxUsjJFOOFXKN2C48s8vVSTpNNh4Nz3usddCZPa8pl r6PJKUpyuRhihxLg1OP1wtw3CnK6URHeIzpGF5bSdGR49foPywDSmS0HpIxUD44A 1FV1JkyLGw+Xw5oojPlRZHOGKo+noRxW6bgnCoQ/WvPDvKLU/7N7i6z7xTnaRMhb gnTSodRPcMHFSI1PU0H4fwGhFPVjpD2a2qOYGO5g45EkzGah62WE+peD69ErP0/8 +O62VNUSJiwcPr1iFGIQXOo2pNs/+KI/WQvuXI27hgBm40UfgLZSgaZX/QRxmzDO wg0eGJfsRp+hSj6dT9n5GcF+tBBXAu+ly1iHTb/xSCUIvlTuBM4QlwJirFvWNkun T+KS/FMKdt+KQTpV7EXn8KPvNuLfBlGCA4e1v/2GT4luPFmuVgQ= =7Odv -----END PGP SIGNATURE----- --USvctkB8UPIM7J0b--