public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Gurjeet Singh <[email protected]>
Cc: Ranier Vilela <[email protected]>
Cc: Richard Guo <[email protected]>
Cc: Pg Hackers <[email protected]>
Subject: Re: Avoid unncessary always true test (src/backend/storage/buffer/bufmgr.c)
Date: Tue, 13 Jun 2023 15:11:26 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CABwTF4W+WMr=3bjLP5-69+oG81BEZOH+SAqPX8GDnZry5==thA@mail.gmail.com>
References: <CAEudQAoSA7saBF7RaoYbRjE+Zojojin0Qc9A4hebPKB8o1J+EQ@mail.gmail.com>
<CAMbWs4_Jv4p_ib2ZZvUYhgoeSpOABjAW_4chkAhrSU=iW8CRGA@mail.gmail.com>
<CAEudQArD04043ahRO_9mXiYSfhvsac4SSyskUVk5PTm73Ab24A@mail.gmail.com>
<CAEudQArzX-q7FuvHxcEQKP9RuM7eFw4CnvU_xQtkiu4+tnaA4A@mail.gmail.com>
<CABwTF4W+WMr=3bjLP5-69+oG81BEZOH+SAqPX8GDnZry5==thA@mail.gmail.com>
On Mon, Jun 12, 2023 at 10:51:24PM -0700, Gurjeet Singh wrote:
> To me, it looks like these checks are a result of code being
> copy-pasted from somewhere else, where this check might have been
> necessary. The checks are sure not necessary at these spots.
I am not completely sure based on my read of the code, but isn't this
check needed to avoid some kind of race condition with a concurrent
backend may have worked on the relation when attempting to get the
lock?
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
download
view thread (11+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: Avoid unncessary always true test (src/backend/storage/buffer/bufmgr.c)
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox