Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9EvN-0002my-0i for pgsql-hackers@arkaria.postgresql.org; Wed, 14 Jun 2023 01:03:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1q9EvL-0008U0-TY for pgsql-hackers@arkaria.postgresql.org; Wed, 14 Jun 2023 01:03:47 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9EvL-0008To-HI for pgsql-hackers@lists.postgresql.org; Wed, 14 Jun 2023 01:03:47 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q9EvI-002Eo2-S2 for pgsql-hackers@postgresql.org; Wed, 14 Jun 2023 01:03:46 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 25153320090D; Tue, 13 Jun 2023 21:03:42 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 13 Jun 2023 21:03:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1686704621; x=1686791021; bh=iG LKJeMUNRyi1MvgEfW65D/nTlNBzd+8wLDhYWwddrU=; b=xLLhLcTxmqY1pyU6w4 ZMj8IjvMDbb18QKRLgcbao+dhJ97c+0hzzf20nl2YVUOQjs5mctYT64tqkkwoGqq nn4FUT/tPDUAjzBAqefrODAPZKdMRs3dvA4s6DF6WSfD7gcVtOZz4rmx1OCi9wPR shAt9fxbK6JwZNuyi2dKsm1JiWJWsLCore0zsNWI9G7FQhgB4RrPfLiBzr/rCETO ZrhD3raOLG0fg7fVA2apf06+8BH4uh9tCs34UxnhhWTDxdLZIbZWsuCAYTlRGy5p CT/JfezK6mjd/nF3b3Jn+1LboEXooAL1P79xNmfunIG8EZmjrjXmJuXBzFdM+4Au 7MbA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1686704621; x=1686791021; bh=iGLKJeMUNRyi1 MvgEfW65D/nTlNBzd+8wLDhYWwddrU=; b=flxeBBI0dz5CrkeMjlYlJh23XJGI2 afxpReg4TvWVqQiWkQHaD8WeWgixi9/fSZ7MIaZzVeaNNaocXVXgiDI9KonkInpZ gnRMMS9FMMjn+ZgXxj+xk45DyEAq4CKCc9pm6IMSBmvn5KrEz2tIdw4oh+8lNCb1 OaIkDo0u+M9VraLt8IcQTWsTe7yzaYyMKKWenQ9ibFh8HsCieDtQLtOEqNucv/Lv rZL/4wr94wcviNQWQq6pK7u3rBYAx+U+NJxxZjXU96JpeOzq/LuUId2W7jKWYP0g G0RXqglXRZ8YG6yWFcw67WSW4aucTiXw2mmQWng4Gl82c03EQ9ly/eKLQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeduledgtddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddunecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepgfehhefgudefudfgfeelgeei ffegfefhkeefffdvheefuddtheetgeelteevkeetnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 13 Jun 2023 21:03:33 -0400 (EDT) Date: Wed, 14 Jun 2023 10:03:24 +0900 From: Michael Paquier To: Dagfinn Ilmari =?iso-8859-1?Q?Manns=E5ker?= Cc: PostgreSQL Hackers , Peter Eisentraut Subject: Re: [PATCH] Using named captures in Catalog::ParseHeader() Message-ID: References: <87y1l3s7o9.fsf@wibble.ilmari.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="SyFJ67rSU1DLj5XQ" Content-Disposition: inline In-Reply-To: <87y1l3s7o9.fsf@wibble.ilmari.org> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --SyFJ67rSU1DLj5XQ Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 01, 2023 at 01:12:22PM +0100, Dagfinn Ilmari Manns=E5ker wrote: > While I was rewriting the regexes I noticed that they were inconsistent > about whether they accepted whitespace in the parameter lists, so I took > the liberty to make them consistently allow whitespace after the opening > paren and the commas, which is what most of them already did. That's the business with \s* in CATALOG. Is that right? Indeed, that's more consistent. > I've verified that the generated postgres.bki is identical to before, > and all tests pass. I find that pretty cool. Nice. Patch looks OK from here. -- Michael --SyFJ67rSU1DLj5XQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmSJEdwACgkQnvQgOdby QH0/BQ/9H6RlKPNIn2RIFEeX8EXbFdehoYSbartLhqthHHc1ESp51fUtpXyP9i+t LGezj0M7pzR12XpQM6M6BZAXHLoCnT2xTOlu4b6nX/EDJzeS6G5n1wIBcBXHE0db HU6EqiXy4Z7WvIuBXt8pY1tiJZiQqUiOuVHSarg/AwKC8BGAYx2NYyDbxwXydFmn eh18vo1DOSofFy7mE3D8nqI9H0AM8v4m40q0y43Awx3K1mAPo3dEpKqv0Jimzy8/ hFs39Z3Nyl9QwDySDxqzbbTJyD5kEAMvlfTr3nzjzWkBk/j0s6oWsi86Xh2s0ldX 2dLXjqlKjo5I7cA9vUYF1zbilt84FAvhofnuK+g6LEGxAktM0aWD3doByQBXTYGb xP6zZyZFW9x3EPJDfXJyHzpGUE61mpquU1dt38uEWcIvFwxt6NvzH3JOkBipqeui 2Lps1Vti8uYxhRWQFCXNC9ab6mXMkj8FjPTDvrtZnCTkNRGbwzUJcab9sNgPHNIV RiMIYgGp1EPkTUPg1X8xl/9gEgHMJJ4rOBNjM78cBbDOeewOKMUDidoT30GSOTUh JjPjmhzwGrEpTB8ECkkEPMduKzqntWAfdt3XpbXwPbpvWjUuBSY492dSFeOTGmsP Skc+ZxAS1GKPMz4r4IMVp+E6HqxQZwT0MBdtQ/l2T2EONdFIsZ8= =nte+ -----END PGP SIGNATURE----- --SyFJ67rSU1DLj5XQ--