Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9LEW-0000Xw-R3 for pgsql-hackers@arkaria.postgresql.org; Wed, 14 Jun 2023 07:48:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1q9LEU-0004Gm-Dd for pgsql-hackers@arkaria.postgresql.org; Wed, 14 Jun 2023 07:47:58 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9LES-0004GX-Rl for pgsql-hackers@lists.postgresql.org; Wed, 14 Jun 2023 07:47:58 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q9LEP-0027SM-GF for pgsql-hackers@lists.postgresql.org; Wed, 14 Jun 2023 07:47:55 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 3241A5C01CF; Wed, 14 Jun 2023 03:47:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 14 Jun 2023 03:47:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1686728872; x=1686815272; bh=JQ 8j2IRdtBKtYAHOLrLjYcBZEUadMaMMJFyQ4NtXBE0=; b=GVmGQAYRXUI8Zel+yM ot6K5nkcRpUo97qJ8wbTvYQcXOiHvF2B4G4k6aEiYWJxjMhzE48Tv9DBgddPkxNT Mrxj1e4vfHsx7ROcicsG2hX57fnGKmoROQJEx65q6XEglEFH94HDP8K8C2ngLM5E fTMz7co45gObM1RlpShG3iumaIrxRV6Rif65jRMSOgGSazugTcN3rGw9UTc/ARgp /Xuvk5H8FUKiPekE8aPp2bJDjWcqagiMi4clwoXFALUJqla58CRBxqCPUP/K9unX XRKiHc+RGes7MFgeytirz3jgfZGVm36uSAagq8DKnllPSE0c50EaNMJvN8cwM9jA lGQQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1686728872; x=1686815272; bh=JQ8j2IRdtBKtY AHOLrLjYcBZEUadMaMMJFyQ4NtXBE0=; b=UiRwS1AFZDYCmYlv3zmm5LrI4pOyc Bix1DWzO3hNoIuFV6Ig4AGlkOt9m82cir4GfmM4sCAfTy/0KgDIGFJKJ8uyL0WL1 u94s4t2mKwCnANSdBKl4MBPu+3znUqOzlSNOjLV17yYO81BcW/qnLmRZ2kj9cdVu nrRE+MC1nD3op3htjwasi8XhodM2rp8lNqajFvgmAhpgUjjR6T0VcmLB1MwadRB8 eHkHohtb3SSZFFl/G8EJoF3RttZekZ40dLQ+c9pKZpe0XJbKz4H0JFAxShXvnN5F 1Vojqpk/vyveWPXC4bPabFvBQdGf6vdj6FuxWahQgF1uaj/5UnlsYNjYw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeduledgkeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Jun 2023 03:47:49 -0400 (EDT) Date: Wed, 14 Jun 2023 16:47:45 +0900 From: Michael Paquier To: Richard Guo Cc: Masahiko Sawada , Japin Li , PostgreSQL Hackers Subject: Re: Replace (GUC_UNIT_MEMORY | GUC_UNIT_TIME) with GUC_UNIT in guc.c Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="+PPnlNdYqdU11F3L" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --+PPnlNdYqdU11F3L Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 14, 2023 at 03:38:10PM +0800, Richard Guo wrote: > +1. BTW, it seems that GUC_UNIT_TIME is not used anywhere except in > GUC_UNIT. I was wondering if we can retire it, but maybe we'd better > not. It still indicates that we need to use time units table. Some out-of-core code declaring custom GUCs could rely on that, so it is better not to remove it. -- Michael --+PPnlNdYqdU11F3L Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmSJcKEACgkQnvQgOdby QH1pjRAApEK687qKe4HxEifVOyYLR4rB0jVT5IGVyNbgF8M9Q2adENlX08h+zVvs dZ17M2Fufu+0HvUkPVBilEPYje6TAZXZrnKprXQTZ81MqJnD2H7WZ1KWNf8wyC3G cjLvelhmUuI8cZ1NG6oDOcQeCCzuVAYu6sUL973FSQy4vuCiRXTvAILa3pJjEn0p Avz3tru3RVKq2PkQbpkuQHoDTU9WqtPs9GO8vV4r5D+M0uWkz876PrC8lAoiPN9M 3LgaLPJa7zb/5/UMsu5OYtOG/Xhpo33T0qHNR7xjTMArTjOHr4UbstsWTAr6fam1 m8EhhOSGqP01YiwNR587XVJCVBd3Afu3gyJGC+07jB2H0Czp/fCn0E8nRHZ7SOMu phQXRBv7iEbwQdqiSx13ywWIaWD9E/KI0SKHZiVhA8LCdATxi1PJqnze4/GaqoD5 uShmW+8+uYURs0ZJ+SOJHWzPhjogKxfUvWIuFcbLVFzKwl3SZUg2b1FHeIzljx0L hN6F+XRV5a16OheyH/tKgMqkUPWM34+ZjG77f/6aHYFwigpiXmwWQDxLTb3pr8G/ WBhk3sV6vXGyftE5hSgSwFEjBSC5tcKj78FErcpf8/sFIknFdnPUWDmjKhYnivNJ MRZ8nsMXcUDyk6FrQ3OeafFNLtaw9PsJ3ZKqA4dROHBrIq0o6L4= =GwYh -----END PGP SIGNATURE----- --+PPnlNdYqdU11F3L--