public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Nathan Bossart <[email protected]>
Cc: Jeff Davis <[email protected]>
Cc: Ted Yu <[email protected]>
Cc: Pavel Luzanov <[email protected]>
Cc: Justin Pryzby <[email protected]>
Cc: [email protected]
Subject: Re: allow granting CLUSTER, REFRESH MATERIALIZED VIEW, and REINDEX
Date: Thu, 15 Jun 2023 09:46:33 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <20230614181711.GA488295@nathanxps13>
References: <20230109225157.GA1288965@nathanxps13>
<[email protected]>
<20230113203334.GA2206335@nathanxps13>
<[email protected]>
<20230113225626.GA2380176@nathanxps13>
<20230113231339.GA2422750@nathanxps13>
<20230613211246.GA219055@nathanxps13>
<[email protected]>
<20230613235442.GA222795@nathanxps13>
<20230614181711.GA488295@nathanxps13>
On Wed, Jun 14, 2023 at 11:17:11AM -0700, Nathan Bossart wrote:
> On Tue, Jun 13, 2023 at 04:54:42PM -0700, Nathan Bossart wrote:
> > On Wed, Jun 14, 2023 at 08:16:15AM +0900, Michael Paquier wrote:
> >> So, yes, agreed about the removal of has_partition_ancestor_privs().
> >> I am adding an open item assigned to you and Jeff.
> >
> > Thanks. I suspect there's more discussion incoming, but I'm hoping to
> > close this item one way or another by 16beta2.
>
> Concretely, I am proposing something like the attached patches.
The result after 0001 is applied is that a couple of
object_ownercheck() calls that existed before ff9618e are removed from
some ACL checks in the REINDEX, CLUSTER and VACUUM paths. Is that OK
for shared relations and shouldn't cluster_is_permitted_for_relation()
include that? vacuum_is_permitted_for_relation() is consistent on
this side.
Here are the paths that now differ:
cluster_rel
get_tables_to_cluster
get_tables_to_cluster_partitioned
RangeVarCallbackForReindexIndex
ReindexMultipleTables
0002 looks OK to retain the skip check for toast relations in the
VACUUM case.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
download
view thread (18+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: allow granting CLUSTER, REFRESH MATERIALIZED VIEW, and REINDEX
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox