Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qBlJE-0005GL-8x for pgsql-hackers@arkaria.postgresql.org; Wed, 21 Jun 2023 00:02:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1qBlJC-0007I3-G6 for pgsql-hackers@arkaria.postgresql.org; Wed, 21 Jun 2023 00:02:50 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qBlJA-0007Hj-UY for pgsql-hackers@lists.postgresql.org; Wed, 21 Jun 2023 00:02:50 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qBlJ6-003iMq-7P for pgsql-hackers@postgresql.org; Wed, 21 Jun 2023 00:02:47 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 0335B5C00F2; Tue, 20 Jun 2023 20:02:42 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 20 Jun 2023 20:02:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1687305761; x=1687392161; bh=Sf 2a3AFE5oNbhCAEw8gsaTcbSkelABwYOe+MqFxsiDs=; b=jWwjgaRVYcfziXwgQB 1hyT2AW5S3DRjiOoyujmo7MdfJT2Jl+uag2gTxtT2nUBBEQ46dyv4dP5IP57eoR3 FZQUbEaJplT9K8iypqlUeEp06fkp8i6KhgEn4uXR/DPmu5Tt0heZpdVnK87C0kQc bj1uXnmAJkrewBZx7t94VACh2P5hCECn9Xhe7jp4oMFmJxiiZogxQ+m6oophBdM7 sUViHHV0NrQ+y6CB0+FPJlXotMGlFb8G2T8xL/TKenBIH/o8Qpv3iLyqmsvi6fnG XteZNJzPQ7g4hjBNSGEQZccE2zG7OPETB7KdQC2tuPrYXIz/1l9u+xLq1LgKj7hD 679Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1687305761; x=1687392161; bh=Sf2a3AFE5oNbh CAEw8gsaTcbSkelABwYOe+MqFxsiDs=; b=qKhnn14kQK2G5rvxTYjTzYnF2XelE 0joNr7fcM68MHKk498KJ+jmDH08CWJ53L/ojPNkWBfaWsHh0oIbol/wZwgP5fwa1 gjo7nDRmPO8DWVcol/Fdff9e1vfa6SArnB9jseYgHpp0KjWY01yIKNEWHaTftWsD q0oiivzC87xcvzOm2C7mP1nh69KXRC/gTmOdmlPJBR/gw1MgWn4LFCtC/0MMfWDl m/dfhjVWT/87RZoPLS/VtTpNUkaWjKm6AKe4BZKCTlAO9TlLL7B8/JPLGEn2s660 IVUsu0O29bXnm78de/4vvuh+IaKyqcUMJpKQBp84RcuAq3jhNxJXfyiwg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeefiedgvdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 20 Jun 2023 20:02:40 -0400 (EDT) Date: Wed, 21 Jun 2023 09:02:35 +0900 From: Michael Paquier To: Evan Jones Cc: Tom Lane , pgsql-hackers@postgresql.org Subject: Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific Message-ID: References: <2765603.1687106292@sss.pgh.pa.us> <2823519.1687137059@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZIjvYpV0D6ZxysKr" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --ZIjvYpV0D6ZxysKr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 20, 2023 at 09:04:26AM -0400, Evan Jones wrote: > My one last suggestion: We *could* revert the backpatching if we are > concerned about this change, but I'm not personally sure that is necessary. > As we discussed, this is an unusual corner case in an "extension" type that > many won't even have enabled. As a whole, I'd like to think that this is an improvement even for stable branches with these weird isspace() handlings, so I'm OK with the current status in all the branches. There's an argument about \v, IMO, but I won't fight hard for it either even if it would be more consistent with the way array values are handled. -- Michael --ZIjvYpV0D6ZxysKr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmSSPhsACgkQnvQgOdby QH27XBAApiP5vFqw+HJ1uWNUgQxmIyFPtB6MsStdkWLKARBS+9LucQ7owxdziXFs acrstIboLKhw3Rt/Z2qSyVh9t1uk5G4ptBbJm8P35QiO7qi4GuDKujtMBzOa7/mx n3dPEZO8uby5DbD5TPheO5DhwBPM+86xuw1mNo6yFU1j4MqfMD9s6DzamdskXfFY o0LBblTdWrJOhledDpB6OjTVMpC1uaiUuEqMdIogPnaz32V6oqxLnS0EdWhO807x woEi0QgdeWysyXKpi27wHBrnf1roHGenZaUH9S8eIyht/ukyU/xw7G77Fet7lOeY xgkCo7RDFUmF/8eQYJwaTl7jsSHYMPS0XpYx9w2XAcrwgVgyoUmRgd96xn6j1Pc/ 0xbeqIyvUn09GQPAo71jvqArvgxNdP3Oi3OUnhbZRA+K6BBC5uTCzGX9TvgigChm A6hylgF6zx1Rqjh8TCO1W6VjXdWAYLFN/PVma97rW9hOly1qSXwQAEraeZRST/BQ SQuFY9e4fc8bMn9wF+TJQqMc2RbWZTxWegFIeLWRdyI5glmUivT6AR+NdDhUA3+t 9NhYfBPRSbH09+BNgDZkutKa6gOsPVHujj/2XYnxe8vK+9Rs66Qw3znw23l8GNwn kjeEQG0610Nyjw00++52aYi72pJOqoSTIvkE6ORehLmZLxLy25s= =DnYh -----END PGP SIGNATURE----- --ZIjvYpV0D6ZxysKr--