Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 28 Jun 2023 08:47:21 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org, masao.fujii@gmail.com,
	david.christensen@crunchydata.com
Subject: Re: Add TLI number to name of files generated by pg_waldump
 --save-fullpage
Message-ID: <ZJt1CYvQduFYnQkF@paquier.xyz>
References: <ZJp921+nITFnvBVS@paquier.xyz>
 <20230627.154404.922227939135916807.horikyota.ntt@gmail.com>
 <ZJqInm5KoY/4rzNl@paquier.xyz>
 <20230627.163952.2129200447170879116.horikyota.ntt@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="LzLIzlZRltLaI+ot"
Content-Disposition: inline
In-Reply-To: <20230627.163952.2129200447170879116.horikyota.ntt@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZJt1CYvQduFYnQkF%40paquier.xyz>
Precedence: bulk


--LzLIzlZRltLaI+ot
Content-Type: multipart/mixed; boundary="RvhYCxatoFKl1Ope"
Content-Disposition: inline


--RvhYCxatoFKl1Ope
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jun 27, 2023 at 04:39:52PM +0900, Kyotaro Horiguchi wrote:
> I meant that the name is structured as
> TLIh-TLIl.<tablespace>.<database>.<relnumber>.<blk>._<fork>, which
> appears to be inconsistent with the comment. (And I'm not sure what
> "TLOID" is..)

Well, to be clear, it should not be TLIh-TLIl but LSNh-LSNl :)

I'm OK with these terms for the comments.  This is very internal
anyway so anybody using this feature should know what that means.

And yes, the order of the items is wrong, and I agree that TLOID is a
bit confusing once the TLI is added in the set.  I have just used
TBLSPCOID as term in the comment, and adjusted the XXX to be about the
LSN numbers.

Adjusted as per the v2 attached.
--
Michael

--RvhYCxatoFKl1Ope
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
	filename="v2-0001-Add-timeline-to-file-names-generated-with-pg_wald.patch"
Content-Transfer-Encoding: quoted-printable

=46rom f0936a95651f767e0f56ff507db5d5a02c7629b2 Mon Sep 17 00:00:00 2001
=46rom: Michael Paquier <michael@paquier.xyz>
Date: Wed, 28 Jun 2023 08:46:26 +0900
Subject: [PATCH v2] Add timeline to file names generated with pg_waldump
 --save-fullpage

Reported-by: Fujii Masao
---
 src/bin/pg_waldump/pg_waldump.c           | 3 ++-
 src/bin/pg_waldump/t/002_save_fullpage.pl | 9 +++++----
 doc/src/sgml/ref/pg_waldump.sgml          | 9 ++++++++-
 3 files changed, 15 insertions(+), 6 deletions(-)

diff --git a/src/bin/pg_waldump/pg_waldump.c b/src/bin/pg_waldump/pg_waldum=
p.c
index c6d3ae6344..96845e1a1a 100644
--- a/src/bin/pg_waldump/pg_waldump.c
+++ b/src/bin/pg_waldump/pg_waldump.c
@@ -518,7 +518,8 @@ XLogRecordSaveFPWs(XLogReaderState *record, const char =
*savepath)
 		else
 			pg_fatal("invalid fork number: %u", fork);
=20
-		snprintf(filename, MAXPGPATH, "%s/%08X-%08X.%u.%u.%u.%u%s", savepath,
+		snprintf(filename, MAXPGPATH, "%s/%08X-%08X-%08X.%u.%u.%u.%u%s", savepat=
h,
+				 record->seg.ws_tli,
 				 LSN_FORMAT_ARGS(record->ReadRecPtr),
 				 rnode.spcOid, rnode.dbOid, rnode.relNumber, blk, forkname);
=20
diff --git a/src/bin/pg_waldump/t/002_save_fullpage.pl b/src/bin/pg_waldump=
/t/002_save_fullpage.pl
index 831ffdefef..f0725805f2 100644
--- a/src/bin/pg_waldump/t/002_save_fullpage.pl
+++ b/src/bin/pg_waldump/t/002_save_fullpage.pl
@@ -79,15 +79,16 @@ $node->command_ok(
 	'pg_waldump with --save-fullpage runs');
=20
 # This regexp will match filenames formatted as:
-# XXXXXXXX-XXXXXXXX.DBOID.TLOID.NODEOID.dd_fork with the components being:
-# - WAL LSN in hex format,
-# - Tablespace OID (0 for global)
+# TLI-LSNh-LSNl.TBLSPCOID.DBOID.NODEOID.dd_fork with the components being:
+# - Timeline ID in hex format.
+# - WAL LSN in hex format, as two 8-character numbers.
+# - Tablespace OID (0 for global).
 # - Database OID.
 # - Relfilenode.
 # - Block number.
 # - Fork this block came from (vm, init, fsm, or main).
 my $file_re =3D
-  qr/^([0-9A-F]{8})-([0-9A-F]{8})[.][0-9]+[.][0-9]+[.][0-9]+[.][0-9]+(?:_v=
m|_init|_fsm|_main)?$/;
+  qr/^[0-9A-F]{8}-([0-9A-F]{8})-([0-9A-F]{8})[.][0-9]+[.][0-9]+[.][0-9]+[.=
][0-9]+(?:_vm|_init|_fsm|_main)?$/;
=20
 my $file_count =3D 0;
=20
diff --git a/doc/src/sgml/ref/pg_waldump.sgml b/doc/src/sgml/ref/pg_waldump=
=2Esgml
index e5f9637847..4592d6016a 100644
--- a/doc/src/sgml/ref/pg_waldump.sgml
+++ b/doc/src/sgml/ref/pg_waldump.sgml
@@ -283,7 +283,7 @@ PostgreSQL documentation
        </para>
        <para>
         The full page images are saved with the following file name format:
-        <literal><replaceable>LSN</replaceable>.<replaceable>RELTABLESPACE=
</replaceable>.<replaceable>DATOID</replaceable>.<replaceable>RELNODE</repl=
aceable>.<replaceable>BLKNO</replaceable><replaceable>FORK</replaceable></l=
iteral>
+        <literal><replaceable>TIMELINE</replaceable>-<replaceable>LSN</rep=
laceable>.<replaceable>RELTABLESPACE</replaceable>.<replaceable>DATOID</rep=
laceable>.<replaceable>RELNODE</replaceable>.<replaceable>BLKNO</replaceabl=
e><replaceable>FORK</replaceable></literal>
=20
         The file names are composed of the following parts:
         <informaltable>
@@ -296,6 +296,13 @@ PostgreSQL documentation
           </thead>
=20
           <tbody>
+           <row>
+            <entry>TIMELINE</entry>
+            <entry>The timeline of the WAL segment file where the record
+             is located formatted as one 8-character hexadecimal number
+             <literal>%08X</literal></entry>
+           </row>
+
            <row>
             <entry>LSN</entry>
             <entry>The <acronym>LSN</acronym> of the record with this imag=
e,
--=20
2.40.1


--RvhYCxatoFKl1Ope--

--LzLIzlZRltLaI+ot
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmSbdQkACgkQnvQgOdby
QH1D5w//UkEW7tltE4DGKgzvk7ivWUn8hyiM4a7HFfd0DXLGiR+/ts7wYr6sc7Pi
p4rK6TwoVqNsw3/PctKZVA0Mttczl1eT7pJKYwBNrmnO9iOw2FIuIhW0Q7ws4wbZ
MxMEzCJehhHCNLNWjOggWi5ldsnD91rio3cpKKqohHHA+xcDcOfEXKVxT/nbnwNy
G5CO6KlZljw202iChNDNV09QB18nDP6TiwD2VrlMKNuOwMXKgueQpMzDL6nZHCqn
Wf2wgygLFC0Wsl4F2UkzWOPD7AGLXENnsr9/UKVAxgnKDiP2DShxkdokAzTzF2lY
12bcqfwWApFIqfY6fyhqRw6S4FuusMyPcng1Rsl5C4Qi45V6b/FTy3//ElescmRW
wJYECOAwD5zLSUMbEonC6nOdfdK+Spnax15ohELMe5uWPA9sOJcsX2YZXRTq8cOG
LrnB/tklzmZHMOHy+kbSbeCkemBnkXCVYhFUBt93uj16LJIwaHqfxiXfrqqijXZd
eygVPG1v6sKySDx0npHJNTLYyPEjwHZv3irdbSd+7Vn2eYGxX7n9ZN9QhZgoRNfW
YSYwVyY3knGy9mEZakYMWAmPI3rEKwtea7nXABcdSYBVoIDymFbRHljvkrWPB12G
9U6WCmI/XS6fU6DkfELX0w421/LjW8OUGB6K0HMKH8iMj0UAjJE=
=QRCg
-----END PGP SIGNATURE-----

--LzLIzlZRltLaI+ot--